socket_wrapper changes and ctdb

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

socket_wrapper changes and ctdb

Samba - samba-technical mailing list
Hi,

I'm currently trying to move the wrappers to the third_party directory. I've
also changed the ctdb wscript but it always fails in autobuild now.

It fails with:

cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
Aborted (core dumped)
make: *** [autotest] Error 1

which seems to be unrelated. The logs are here:

https://git.samba.org/asn/samba-autobuild/ctdb.stdout
https://git.samba.org/asn/samba-autobuild/ctdb.stderr


Could you please take a look? The repo with the changes is:

https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/master-cwrap


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Fwd: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
Hi Andreas,

On Wed, Nov 15, 2017 at 2:34 AM, Andreas Schneider via samba-technical <
[hidden email]> wrote:

> Hi,
>
> I'm currently trying to move the wrappers to the third_party directory.
> I've
> also changed the ctdb wscript but it always fails in autobuild now.
>
> It fails with:
>
> cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
> unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
> Aborted (core dumped)
> make: *** [autotest] Error 1
>
> which seems to be unrelated. The logs are here:
>
> https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> https://git.samba.org/asn/samba-autobuild/ctdb.stderr

Looks like you uncovered a race condition in sock_daemon code.  I am working
on some improvements in sock_daemon. Will post the patches in a day or two
after fixing the race condition.


> Could you please take a look? The repo with the changes is:
>
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/hea
> ds/master-cwrap
>
>
Looks like there are some patches missing from this branch.  I cannot
configure or build ctdb using just your branch.  It needs attached patch.

Also, on debian with glibc 2.24 socket_wrapper requires pthread dependency
for pthread_atfork() function.  On fedora 26 with glibc 2.25 it does not
seem
to require pthread dependency.

Amitay.

0001-ctdb-build-Fixup-for-moving-socket_wrapper-to-third_.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wednesday, 15 November 2017 10:04:27 CET Amitay Isaacs wrote:

> Hi Andreas,
>
> On Wed, Nov 15, 2017 at 2:34 AM, Andreas Schneider via samba-technical <
>
> [hidden email]> wrote:
> > Hi,
> >
> > I'm currently trying to move the wrappers to the third_party directory.
> > I've
> > also changed the ctdb wscript but it always fails in autobuild now.
> >
> > It fails with:
> >
> > cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
> > unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
> > Aborted (core dumped)
> > make: *** [autotest] Error 1
> >
> > which seems to be unrelated. The logs are here:
> >
> > https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> > https://git.samba.org/asn/samba-autobuild/ctdb.stderr
>
> Looks like you uncovered a race condition in sock_daemon code.  I am working
> on some improvements in sock_daemon. Will post the patches in a day or two
> after fixing the race condition.

Thanks, then I will wait with pushing till you fix it.

>
> > Could you please take a look? The repo with the changes is:
> >
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/
> > heads/master-cwrap
>
> Looks like there are some patches missing from this branch.  I cannot
> configure or build ctdb using just your branch.  It needs attached patch.

I've applied your patch and pushed it upstream. Only one line applied, maybe I
didn't push the latest version to my git repo, sorry.

>
> Also, on debian with glibc 2.24 socket_wrapper requires pthread dependency
> for pthread_atfork() function.  On fedora 26 with glibc 2.25 it does not
> seem
> to require pthread dependency.

I've fixed that already too. Pushed latest version to the git repo now.


Thanks for your help!


        Andreas




--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wednesday, 15 November 2017 10:17:46 CET Amitay Isaacs via samba-technical
wrote:

> Hi Andreas,
>
> On Wed, Nov 15, 2017 at 2:34 AM, Andreas Schneider via samba-technical <
>
> [hidden email]> wrote:
> > Hi,
> >
> > I'm currently trying to move the wrappers to the third_party directory.
> > I've
> > also changed the ctdb wscript but it always fails in autobuild now.
> >
> > It fails with:
> >
> > cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
> > unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
> > Aborted (core dumped)
> > make: *** [autotest] Error 1
> >
> > which seems to be unrelated. The logs are here:
> >
> > https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> > https://git.samba.org/asn/samba-autobuild/ctdb.stderr
>
> Looks like you uncovered a race condition in sock_daemon code.  I am working
> on some improvements in sock_daemon. Will post the patches in a day or two
> after fixing the race condition.

Hi Amitay,

I've just saw that some sock_daemon patches went in. I've tried to push my
branch again, but it fails at the same test.

https://git.samba.org/asn/samba-autobuild/ctdb.stdout
https://git.samba.org/asn/samba-autobuild/ctdb.stderr


Cheers,


        Andreas


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
On Tue, Nov 21, 2017 at 9:09 PM, Andreas Schneider <[hidden email]> wrote:

> On Wednesday, 15 November 2017 10:17:46 CET Amitay Isaacs via
> samba-technical
> wrote:
> > Hi Andreas,
> >
> > On Wed, Nov 15, 2017 at 2:34 AM, Andreas Schneider via samba-technical <
> >
> > [hidden email]> wrote:
> > > Hi,
> > >
> > > I'm currently trying to move the wrappers to the third_party directory.
> > > I've
> > > also changed the ctdb wscript but it always fails in autobuild now.
> > >
> > > It fails with:
> > >
> > > cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
> > > unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
> > > Aborted (core dumped)
> > > make: *** [autotest] Error 1
> > >
> > > which seems to be unrelated. The logs are here:
> > >
> > > https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> > > https://git.samba.org/asn/samba-autobuild/ctdb.stderr
> >
> > Looks like you uncovered a race condition in sock_daemon code.  I am
> working
> > on some improvements in sock_daemon. Will post the patches in a day or
> two
> > after fixing the race condition.
>
> Hi Amitay,
>
> I've just saw that some sock_daemon patches went in. I've tried to push my
> branch again, but it fails at the same test.
>
> https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> https://git.samba.org/asn/samba-autobuild/ctdb.stderr
>
>
Wow.  Now it's a different failure. :-)

Here is the patch that fixes the test code.

It's surprising that the tests pass without the cwrap patches
(moving socket wrapper to third_party).  So something has
changed in the socket_wrapper code.

Amitay.

0001-ctdb-tests-Make-sure-child-processes-are-waited-on-a.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
On Wed, 22 Nov 2017 14:58:52 +1100, Amitay Isaacs via samba-technical
<[hidden email]> wrote:

> Wow.  Now it's a different failure. :-)
>
> Here is the patch that fixes the test code.
>
> It's surprising that the tests pass without the cwrap patches
> (moving socket wrapper to third_party).  So something has
> changed in the socket_wrapper code.

Yeah, this is weird.  SIGKILL should put the process into zombie state
and, if I understand correctly, all resources should be freed (except
the process table entry).  It looks to be working like that without
socket wrapper.  However, I don't see how socket wrapper could change
that behaviour...  :-(

If I get time (though not sure I will) I'll grab the socket wrapper
tree and bisect between the versions to see what commit causes the
change in behaviour:

-VERSION="1.1.7"
+VERSION="1.1.8"

Extra effort in doing such a bisect is a price we pay for socket
wrapper being developed out of tree...  :-(

peace & happiness,
martin

Reply | Threaded
Open this post in threaded view
|

Re: socket_wrapper changes and ctdb

Samba - samba-technical mailing list
On Wednesday, 22 November 2017 06:06:48 CET Martin Schwenke wrote:

> On Wed, 22 Nov 2017 14:58:52 +1100, Amitay Isaacs via samba-technical
>
> <[hidden email]> wrote:
> > Wow.  Now it's a different failure. :-)
> >
> > Here is the patch that fixes the test code.
> >
> > It's surprising that the tests pass without the cwrap patches
> > (moving socket wrapper to third_party).  So something has
> > changed in the socket_wrapper code.
>
> Yeah, this is weird.  SIGKILL should put the process into zombie state
> and, if I understand correctly, all resources should be freed (except
> the process table entry).  It looks to be working like that without
> socket wrapper.  However, I don't see how socket wrapper could change
> that behaviour...  :-(
>
> If I get time (though not sure I will) I'll grab the socket wrapper
> tree and bisect between the versions to see what commit causes the
> change in behaviour:
>
> -VERSION="1.1.7"
> +VERSION="1.1.8"
>
> Extra effort in doing such a bisect is a price we pay for socket
> wrapper being developed out of tree...  :-(

Why? You just download the socket_wrapper git tree and bisect it there. That's
how I do it.


        Andreas




--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org