s3-printing: precreate DriverStore directories patch

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

s3-printing: precreate DriverStore directories patch

Samba - samba-technical mailing list
On Wed, Jul 26, 2017 at 05:35:03AM +0200, Andreas Schneider wrote:

> The branch, master has been updated
>        via  8865ded s3-printing: precreate DriverStore directories.
>        via  2621a2d s3-printing: add spoolss_get_short_filesys_environment function.
>        via  a17cb9e s3-printing: pre-create color and PCC directories under print$.
>       from  5005a3a libsmb: Enable "cli_notify" for SMB2+
>
> https://git.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 8865dede5703a93c71fc2cb9417688f751ea2c69
> Author: G√ľnther Deschner <[hidden email]>
> Date:   Mon Sep 12 21:00:18 2016 +0200
>
>     s3-printing: precreate DriverStore directories.
>    
>     Guenther
>    
>     Signed-off-by: Guenther Deschner <[hidden email]>
>     Reviewed-by: Andreas Schneider <[hidden email]>

Guenther and Andreas - there are missing
NULL return checks on the calls to
state_path() in this patch.

(state_path() returns a talloc'ed string, which
can return NULL).

Can you add the checks in and post for review
please ?

Thanks,

Jeremy.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: s3-printing: precreate DriverStore directories patch

Samba - samba-technical mailing list
On Wednesday, 26 July 2017 18:39:09 CEST Jeremy Allison via samba-technical
wrote:
> Guenther and Andreas - there are missing
> NULL return checks on the calls to
> state_path() in this patch.
>
> (state_path() returns a talloc'ed string, which
> can return NULL).
>
> Can you add the checks in and post for review
> please ?

Yes, see attached patch.


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

0001-s3-printing-Add-NULL-check-for-state_path.patch.txt (1K) Download Attachment
Loading...