s3: Patch to smbclient to add a utimes command for setting the Windows times

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
Hi folks,

Here is a patch to smbclient that adds a utimes command so that you
can set the times on files.

It could perhaps be improved but it would seem to be enough for my
tests where I need to set times from scripts and verify that they are
correctly set.

Signed-off-by: Richard Sharpe <[hidden email]>

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

0001-s3-Add-a-utimes-command-to-smbclient-so-we-can-set-t.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
On Wednesday, 13 September 2017 20:31:47 CEST Richard Sharpe via samba-
technical wrote:

> Hi folks,
>
> Here is a patch to smbclient that adds a utimes command so that you
> can set the times on files.
>
> It could perhaps be improved but it would seem to be enough for my
> tests where I need to set times from scripts and verify that they are
> correctly set.
>
> Signed-off-by: Richard Sharpe <[hidden email]>


ENOTEST


There is no script to verify that it this actually working ;-)


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 11:21 PM, Andreas Schneider <[hidden email]> wrote:

> On Wednesday, 13 September 2017 20:31:47 CEST Richard Sharpe via samba-
> technical wrote:
>> Hi folks,
>>
>> Here is a patch to smbclient that adds a utimes command so that you
>> can set the times on files.
>>
>> It could perhaps be improved but it would seem to be enough for my
>> tests where I need to set times from scripts and verify that they are
>> correctly set.
>>
>> Signed-off-by: Richard Sharpe <[hidden email]>
>
>
> ENOTEST
>
>
> There is no script to verify that it this actually working ;-)

Damn. You are a hard task master!

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 11:21 PM, Andreas Schneider <[hidden email]> wrote:

> On Wednesday, 13 September 2017 20:31:47 CEST Richard Sharpe via samba-
> technical wrote:
>> Hi folks,
>>
>> Here is a patch to smbclient that adds a utimes command so that you
>> can set the times on files.
>>
>> It could perhaps be improved but it would seem to be enough for my
>> tests where I need to set times from scripts and verify that they are
>> correctly set.
>>
>> Signed-off-by: Richard Sharpe <[hidden email]>
>
>
> ENOTEST
>
>
> There is no script to verify that it this actually working ;-)

If I start with testprogs/blackbox/test_password_settings.sh it looks
like I can get something working ...

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 11:31 AM, Richard Sharpe
<[hidden email]> wrote:

> Hi folks,
>
> Here is a patch to smbclient that adds a utimes command so that you
> can set the times on files.
>
> It could perhaps be improved but it would seem to be enough for my
> tests where I need to set times from scripts and verify that they are
> correctly set.
>
> Signed-off-by: Richard Sharpe <[hidden email]>

Attached is a change that makes the time format more consistent with
what is printed out.

I am also looking at adding support for SMB2 transports as well as a
test ... since Andreas insists.

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
On Thu, Sep 14, 2017 at 10:07:36AM -0700, Richard Sharpe via samba-technical wrote:

> On Wed, Sep 13, 2017 at 11:31 AM, Richard Sharpe
> <[hidden email]> wrote:
> > Hi folks,
> >
> > Here is a patch to smbclient that adds a utimes command so that you
> > can set the times on files.
> >
> > It could perhaps be improved but it would seem to be enough for my
> > tests where I need to set times from scripts and verify that they are
> > correctly set.
> >
> > Signed-off-by: Richard Sharpe <[hidden email]>
>
> Attached is a change that makes the time format more consistent with
> what is printed out.

ENOPATCH :-).

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
On Thu, Sep 14, 2017 at 11:37 AM, Jeremy Allison <[hidden email]> wrote:

> On Thu, Sep 14, 2017 at 10:07:36AM -0700, Richard Sharpe via samba-technical wrote:
>> On Wed, Sep 13, 2017 at 11:31 AM, Richard Sharpe
>> <[hidden email]> wrote:
>> > Hi folks,
>> >
>> > Here is a patch to smbclient that adds a utimes command so that you
>> > can set the times on files.
>> >
>> > It could perhaps be improved but it would seem to be enough for my
>> > tests where I need to set times from scripts and verify that they are
>> > correctly set.
>> >
>> > Signed-off-by: Richard Sharpe <[hidden email]>
>>
>> Attached is a change that makes the time format more consistent with
>> what is printed out.
>
> ENOPATCH :-).
Sorry. Should be attached now.

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

0001-s3-Add-a-utimes-command-to-smbclient-so-we-can-set-t.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
On Thu, Sep 14, 2017 at 12:21:16PM -0700, Richard Sharpe via samba-technical wrote:
> > ENOPATCH :-).
>
> Sorry. Should be attached now.

Standard review reply from me: This has lines beyond 80 characters. We
have a snippet in README.Coding about that:

* Maximum Line Width is 80 Characters
  The reason is not about people with low-res screens but rather sticking
  to 80 columns prevents you from easily nesting more than one level of
  if statements or other code blocks.  Use source3/script/count_80_col.pl
  to check your changes.

Can you make sure that you get the lines into that range?

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: s3: Patch to smbclient to add a utimes command for setting the Windows times

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 11:31 AM, Richard Sharpe
<[hidden email]> wrote:

> Hi folks,
>
> Here is a patch to smbclient that adds a utimes command so that you
> can set the times on files.
>
> It could perhaps be improved but it would seem to be enough for my
> tests where I need to set times from scripts and verify that they are
> correctly set.
>
> Signed-off-by: Richard Sharpe <[hidden email]>
OK, next patch. We now have a blackbox test and I have made sure lines
are <= 80 chars.

Signed-off-by: Richard Sharpe <[hidden email]>

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

0001-s3-Add-a-utimes-command-to-smbclient-so-we-can-set-t.patch (11K) Download Attachment