Quantcast

ctdb -n all / -n 1,2 does not work anymore

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ctdb -n all / -n 1,2 does not work anymore

Samba - samba-technical mailing list
Hi!

Since Samba 4.5.0 the ctdb -n option does only take numeric values.

# ctdb ping -n all
Invalid option all: invalid numeric value

According to the ctdb(1) man page the -n option accepts 'PNN-LIST'

   -n PNN-LIST
       The nodes specified by PNN-LIST should be queried for the
       requested information. Default is to query the daemon running
       on the local host.

and this is documented as

   PNN-LIST
       This is either a single PNN, a comma-separate list of PNNs or
       "all".

Also the release notes of Samba 4.5.0 do not include this specific
behaviour change information. But it's mentioned that 'ctdb tool' has
been completely rewritten using new client API.

Additionaly there is a Nagios plugin 'check_ctdb', which is also part of
the Samba 4.6 source in ctdb/utils/nagios/check_ctdb. This does also use
the '-n all' and is consequently broken.

Was this limitation to the -n option introduced accidentally during
rewriting the ctdb command?

Best regards,
Björn

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Samba eXPerience 2017, Hotel Freizeit In
2nd-4th of May 2017, http://sambaXP.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: ctdb -n all / -n 1,2 does not work anymore

Samba - samba-technical mailing list
On Wed, Apr 5, 2017 at 9:14 PM, Bjoern Baumbach via samba-technical <
[hidden email]> wrote:

> Hi!
>
> Since Samba 4.5.0 the ctdb -n option does only take numeric values.
>
> # ctdb ping -n all
> Invalid option all: invalid numeric value
>
> According to the ctdb(1) man page the -n option accepts 'PNN-LIST'
>
>    -n PNN-LIST
>        The nodes specified by PNN-LIST should be queried for the
>        requested information. Default is to query the daemon running
>        on the local host.
>
> and this is documented as
>
>    PNN-LIST
>        This is either a single PNN, a comma-separate list of PNNs or
>        "all".
>
> Also the release notes of Samba 4.5.0 do not include this specific
> behaviour change information. But it's mentioned that 'ctdb tool' has
> been completely rewritten using new client API.
>

Oops.  Looks like we forgot to update the documentation for -n option.
Please create a new defect.
"ctdb --help" does show the correct usage.


> Additionaly there is a Nagios plugin 'check_ctdb', which is also part of
> the Samba 4.6 source in ctdb/utils/nagios/check_ctdb. This does also use
> the '-n all' and is consequently broken.
>

This also requires to be fixed.  Please create a separate defect for this
one.  We need to add a test for the plugin to ensure there are no
regressions.


>
> Was this limitation to the -n option introduced accidentally during
> rewriting the ctdb command?
>

No. This is intentional.  This is to ensure that all the ctdb commands are
consistent with regards to -n option.  In the earlier version, not all
commands behaved in the same way with -n all.  Now -n takes only single PNN.


>
> Best regards,
> Björn
>

Amitay.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: ctdb -n all / -n 1,2 does not work anymore

Samba - samba-technical mailing list
On 04/05/2017 03:53 PM, Amitay Isaacs wrote:
> On Wed, Apr 5, 2017 at 9:14 PM, Bjoern Baumbach via samba-technical
> <[hidden email]
> <mailto:[hidden email]>> wrote:
>>     Since Samba 4.5.0 the ctdb -n option does only take numeric values.
>
> Oops.  Looks like we forgot to update the documentation for -n option.
> Please create a new defect.

https://bugzilla.samba.org/show_bug.cgi?id=12733

> This also requires to be fixed.  Please create a separate defect for
> this one.  We need to add a test for the plugin to ensure there are no
> regressions.

https://bugzilla.samba.org/show_bug.cgi?id=12734

Best regards
Björn

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Samba eXPerience 2017, Hotel Freizeit In
2nd-4th of May 2017, http://sambaXP.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: ctdb -n all / -n 1,2 does not work anymore

Samba - samba-technical mailing list
On Thu, Apr 6, 2017 at 5:00 AM, Bjoern Baumbach <[hidden email]> wrote:

> On 04/05/2017 03:53 PM, Amitay Isaacs wrote:
> > On Wed, Apr 5, 2017 at 9:14 PM, Bjoern Baumbach via samba-technical
> > <[hidden email]
> > <mailto:[hidden email]>> wrote:
> >>     Since Samba 4.5.0 the ctdb -n option does only take numeric values.
> >
> > Oops.  Looks like we forgot to update the documentation for -n option.
> > Please create a new defect.
>
> https://bugzilla.samba.org/show_bug.cgi?id=12733


This is a trivial fix and will be posted soon.


>
> > This also requires to be fixed.  Please create a separate defect for
> > this one.  We need to add a test for the plugin to ensure there are no
> > regressions.
>
> https://bugzilla.samba.org/show_bug.cgi?id=12734


Does any one really use ctdb nagios plugin?

Mathieu,

I would really like to understand the motivation behind monitoring "ctdb
scriptstatus" and "ctdb ping" output.

To monitor ctdb cluster, "ctdb status" is better.  To get any performance
data, "ctdb statistics" should be used.

Amitay.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: ctdb -n all / -n 1,2 does not work anymore

Samba - samba-technical mailing list
On 04/06/2017 06:09 AM, Amitay Isaacs wrote:
> Does any one really use ctdb nagios plugin?

Yes.

Best regards,
Björn

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Samba eXPerience 2017, Hotel Freizeit In
2nd-4th of May 2017, http://sambaXP.org

Loading...