cclean manpage?

[Andreas Schneider-2]

On Wednesday 27 June 2012 10:08:02 Michael Adam wrote:
> - Log -----------------------------------------------------------------
> commit c4be17f804a857630b4c5f9d0aad70b508e56e2e
> Author: Gregor Beck <[hidden email]>
> Date:   Thu Jun 7 13:34:35 2012 +0200
>
>     s3: add a tool "cclean" to cleanup orphaned entries from connections.tdb
>
>     Signed-off-by: Michael Adam <[hidden email]>
>

Hi,

I don't see a manpage for that tool. Please provide one.


Cheers,

        -- andreas

--
Andreas Schneider                   GPG-ID: F33E3FC6
www.cryptomilk.org                [hidden email]

[Andrew Bartlett]

On Thu, 2012-07-12 at 16:59 +0200, Andreas Schneider wrote:

> On Wednesday 27 June 2012 10:08:02 Michael Adam wrote:
> > - Log -----------------------------------------------------------------
> > commit c4be17f804a857630b4c5f9d0aad70b508e56e2e
> > Author: Gregor Beck <[hidden email]>
> > Date:   Thu Jun 7 13:34:35 2012 +0200
> >
> >     s3: add a tool "cclean" to cleanup orphaned entries from connections.tdb
> >
> >     Signed-off-by: Michael Adam <[hidden email]>
> >
>
> Hi,
>
> I don't see a manpage for that tool. Please provide one.

BTW, Do we really want more stand-alone utilities?  One of the original
ideas of 'net' was to collect all the small tools into one tool.
(samba-tool has similar aims).

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

[Gregor Beck-3]

Hi Andrew,

On Friday 13 July 2012 00:55:23 you wrote:
> BTW, Do we really want more stand-alone utilities?  One of the original
> ideas of 'net' was to collect all the small tools into one tool.
The tool arose on custumer request for a small tool which can easily be copied
to a running system to be fixed.
I should be easy to make it a net command on demand.

Gregor

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
  ☎ [phone], ℻ [phone]
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

[Jelmer Vernooij]

On Fri, Jul 13, 2012 at 11:33:01AM +0200, Gregor Beck wrote:
> Hi Andrew,
>
> On Friday 13 July 2012 00:55:23 you wrote:
> > BTW, Do we really want more stand-alone utilities?  One of the original
> > ideas of 'net' was to collect all the small tools into one tool.
> The tool arose on custumer request for a small tool which can easily be copied
> to a running system to be fixed.
> I should be easy to make it a net command on demand.
+1 on putting it inside of another binary rather than adding a new
one.

Wouldn't this be more appropriate as a part of tdbtool rather than
net though?

Cheers,

Jelmer

[Michael Adam-3]

Jelmer Vernooij wrote:

> On Fri, Jul 13, 2012 at 11:33:01AM +0200, Gregor Beck wrote:
> > Hi Andrew,
> >
> > On Friday 13 July 2012 00:55:23 you wrote:
> > > BTW, Do we really want more stand-alone utilities?  One of the original
> > > ideas of 'net' was to collect all the small tools into one tool.
> > The tool arose on custumer request for a small tool which can easily be copied
> > to a running system to be fixed.
> > I should be easy to make it a net command on demand.
> >
> +1 on putting it inside of another binary rather than adding a new
> one.

One thing to keep in mind is that one purpose was to have
a minimal tool that you can copy to other hosts, also running
older versions of samba to clean up there. You have to be much
more careful when copying the net tool! To be safe, you'd have
to copy it under a different name at last. That was why we
originally did not integrate it into net.

> Wouldn't this be more appropriate as a part of tdbtool rather than
> net though?

No, this is a high-level clean tool.
The contents of the connections records is unmarshalled and
validated...

Cheers - Michael

[Volker Lendecke]

On Fri, Jul 13, 2012 at 12:10:56PM +0200, Michael Adam wrote:
> > Wouldn't this be more appropriate as a part of tdbtool rather than
> > net though?
>
> No, this is a high-level clean tool.
> The contents of the connections records is unmarshalled and
> validated...

I would propose to remove it completely. It is a special
tool for a customer of ours and will hopefully not be needed
upstream. If we can not agree on the right place, /dev/null
might be the one.

With best regards,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: [phone], fax: [phone]
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

[Andrew Bartlett]

On Fri, 2012-07-13 at 12:10 +0200, Michael Adam wrote:

> Jelmer Vernooij wrote:
> > On Fri, Jul 13, 2012 at 11:33:01AM +0200, Gregor Beck wrote:
> > > Hi Andrew,
> > >
> > > On Friday 13 July 2012 00:55:23 you wrote:
> > > > BTW, Do we really want more stand-alone utilities?  One of the original
> > > > ideas of 'net' was to collect all the small tools into one tool.
> > > The tool arose on custumer request for a small tool which can easily be copied
> > > to a running system to be fixed.
> > > I should be easy to make it a net command on demand.
> > >
> > +1 on putting it inside of another binary rather than adding a new
> > one.
>
> One thing to keep in mind is that one purpose was to have
> a minimal tool that you can copy to other hosts, also running
> older versions of samba to clean up there. You have to be much
> more careful when copying the net tool! To be safe, you'd have
> to copy it under a different name at last. That was why we
> originally did not integrate it into net.

Under waf, would building it static using the --nonshared-binary=net
configure option help with that?

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

[Karolin Seeger-2]

Hi Gregor,

On Fr, Jul 13, 2012 at 11:33:01 +0200, Gregor Beck wrote:
> On Friday 13 July 2012 00:55:23 you wrote:
> > BTW, Do we really want more stand-alone utilities?  One of the original
> > ideas of 'net' was to collect all the small tools into one tool.
> The tool arose on custumer request for a small tool which can easily be copied
> to a running system to be fixed.
> I should be easy to make it a net command on demand.

anyway, please add documentation. It is mandatory for a stable release.

Thanks!

Cheers,
Karo

--
Samba http://www.samba.org
SerNet http://www.sernet.de
sambaXP http://www.sambaxp.org

[Gregor Beck-3]

Hi,

find attached patches to
1. remove the cclean tool
2. optionally bring it back as "net connections cleanup"
3. and this time with a fancy manual entry

Cheers,
Gregor

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
  ☎ [phone], ℻ [phone]
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

[Andrew Bartlett]

On Mon, 2012-07-16 at 15:39 +0200, Gregor Beck wrote:
> Hi,
>
> find attached patches to
> 1. remove the cclean tool
> 2. optionally bring it back as "net connections cleanup"
> 3. and this time with a fancy manual entry

I pushed this to master yesterday.

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org