build broke since pam_wrapper move to third_party

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

build broke since pam_wrapper move to third_party

Samba - samba-technical mailing list
Hi,

I have a system not building master since

commit 8635465d77496e882ca73477690bbd20d877a197
Author: Andreas Schneider <[hidden email]>
Date:   Fri Nov 24 13:34:25 2017 +0100

    build: Move pam_wrapper to third_party


./configure.developer prints:

    Checking for system pam_wrapper (>=1.0.4)  : not found

But doesn't fail otherwise. When I compile I get:

    ci@knout:~/workspace/samba-ci> ./buildtools/bin/waf build -vv
    Waf: Entering directory `/home/ci/workspace/samba-ci/bin'
            Selected embedded Heimdal build
    [2111/4119] Compiling third_party/pam_wrapper/python/pypamtest.c
    19:00:30 runner /usr/bin/gcc -DPY_SSIZE_T_CLEAN=1 -DDEVELOPER -DDEBUG_PASSWORD -fPIC -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -fstack-protector -g -Wall -Wshadow -Wmissing-prototypes -Wcast-align -Wcast-qual -fno-common -Werror=address -Werror=strict-prototypes -Wstrict-prototypes -Werror=write-strings -Wwrite-strings -Werror-implicit-function-declaration -Werror=pointer-arith -Wpointer-arith -Werror=declaration-after-statement -Wdeclaration-after-statement -Werror=return-type -Wreturn-type -Werror=uninitialized -Wuninitialized -Wformat=2 -Wno-format-y2k -Wno-format-zero-length -Werror=format-security -Wformat-security -Werror=format -DSTATIC_pypamtest_MODULES=NULL -DSTATIC_pypamtest_MODULES_PROTO=extern void __pypamtest_dummy_module_proto(void) -MD -fno-strict-aliasing -Idefault/lib/pam_wrapper -I../lib/pam_wrapper -Idefault/include/public -I../include/public -Idefault/source4 -I../source4 -Idefault/lib -I../lib -Idefault/source4/lib -I../source4/lib -Idefault/source4/include -I../source4/include -Idefault/include -I../include -Idefault/lib/replace -I../lib/replace -Idefault -I.. -I/usr/local/include -I/usr/include/python2.7 -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1 -D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 ../third_party/pam_wrapper/python/pypamtest.c -c -o default/third_party/pam_wrapper/python/pypamtest_3.o
    ../third_party/pam_wrapper/python/pypamtest.c:22:24: fatal error: libpamtest.h: No such file or directory
     #include "libpamtest.h"
                            ^
    compilation terminated.
    Waf: Leaving directory `/home/ci/workspace/samba-ci/bin'
    Build failed:  -> task failed (err #1):
            {task: cc pypamtest.c -> pypamtest_3.o}
      File "./buildtools/bin/waf", line 76, in <module>
            Scripting.prepare(t, cwd, VERSION, wafdir)
      File "/home/ci/workspace/samba-ci/third_party/waf/wafadmin/Scripting.py", line 147, in prepare
            error(str(e))


It works if I add "-I../third_party/pam_wrapper" and run it manually.

Cheers,

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

Reply | Threaded
Open this post in threaded view
|

Re: build broke since pam_wrapper move to third_party

Samba - samba-technical mailing list
On Monday, 27 November 2017 19:08:11 CET Aurélien Aptel wrote:

> Hi,
>
> I have a system not building master since
>
> commit 8635465d77496e882ca73477690bbd20d877a197
> Author: Andreas Schneider <[hidden email]>
> Date:   Fri Nov 24 13:34:25 2017 +0100
>
>     build: Move pam_wrapper to third_party
>
>
> ./configure.developer prints:
>
>     Checking for system pam_wrapper (>=1.0.4)  : not found
>
> But doesn't fail otherwise. When I compile I get:
>
>     ci@knout:~/workspace/samba-ci> ./buildtools/bin/waf build -vv
>     Waf: Entering directory `/home/ci/workspace/samba-ci/bin'
>             Selected embedded Heimdal build
>     [2111/4119] Compiling third_party/pam_wrapper/python/pypamtest.c
>     19:00:30 runner /usr/bin/gcc -DPY_SSIZE_T_CLEAN=1 -DDEVELOPER
> -DDEBUG_PASSWORD -fPIC -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS
> -fstack-protector -g -Wall -Wshadow -Wmissing-prototypes -Wcast-align
> -Wcast-qual -fno-common -Werror=address -Werror=strict-prototypes
> -Wstrict-prototypes -Werror=write-strings -Wwrite-strings
> -Werror-implicit-function-declaration -Werror=pointer-arith -Wpointer-arith
> -Werror=declaration-after-statement -Wdeclaration-after-statement
> -Werror=return-type -Wreturn-type -Werror=uninitialized -Wuninitialized
> -Wformat=2 -Wno-format-y2k -Wno-format-zero-length -Werror=format-security
> -Wformat-security -Werror=format -DSTATIC_pypamtest_MODULES=NULL
> -DSTATIC_pypamtest_MODULES_PROTO=extern void
> __pypamtest_dummy_module_proto(void) -MD -fno-strict-aliasing
> -Idefault/lib/pam_wrapper -I../lib/pam_wrapper -Idefault/include/public
> -I../include/public -Idefault/source4 -I../source4 -Idefault/lib -I../lib
> -Idefault/source4/lib -I../source4/lib -Idefault/source4/include
> -I../source4/include -Idefault/include -I../include -Idefault/lib/replace
> -I../lib/replace -Idefault -I.. -I/usr/local/include
> -I/usr/include/python2.7 -D_SAMBA_BUILD_=4 -DHAVE_CONFIG_H=1
> -D_GNU_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1
> ../third_party/pam_wrapper/python/pypamtest.c -c -o
> default/third_party/pam_wrapper/python/pypamtest_3.o
> ../third_party/pam_wrapper/python/pypamtest.c:22:24: fatal error:
> libpamtest.h: No such file or directory #include "libpamtest.h"
>                             ^
>     compilation terminated.
>     Waf: Leaving directory `/home/ci/workspace/samba-ci/bin'
>     Build failed:  -> task failed (err #1):
>             {task: cc pypamtest.c -> pypamtest_3.o}
>       File "./buildtools/bin/waf", line 76, in <module>
>             Scripting.prepare(t, cwd, VERSION, wafdir)
>       File
> "/home/ci/workspace/samba-ci/third_party/waf/wafadmin/Scripting.py", line
> 147, in prepare error(str(e))
>
>
> It works if I add "-I../third_party/pam_wrapper" and run it manually.
>
> Cheers,
I think you need to rerun configure. However attached is a patch to make waf
happy.


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

0001-pwrap-Build-libpamtest-as-a-subsystem-to-avoid-issue.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: build broke since pam_wrapper move to third_party

Samba - samba-technical mailing list
Andreas Schneider <[hidden email]> writes:
> I think you need to rerun configure. However attached is a patch to make waf
> happy.

As I've said configure runs without failing. I've also tried make clean,
git clean -xf, ... but still failing. The patch you attached made it
work though, thanks!

Cheers,

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

Reply | Threaded
Open this post in threaded view
|

Re: build broke since pam_wrapper move to third_party

Samba - samba-technical mailing list
On Mon, 2017-11-27 at 20:25 +0100, Aurélien Aptel via samba-technical
wrote:
> Andreas Schneider <[hidden email]> writes:
> > I think you need to rerun configure. However attached is a patch to make waf
> > happy.
>
> As I've said configure runs without failing. I've also tried make clean,
> git clean -xf, ... but still failing. The patch you attached made it
> work though, thanks!

Is pam_wrapper installed on sn-devel?  That might explain why this is
different there.

Andrew Bartlett

--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba