SMB2/3 progress (master3-reauth)

[Stefan (metze) Metzmacher]

Hi,

I've almost finished fixing up our master3-reauth branch
which contains the change to smbXsrv_session* and smbXsrv_tcon*

See https://wiki.samba.org/index.php/Samba3/SMB2

There're still some minor things to do
and I'll do some more testing and reviewing this week.

But I think it's likely that I'd be happy to push this to master
later this week.

https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-reauth
This branch implements re-authentication, handling of the previous
session id
and SMB 2.24/3.00 signing. It also changes the default for "server max
protocol" to
SMB3 (SMB3_00).

Comments please.

metze

BTW: the smbXsrv_open stuff and the durable handle work can be found in
https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-durable
which will be hopefully ready for master in the following weeks.

[Andrew Bartlett]

On Mon, 2012-06-11 at 20:31 +0200, Stefan (metze) Metzmacher wrote:

> Hi,
>
> I've almost finished fixing up our master3-reauth branch
> which contains the change to smbXsrv_session* and smbXsrv_tcon*
>
> See https://wiki.samba.org/index.php/Samba3/SMB2
>
> There're still some minor things to do
> and I'll do some more testing and reviewing this week.
>
> But I think it's likely that I'd be happy to push this to master
> later this week.
>
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-reauth
> This branch implements re-authentication, handling of the previous
> session id
> and SMB 2.24/3.00 signing. It also changes the default for "server max
> protocol" to
> SMB3 (SMB3_00).
>
> Comments please.

There is certainly some impressive work in there.  Thinking of the
future, with changes like this:

s3:smb2_sesssetup: make use of gensec_update_send/recv
https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=10b43b1b3f31658eacf9bb8b3f19509e2163d957

It would be worthwhile thinking about doing the same up the auth stack
for NTLMSSP -> ntlm.  The key would be to use an async method to talk to
winbindd, like (but probably not exactly) irpc.  

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

[Stefan (metze) Metzmacher]

Am 20.06.2012 04:12, schrieb Andrew Bartlett:

> On Mon, 2012-06-11 at 20:31 +0200, Stefan (metze) Metzmacher wrote:
>> Hi,
>>
>> I've almost finished fixing up our master3-reauth branch
>> which contains the change to smbXsrv_session* and smbXsrv_tcon*
>>
>> See https://wiki.samba.org/index.php/Samba3/SMB2
>>
>> There're still some minor things to do
>> and I'll do some more testing and reviewing this week.
>>
>> But I think it's likely that I'd be happy to push this to master
>> later this week.
>>
>> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-reauth
>> This branch implements re-authentication, handling of the previous
>> session id
>> and SMB 2.24/3.00 signing. It also changes the default for "server max
>> protocol" to
>> SMB3 (SMB3_00).
>>
>> Comments please.
>
> There is certainly some impressive work in there.  Thinking of the
> future, with changes like this:
>
> s3:smb2_sesssetup: make use of gensec_update_send/recv
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=10b43b1b3f31658eacf9bb8b3f19509e2163d957
>
> It would be worthwhile thinking about doing the same up the auth stack
> for NTLMSSP -> ntlm.  The key would be to use an async method to talk to
> winbindd, like (but probably not exactly) irpc.  

Sounds good, but first we need to change the smb1 session setup and the
rpc server
to also use gensec_update_send/recv()

metze

[Stefan (metze) Metzmacher]

Hi,

> I've almost finished fixing up our master3-reauth branch
> which contains the change to smbXsrv_session* and smbXsrv_tcon*
>
> See https://wiki.samba.org/index.php/Samba3/SMB2
>
> There're still some minor things to do
> and I'll do some more testing and reviewing this week.
>
> But I think it's likely that I'd be happy to push this to master
> later this week.
>
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-reauth
> This branch implements re-authentication, handling of the previous
> session id
> and SMB 2.24/3.00 signing.

I'm quite happy with the master3-reauth branch, I plan to push it over
the weekend
or early next week.

> It also changes the default for "server max
> protocol" to
> SMB3 (SMB3_00).

I've skipped this for now, we better go through the docs to see what is
still missing
and required...

But make test uses SMB3 now.

> Comments please.
>
> metze
>
> BTW: the smbXsrv_open stuff and the durable handle work can be found in
> https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-durable
> which will be hopefully ready for master in the following weeks.

The next step will be this branch
https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-smbXsrv_open

This has the rest of the recent work is located here:
(work in progress)
https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-durable
(stable)
https://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-testing

metze