Quantcast

Removing SMB_VFS_STRICT_UNLOCK() ?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Removing SMB_VFS_STRICT_UNLOCK() ?

Samba - samba-technical mailing list
Hi!

What abot removing SMB_VFS_STRICT_UNLOCK()? The only VFS that implements it is
vfs_default and it's a noop there.

Afaict it makes no sense anyway as per the strict locking specification (and
MS-FSA), SMB_VFS_STRICT_LOCK() only checks locks, it doesn't set any.

Thoughts?

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Removing SMB_VFS_STRICT_UNLOCK() ?

Samba - samba-technical mailing list
On Thu, Mar 16, 2017 at 08:56:46AM +0100, Ralph Böhme via samba-technical wrote:
> Hi!
>
> What abot removing SMB_VFS_STRICT_UNLOCK()? The only VFS that implements it is
> vfs_default and it's a noop there.
>
> Afaict it makes no sense anyway as per the strict locking specification (and
> MS-FSA), SMB_VFS_STRICT_LOCK() only checks locks, it doesn't set any.
>
> Thoughts?

Think it might have been added as an Isilon-specific thing.

Happy to lose this for 4.7, but only if you change the name
of SMB_VFS_STRICT_LOCK() to SMB_VFS_STRICT_LOCK_CHECK()
also, so it's obvious what it really does :-).

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Removing SMB_VFS_STRICT_UNLOCK() ?

Samba - samba-technical mailing list

On Thu, Mar 16, 2017 at 11:48:22AM -0700, Jeremy Allison wrote:

> On Thu, Mar 16, 2017 at 08:56:46AM +0100, Ralph Böhme via samba-technical wrote:
> > Hi!
> >
> > What abot removing SMB_VFS_STRICT_UNLOCK()? The only VFS that implements it is
> > vfs_default and it's a noop there.
> >
> > Afaict it makes no sense anyway as per the strict locking specification (and
> > MS-FSA), SMB_VFS_STRICT_LOCK() only checks locks, it doesn't set any.
> >
> > Thoughts?
>
> Think it might have been added as an Isilon-specific thing.
>
> Happy to lose this for 4.7, but only if you change the name
> of SMB_VFS_STRICT_LOCK() to SMB_VFS_STRICT_LOCK_CHECK()
> also, so it's obvious what it really does :-).

sounds like a plan. :)

Cheerio!
-slow

Loading...