Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba apis-for-logging-and-configuration
https://github.com/samba-team/samba/pull/99

Added libsmbclient APIs for setting configuration file
and Set callback function which is called to log
Samba logs

Signed-off-by: Puran Chand <[hidden email]>

A patch file from https://github.com/samba-team/samba/pull/99.patch is attached

github-pr-apis-for-logging-and-configuration-99.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba apis-for-logging-and-configuration
https://github.com/samba-team/samba/pull/99

Added libsmbclient APIs for setting configuration file
and Set callback function which is called to log
Samba logs

Signed-off-by: Puran Chand <[hidden email]>

A patch file from https://github.com/samba-team/samba/pull/99.patch is attached

github-pr-apis-for-logging-and-configuration-99.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba apis-for-logging-and-configuration
https://github.com/samba-team/samba/pull/99

Added libsmbclient APIs for setting configuration file
and Set callback function which is called to log
Samba logs

Signed-off-by: Puran Chand <[hidden email]>

A patch file from https://github.com/samba-team/samba/pull/99.patch is attached

github-pr-apis-for-logging-and-configuration-99.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba apis-for-logging-and-configuration
https://github.com/samba-team/samba/pull/99

Added libsmbclient APIs for setting configuration file
and Set callback function which is called to log
Samba logs

Signed-off-by: Puran Chand <[hidden email]>

A patch file from https://github.com/samba-team/samba/pull/99.patch is attached

github-pr-apis-for-logging-and-configuration-99.patch (21K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
Review appreciated

- Puran

On Fri, Nov 24, 2017 at 9:52 AM, Github bot account via samba-technical <
[hidden email]> wrote:

> There is an updated pull request by puran157 against master on the Samba
> Samba Github repository
>
> https://github.com/puran157/samba apis-for-logging-and-configuration
> https://github.com/samba-team/samba/pull/99
>
> Added libsmbclient APIs for setting configuration file
> and Set callback function which is called to log
> Samba logs
>
> Signed-off-by: Puran Chand <[hidden email]>
>
> A patch file from https://github.com/samba-team/samba/pull/99.patch is
> attached
>
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
On Mon, Nov 27, 2017 at 12:40:23PM +0530, Puran Chand via samba-technical wrote:
> Review appreciated

Can you turn that into two patches, one for each topic?

Also, I don't understand the second patch? Why did you not name the
ABI file correct in the first patch?

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
The PR was raised long back and that time the ABI file was at 0.2.4
version. But recently there was a conflict with master since ABI file was
updated to 3.0.0.

I will work on making it 2 separate patches.

Thanks

On Tue, Nov 28, 2017 at 5:29 PM, Volker Lendecke <[hidden email]>
wrote:

> On Mon, Nov 27, 2017 at 12:40:23PM +0530, Puran Chand via samba-technical
> wrote:
> > Review appreciated
>
> Can you turn that into two patches, one for each topic?
>
> Also, I don't understand the second patch? Why did you not name the
> ABI file correct in the first patch?
>
> Volker
>
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:[hidden email]
>
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
The second patch exposes an API which can be used to set logging callback
function.
Any code which is using the library as shared object can route the logs
from library to its own log file for later analysis.

On Wed, Nov 29, 2017 at 1:04 PM, Puran Chand <[hidden email]> wrote:

> The PR was raised long back and that time the ABI file was at 0.2.4
> version. But recently there was a conflict with master since ABI file was
> updated to 3.0.0.
>
> I will work on making it 2 separate patches.
>
> Thanks
>
> On Tue, Nov 28, 2017 at 5:29 PM, Volker Lendecke <
> [hidden email]> wrote:
>
>> On Mon, Nov 27, 2017 at 12:40:23PM +0530, Puran Chand via samba-technical
>> wrote:
>> > Review appreciated
>>
>> Can you turn that into two patches, one for each topic?
>>
>> Also, I don't understand the second patch? Why did you not name the
>> ABI file correct in the first patch?
>>
>> Volker
>>
>> --
>> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
>> phone: +49-551-370000-0, fax: +49-551-370000-9
>> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
>> http://www.sernet.de, mailto:[hidden email]
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Samba - samba-technical mailing list
Separated this in 2 separate patches and closed this.
https://github.com/samba-team/samba/pull/113
https://github.com/samba-team/samba/pull/112

- Puran

On Wed, Nov 29, 2017 at 1:17 PM, Puran Chand <[hidden email]> wrote:

> The second patch exposes an API which can be used to set logging callback
> function.
> Any code which is using the library as shared object can route the logs
> from library to its own log file for later analysis.
>
> On Wed, Nov 29, 2017 at 1:04 PM, Puran Chand <[hidden email]> wrote:
>
>> The PR was raised long back and that time the ABI file was at 0.2.4
>> version. But recently there was a conflict with master since ABI file was
>> updated to 3.0.0.
>>
>> I will work on making it 2 separate patches.
>>
>> Thanks
>>
>> On Tue, Nov 28, 2017 at 5:29 PM, Volker Lendecke <
>> [hidden email]> wrote:
>>
>>> On Mon, Nov 27, 2017 at 12:40:23PM +0530, Puran Chand via
>>> samba-technical wrote:
>>> > Review appreciated
>>>
>>> Can you turn that into two patches, one for each topic?
>>>
>>> Also, I don't understand the second patch? Why did you not name the
>>> ABI file correct in the first patch?
>>>
>>> Volker
>>>
>>> --
>>> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
>>> phone: +49-551-370000-0, fax: +49-551-370000-9
>>> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
>>> http://www.sernet.de, mailto:[hidden email]
>>>
>>
>>
>