Re: Fix FreeBSD/Darwin & Linux sendfile.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Fix FreeBSD/Darwin & Linux sendfile.

Samba - samba-technical mailing list
New comment by bjacke on Samba Github repository

https://github.com/samba-team/samba/pull/76#issuecomment-355300069
Comment:
please use max 80 chars/line, see README.Coding. And there is more obvious wrong at two places:
"if(errno != EINTR || errno != EAGAIN || errno != EWOULDBLOCK)" is always true. Can you fix those things and try to explain your code changes so that reviewing is better possible? Finally, please send the patch to the samba-technical mailing list because github is not working well with the samba community for communication and discussion.
Thank you - Björn