Quantcast

RFC: new testparam check

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFC: new testparam check

Samba - samba-technical mailing list
Hi,

Had a situation where a customer had a weird problem, after much head
scratching and debugging it turned out to be a typo in one of the values
in 'name resolve order' causing the problem. Really would have helped
save alot of time if testparam complained especially as the values for
this param should be from a known set of valid values. I'll happily open
a samba bug and update the the patch to reflect that and any other
comments/issues if this is useful. Thoughts ?

Noel


0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On Tuesday, 11 April 2017 12:42:59 CEST Noel Power via samba-technical wrote:
> Hi,
>
> Had a situation where a customer had a weird problem, after much head
> scratching and debugging it turned out to be a typo in one of the values
> in 'name resolve order' causing the problem. Really would have helped
> save alot of time if testparam complained especially as the values for
> this param should be from a known set of valid values. I'll happily open
> a samba bug and update the the patch to reflect that and any other
> comments/issues if this is useful. Thoughts ?

RB+ ;-)

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On 11/04/17 12:08, Andreas Schneider wrote:

> On Tuesday, 11 April 2017 12:42:59 CEST Noel Power via samba-technical wrote:
>> Hi,
>>
>> Had a situation where a customer had a weird problem, after much head
>> scratching and debugging it turned out to be a typo in one of the values
>> in 'name resolve order' causing the problem. Really would have helped
>> save alot of time if testparam complained especially as the values for
>> this param should be from a known set of valid values. I'll happily open
>> a samba bug and update the the patch to reflect that and any other
>> comments/issues if this is useful. Thoughts ?
> RB+ ;-)
>
ok, since at least 1 person thinks it's useful here is a version with a
bug # :->>

Noel


0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On Tue, 11 Apr 2017 12:26:26 +0100, Noel Power via samba-technical wrote:

> On 11/04/17 12:08, Andreas Schneider wrote:
> > On Tuesday, 11 April 2017 12:42:59 CEST Noel Power via samba-technical wrote:  
> >> Hi,
> >>
> >> Had a situation where a customer had a weird problem, after much head
> >> scratching and debugging it turned out to be a typo in one of the values
> >> in 'name resolve order' causing the problem. Really would have helped
> >> save alot of time if testparam complained especially as the values for
> >> this param should be from a known set of valid values. I'll happily open
> >> a samba bug and update the the patch to reflect that and any other
> >> comments/issues if this is useful. Thoughts ?  
> > RB+ ;-)
> >  
> ok, since at least 1 person thinks it's useful here is a version with a
> bug # :->>

Please add a test for this to ./source3/script/tests/test_testparm_s3.sh
Otherwise, this looks good to me too.


Cheers, David

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
Ok done, please see attached

Noel

On 11/04/17 12:37, David Disseldorp wrote:

> On Tue, 11 Apr 2017 12:26:26 +0100, Noel Power via samba-technical wrote:
>
>> On 11/04/17 12:08, Andreas Schneider wrote:
>>> On Tuesday, 11 April 2017 12:42:59 CEST Noel Power via samba-technical wrote:  
>>>> Hi,
>>>>
>>>> Had a situation where a customer had a weird problem, after much head
>>>> scratching and debugging it turned out to be a typo in one of the values
>>>> in 'name resolve order' causing the problem. Really would have helped
>>>> save alot of time if testparam complained especially as the values for
>>>> this param should be from a known set of valid values. I'll happily open
>>>> a samba bug and update the the patch to reflect that and any other
>>>> comments/issues if this is useful. Thoughts ?  
>>> RB+ ;-)
>>>  
>> ok, since at least 1 person thinks it's useful here is a version with a
>> bug # :->>
> Please add a test for this to ./source3/script/tests/test_testparm_s3.sh
> Otherwise, this looks good to me too.
>
>
> Cheers, David


0002-s3-script-tests-Test-for-illegal-value-detection-for.patch (1K) Download Attachment
0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
You left out '=' after 'name resolve order' in the first quoted string
in these lines.

On 4/11/2017 9:42 AM, Noel Power via samba-technical wrote:

> +testit_expect_failure "name resolve order bad wins host bcast"\
> + test_one_global_option "name resolve order = bad wins host bcast" || \
> + failed=`expr ${failed} + 1`
> +
> +testit_expect_failure "name resolve order lmhosts bad host bcast"\
> + test_one_global_option "name resolve order = lmhosts bad host bcast" || \
> + failed=`expr ${failed} + 1`
> +
> +testit_expect_failure "name resolve order lmhosts wins bad bcast"\
> + test_one_global_option "name resolve order = lmhosts wins bad bcast" || \
> + failed=`expr ${failed} + 1`
> +
> +testit_expect_failure "name resolve order lmhosts wins host bad"\
> + test_one_global_option "name resolve order = lmhosts wins host bad" || \
> + failed=`expr ${failed} + 1`


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On 11/04/17 14:55, jim via samba-technical wrote:
> You left out '=' after 'name resolve order' in the first quoted string
> in these lines.
It's just the test name, it doesn't need to have a '='


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
Thanks Noel - The tests look good.
A couple of minor things I missed on the previous pass...
Feel free to add my reviewed-by tag to both patches after fixing.

On Tue, 11 Apr 2017 14:42:00 +0100, Noel Power via samba-technical wrote:

> diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
> index cedf8facb8d..f5f27990875 100644
> --- a/lib/param/loadparm.c
> +++ b/lib/param/loadparm.c
...

> +bool handle_name_resolve_order(struct loadparm_context *lp_ctx,
> +       struct loadparm_service *service,
> +       const char *pszParmValue, char **ptr)
> +{
> + const char **valid_values =
> + str_list_make_v3_const(NULL,
> +       DEFAULT_NAME_RESOLVE_ORDER,
> +       NULL);
> + const char **values_to_set =
> + str_list_make_v3_const(lp_ctx->globals->ctx,
> +       pszParmValue,
> +       NULL);

Please check for str_list_make_v3_const() allocation failures here.

...

> diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
> index 57220a64282..ccd37b1cc5e 100644
> --- a/source3/param/loadparm.c
> +++ b/source3/param/loadparm.c
> @@ -609,7 +609,10 @@ static void init_globals(struct loadparm_context *lp_ctx, bool reinit_globals)
>   lpcfg_string_set(Globals.ctx, &Globals.logon_path,
>   "\\\\%N\\%U\\profile");
>  
> - Globals.name_resolve_order = str_list_make_v3_const(NULL, "lmhosts wins host bcast", NULL);
> + Globals.name_resolve_order =
> + str_list_make_v3_const(NULL,
> +       DEFAULT_NAME_RESOLVE_ORDER,
> +       NULL);

This should use Globals.ctx as the talloc_ctx.

>   lpcfg_string_set(Globals.ctx, &Globals.password_server, "*");
>  
>   Globals.algorithmic_rid_base = BASE_RID;

Cheers, David

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
Hi Dave
See attached, please check if you are happy (and I added yours an
Andreas RB) Other than your changes I added the missing '=' to the test
names for completeness as I was making changes

Noel
On 11/04/17 16:54, David Disseldorp via samba-technical wrote:

> Thanks Noel - The tests look good.
> A couple of minor things I missed on the previous pass...
> Feel free to add my reviewed-by tag to both patches after fixing.
>
> On Tue, 11 Apr 2017 14:42:00 +0100, Noel Power via samba-technical wrote:
>
>> diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
>> index cedf8facb8d..f5f27990875 100644
>> --- a/lib/param/loadparm.c
>> +++ b/lib/param/loadparm.c
> ...
>> +bool handle_name_resolve_order(struct loadparm_context *lp_ctx,
>> +       struct loadparm_service *service,
>> +       const char *pszParmValue, char **ptr)
>> +{
>> + const char **valid_values =
>> + str_list_make_v3_const(NULL,
>> +       DEFAULT_NAME_RESOLVE_ORDER,
>> +       NULL);
>> + const char **values_to_set =
>> + str_list_make_v3_const(lp_ctx->globals->ctx,
>> +       pszParmValue,
>> +       NULL);
> Please check for str_list_make_v3_const() allocation failures here.
>
> ...
>> diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
>> index 57220a64282..ccd37b1cc5e 100644
>> --- a/source3/param/loadparm.c
>> +++ b/source3/param/loadparm.c
>> @@ -609,7 +609,10 @@ static void init_globals(struct loadparm_context *lp_ctx, bool reinit_globals)
>>   lpcfg_string_set(Globals.ctx, &Globals.logon_path,
>>   "\\\\%N\\%U\\profile");
>>  
>> - Globals.name_resolve_order = str_list_make_v3_const(NULL, "lmhosts wins host bcast", NULL);
>> + Globals.name_resolve_order =
>> + str_list_make_v3_const(NULL,
>> +       DEFAULT_NAME_RESOLVE_ORDER,
>> +       NULL);
> This should use Globals.ctx as the talloc_ctx.
>
>>   lpcfg_string_set(Globals.ctx, &Globals.password_server, "*");
>>  
>>   Globals.algorithmic_rid_base = BASE_RID;
> Cheers, David
>


0002-s3-script-tests-Test-for-illegal-value-detection-for.patch (1K) Download Attachment
0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On Tue, 11 Apr 2017 17:33:19 +0100, Noel Power via samba-technical wrote:

> + valid_values = str_list_make_v3_const(NULL,
> +      DEFAULT_NAME_RESOLVE_ORDER,
> +      NULL);
> + if (!valid_values) {
> + DBG_ERR("OOM: failed to make string list from %s\n",
> + DEFAULT_NAME_RESOLVE_ORDER);
> + return false;
> + }
> + values_to_set = str_list_make_v3_const(lp_ctx->globals->ctx,
> +       pszParmValue,
> +       NULL);
> + if (!values_to_set) {
> + DBG_ERR("OOM: failed to make string list from %s\n",
> + pszParmValue);

valid_values should be freed on failure here.

Might as well also change the "if (!X)" pointer checks to
"if (X == NULL)".

> + return false;
> + }

Cheers, Davi

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On 11/04/17 17:53, David Disseldorp via samba-technical wrote:

> On Tue, 11 Apr 2017 17:33:19 +0100, Noel Power via samba-technical wrote:
>
>> + valid_values = str_list_make_v3_const(NULL,
>> +      DEFAULT_NAME_RESOLVE_ORDER,
>> +      NULL);
>> + if (!valid_values) {
>> + DBG_ERR("OOM: failed to make string list from %s\n",
>> + DEFAULT_NAME_RESOLVE_ORDER);
>> + return false;
>> + }
>> + values_to_set = str_list_make_v3_const(lp_ctx->globals->ctx,
>> +       pszParmValue,
>> +       NULL);
>> + if (!values_to_set) {
>> + DBG_ERR("OOM: failed to make string list from %s\n",
>> + pszParmValue);
> valid_values should be freed on failure here.
/me face palms,
knew it was a bad idea to do this while running out the door, I'll post
an updated patch later on this morning

Noel

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
Dave
please see attached :-)


On 12/04/17 08:38, Noel Power via samba-technical wrote:

> On 11/04/17 17:53, David Disseldorp via samba-technical wrote:
>> On Tue, 11 Apr 2017 17:33:19 +0100, Noel Power via samba-technical wrote:
>>
>>> + valid_values = str_list_make_v3_const(NULL,
>>> +      DEFAULT_NAME_RESOLVE_ORDER,
>>> +      NULL);
>>> + if (!valid_values) {
>>> + DBG_ERR("OOM: failed to make string list from %s\n",
>>> + DEFAULT_NAME_RESOLVE_ORDER);
>>> + return false;
>>> + }
>>> + values_to_set = str_list_make_v3_const(lp_ctx->globals->ctx,
>>> +       pszParmValue,
>>> +       NULL);
>>> + if (!values_to_set) {
>>> + DBG_ERR("OOM: failed to make string list from %s\n",
>>> + pszParmValue);
>> valid_values should be freed on failure here.
> /me face palms,
> knew it was a bad idea to do this while running out the door, I'll post
> an updated patch later on this morning
>
> Noel
>
>


0002-s3-script-tests-Test-for-illegal-value-detection-for.patch (1K) Download Attachment
0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On Wed, 12 Apr 2017 10:04:43 +0100, Noel Power via samba-technical wrote:

> Dave
> please see attached :-)

Looks good. @Andreas, please push if you're happy.

Cheers, David

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On Wednesday, 12 April 2017 11:58:54 CEST David Disseldorp via samba-technical
wrote:
> On Wed, 12 Apr 2017 10:04:43 +0100, Noel Power via samba-technical wrote:
> > Dave
> > please see attached :-)
>
> Looks good. @Andreas, please push if you're happy.

pushed :-)

Thanks for the patch!

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wednesday, 12 April 2017 11:58:54 CEST David Disseldorp wrote:
> On Wed, 12 Apr 2017 10:04:43 +0100, Noel Power via samba-technical wrote:
> > Dave
> > please see attached :-)
>
> Looks good. @Andreas, please push if you're happy.
>
> Cheers, David

[2(6)/2092 at 0s] samba.tests.docs
UNEXPECTED(failure):
samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s3(none)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
166, in test_default_s3
    'rpc server dynamic port range'])
  File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
344, in _set_arbitrary
    "Parameters that were unexpectedly not set:"))
AssertionError: Parameters that were unexpectedly not set:

    name resolve order
      Expected: a b c
      Got:


The documentation test needs to be adapted. This is a special variable now. It
should probably be ignored.


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On 12/04/17 16:46, Andreas Schneider via samba-technical wrote:

> On Wednesday, 12 April 2017 11:58:54 CEST David Disseldorp wrote:
>> On Wed, 12 Apr 2017 10:04:43 +0100, Noel Power via samba-technical wrote:
>>> Dave
>>> please see attached :-)
>> Looks good. @Andreas, please push if you're happy.
>>
>> Cheers, David
> [2(6)/2092 at 0s] samba.tests.docs
> UNEXPECTED(failure):
> samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s3(none)
> REASON: Exception: Exception: Traceback (most recent call last):
>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
> 166, in test_default_s3
>     'rpc server dynamic port range'])
>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
> 344, in _set_arbitrary
>     "Parameters that were unexpectedly not set:"))
> AssertionError: Parameters that were unexpectedly not set:
>
>     name resolve order
>       Expected: a b c
>       Got:
>
>
> The documentation test needs to be adapted. This is a special variable now. It
> should probably be ignored.
>
>
> Andreas
>
I will look into this


Noel


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list

On 12/04/17 16:59, Noel Power via samba-technical wrote:
> On 12/04/17 16:46, Andreas Schneider via samba-technical wrote:
[...]

>> [2(6)/2092 at 0s] samba.tests.docs
>> UNEXPECTED(failure):
>> samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s3(none)
>> REASON: Exception: Exception: Traceback (most recent call last):
>>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
>> 166, in test_default_s3
>>     'rpc server dynamic port range'])
>>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py", line
>> 344, in _set_arbitrary
>>     "Parameters that were unexpectedly not set:"))
>> AssertionError: Parameters that were unexpectedly not set:
>>
>>     name resolve order
>>       Expected: a b c
>>       Got:
>>
>>
>> The documentation test needs to be adapted. This is a special variable now. It
>> should probably be ignored.
>>
>>
>> Andreas
>>
> I will look into this
>
>
> Noel

ok patch 0003 adapts the doc test, if you are happy I suppose I should
squash it with the existing test patch (0002-xxx) ?

Noel

0003-python-samba-tests-make-name-resolve-order-and-excep.patch (1K) Download Attachment
0002-s3-script-tests-Test-for-illegal-value-detection-for.patch (1K) Download Attachment
0001-Check-for-valid-values-for-global-conf-name-resolve-.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
Thanks for the quick follow up, Noel. One question...

On Wed, 12 Apr 2017 20:32:52 +0100, Noel Power wrote:

> Testing 'name resolve order' with 'aribrary' values fails (because now
> we check the validity of the values) so we need to add this param to
> the list of exceptions when testing
>
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12739
> Signed-off-by: Noel Power <[hidden email]>
> ---
>  python/samba/tests/docs.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/python/samba/tests/docs.py b/python/samba/tests/docs.py
> index 65df573a350..202619a913e 100644
> --- a/python/samba/tests/docs.py
> +++ b/python/samba/tests/docs.py
> @@ -163,7 +163,8 @@ class SmbDotConfTests(TestCase):
>                            'client plaintext auth',
>                            'registry shares',
>                            'smb ports',
> -                          'rpc server dynamic port range'])
> +                          'rpc server dynamic port range',
> +                          'name resolve order'])
>          self._test_empty(['bin/testparm'])
>  
>      def test_default_s4(self):
> @@ -171,7 +172,8 @@ class SmbDotConfTests(TestCase):
>          self._set_defaults(['bin/samba-tool', 'testparm'])
>          self._set_arbitrary(['bin/samba-tool', 'testparm'],
>              exceptions = ['smb ports',
> -                          'rpc server dynamic port range'])
> +                          'rpc server dynamic port range',
> +                          'name resolve order'])
>          self._test_empty(['bin/samba-tool', 'testparm'])

Is the 'samba-tool testparm' exception necessary? I would have expected
this to be source3 testparm only.

Squashing this into the 0002 does make sense.

Cheers, David

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
On 12/04/17 23:30, David Disseldorp via samba-technical wrote:

> Thanks for the quick follow up, Noel. One question...
>
> On Wed, 12 Apr 2017 20:32:52 +0100, Noel Power wrote:
>
>> Testing 'name resolve order' with 'aribrary' values fails (because now
>> we check the validity of the values) so we need to add this param to
>> the list of exceptions when testing
>>
>> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12739
>> Signed-off-by: Noel Power <[hidden email]>
>> ---
>>  python/samba/tests/docs.py | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/python/samba/tests/docs.py b/python/samba/tests/docs.py
>> index 65df573a350..202619a913e 100644
>> --- a/python/samba/tests/docs.py
>> +++ b/python/samba/tests/docs.py
>> @@ -163,7 +163,8 @@ class SmbDotConfTests(TestCase):
>>                            'client plaintext auth',
>>                            'registry shares',
>>                            'smb ports',
>> -                          'rpc server dynamic port range'])
>> +                          'rpc server dynamic port range',
>> +                          'name resolve order'])
>>          self._test_empty(['bin/testparm'])
>>  
>>      def test_default_s4(self):
>> @@ -171,7 +172,8 @@ class SmbDotConfTests(TestCase):
>>          self._set_defaults(['bin/samba-tool', 'testparm'])
>>          self._set_arbitrary(['bin/samba-tool', 'testparm'],
>>              exceptions = ['smb ports',
>> -                          'rpc server dynamic port range'])
>> +                          'rpc server dynamic port range',
>> +                          'name resolve order'])
>>          self._test_empty(['bin/samba-tool', 'testparm'])
> Is the 'samba-tool testparm' exception necessary? I would have expected
> this to be source3 testparm only.
yup, me too but apparently not, without this the s4 test fails too
>
> Squashing this into the 0002 does make sense.

assuming all are happy, I'll repost this later on today unless I hear a
shout of dissent

Noel

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFC: new testparam check

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wednesday, 12 April 2017 21:32:52 CEST Noel Power wrote:

> On 12/04/17 16:59, Noel Power via samba-technical wrote:
> > On 12/04/17 16:46, Andreas Schneider via samba-technical wrote:
> [...]
>
> >> [2(6)/2092 at 0s] samba.tests.docs
> >> UNEXPECTED(failure):
> >> samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s3(none)
> >>
> >> REASON: Exception: Exception: Traceback (most recent call last):
> >>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py",
> >>   line
> >>
> >> 166, in test_default_s3
> >>
> >>     'rpc server dynamic port range'])
> >>  
> >>   File "/memdisk/asn/a/b408368/samba/bin/python/samba/tests/docs.py",
> >>   line
> >>
> >> 344, in _set_arbitrary
> >>
> >>     "Parameters that were unexpectedly not set:"))
> >>
> >> AssertionError: Parameters that were unexpectedly not set:
> >>     name resolve order
> >>    
> >>       Expected: a b c
> >>
> >>       Got:
> >> The documentation test needs to be adapted. This is a special variable
> >> now. It should probably be ignored.
> >>
> >> Andreas
> >
> > I will look into this
> >
> >
> > Noel
>
> ok patch 0003 adapts the doc test, if you are happy I suppose I should
> squash it with the existing test patch (0002-xxx) ?

Squashed it to the first patch which implements it, so if you do a 'git
bisect' make test will still work ...


Pushed to autobuild


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Loading...