Quantcast

[Patches] The way to remove gensec_update_ev()

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
Hi,

I'm currently working on the removal of gensec_update_ev(),
which relies on nested event loops to be activated.

If we want to have proper support for trusted domains in the
as AD DC, we need to use real async authentication because
we still use a single process model for the rpc server.

So the first step is to make all users of gensec_update_ev()
use gensec_update_send/recv instead.

Once we have that we need to make the low level auth stack async
for NTLMSSP (as a server) and Kerberos (as a client).

Here's the first chunk of patches, they passed a private autobuild.

Please review and push:-)

Thanks!
metze

gensec-async-part1-01.patches.txt (147K) Download Attachment
signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
Hi,

here's the next chunk on top.

Both are combined the following branch:
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok

https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-tmp
contains the change for the LDAP server, which also pass a private
autobuild, but it needs some more tests to be written.

While
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec
contains the unfinished parts:
- source4/libcli/smb_composite/sesssetup.c
- source4/lib/http/http_auth.c
- auth/gensec/spnego.c

While auth/gensec/spnego.c is the most difficult and time consuming part.

Please review and push:-)

Thanks!
metze

> I'm currently working on the removal of gensec_update_ev(),
> which relies on nested event loops to be activated.
>
> If we want to have proper support for trusted domains in the
> as AD DC, we need to use real async authentication because
> we still use a single process model for the rpc server.
>
> So the first step is to make all users of gensec_update_ev()
> use gensec_update_send/recv instead.
>
> Once we have that we need to make the low level auth stack async
> for NTLMSSP (as a server) and Kerberos (as a client).
>
> Here's the first chunk of patches, they passed a private autobuild.
>
> Please review and push:-)


gensec-async-part2-01.patches.txt (92K) Download Attachment
signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
technical wrote:

> Hi,
>
> I'm currently working on the removal of gensec_update_ev(),
> which relies on nested event loops to be activated.
>
> If we want to have proper support for trusted domains in the
> as AD DC, we need to use real async authentication because
> we still use a single process model for the rpc server.
>
> So the first step is to make all users of gensec_update_ev()
> use gensec_update_send/recv instead.
>
> Once we have that we need to make the low level auth stack async
> for NTLMSSP (as a server) and Kerberos (as a client).
>
> Here's the first chunk of patches, they passed a private autobuild.
>
> Please review and push:-)
I'm looking at these now.  I'm correcting a couple of minor issues in
commit messages (patch of patches attached), but I also noticed:

Subject: [PATCH 25/35] auth/ntlmssp: add implement
 gensec_ntlmssp_update_send/recv()

- if (!out_mem_ctx) {
- /* if the caller doesn't want to manage/own the
memory,
-    we can put it on our context */
- out_mem_ctx = ntlmssp_state;

I don't think it is used, but can we have this as a distinct commit?
I'm sorry to be petty, but it is hard enough reading the change to
async without also removing this at the same time.

The other wrapper changes are much easier to follow, they just rename a
function and call it, but this one also removes hidden return macros
and changes input to in.  They are all great things, but just need to
be a prep patch so I know I'm not missing something.

Thank you so much for the hard work here.  I'll review the next set
shortly.

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

commit-message-fixes.patch.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:

> On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
> technical wrote:
>> Hi,
>>
>> I'm currently working on the removal of gensec_update_ev(),
>> which relies on nested event loops to be activated.
>>
>> If we want to have proper support for trusted domains in the
>> as AD DC, we need to use real async authentication because
>> we still use a single process model for the rpc server.
>>
>> So the first step is to make all users of gensec_update_ev()
>> use gensec_update_send/recv instead.
>>
>> Once we have that we need to make the low level auth stack async
>> for NTLMSSP (as a server) and Kerberos (as a client).
>>
>> Here's the first chunk of patches, they passed a private autobuild.
>>
>> Please review and push:-)
>
> I'm looking at these now.  I'm correcting a couple of minor issues in
> commit messages (patch of patches attached), but I also noticed:
>
> Subject: [PATCH 25/35] auth/ntlmssp: add implement
>  gensec_ntlmssp_update_send/recv()
>
> - if (!out_mem_ctx) {
> - /* if the caller doesn't want to manage/own the
> memory,
> -   we can put it on our context */
> - out_mem_ctx = ntlmssp_state;
>
> I don't think it is used, but can we have this as a distinct commit?
> I'm sorry to be petty, but it is hard enough reading the change to
> async without also removing this at the same time.
Ok, no problem.

> The other wrapper changes are much easier to follow, they just rename a
> function and call it, but this one also removes hidden return macros
> and changes input to in.  They are all great things, but just need to
> be a prep patch so I know I'm not missing something.
>
> Thank you so much for the hard work here.  I'll review the next set
> shortly.

Thanks!
metze



signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, 2017-05-17 at 14:43 +0200, Stefan Metzmacher via samba-
technical wrote:
> Hi,
>
> here's the next chunk on top.

This looks pretty good.  It would be great to get another set of eyes
on it, but I'm still happy to say:

Reviewed-by: Andrew Bartlett <[hidden email]>

In the small notes department:

Subject: [PATCH 24/24] s4:libcli/ldap: just use gensec_update() in
 ldap_bind_sasl()

You could indicate that resolving this requires also resolving the
general case in LDB, as that is the API this is used from.  We would
need ldb_connect_send() and ldb_connect_recv() at a start.



> Both are combined the following branch:
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
>
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-tmp
> contains the change for the LDAP server, which also pass a private
> autobuild, but it needs some more tests to be written.
>
> While
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec
> contains the unfinished parts:
> - source4/libcli/smb_composite/sesssetup.c
> - source4/lib/http/http_auth.c
> - auth/gensec/spnego.c
>
> While auth/gensec/spnego.c is the most difficult and time consuming part.

I'll also take a peek at these and see where you are going.

Thanks for all the hard work here!

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:

> Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
>> On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
>> technical wrote:
>>> Hi,
>>>
>>> I'm currently working on the removal of gensec_update_ev(),
>>> which relies on nested event loops to be activated.
>>>
>>> If we want to have proper support for trusted domains in the
>>> as AD DC, we need to use real async authentication because
>>> we still use a single process model for the rpc server.
>>>
>>> So the first step is to make all users of gensec_update_ev()
>>> use gensec_update_send/recv instead.
>>>
>>> Once we have that we need to make the low level auth stack async
>>> for NTLMSSP (as a server) and Kerberos (as a client).
>>>
>>> Here's the first chunk of patches, they passed a private autobuild.
>>>
>>> Please review and push:-)
>>
>> I'm looking at these now.  I'm correcting a couple of minor issues in
>> commit messages (patch of patches attached), but I also noticed:
>>
>> Subject: [PATCH 25/35] auth/ntlmssp: add implement
>>  gensec_ntlmssp_update_send/recv()
>>
>> - if (!out_mem_ctx) {
>> - /* if the caller doesn't want to manage/own the
>> memory,
>> -   we can put it on our context */
>> - out_mem_ctx = ntlmssp_state;
>>
>> I don't think it is used, but can we have this as a distinct commit?
>> I'm sorry to be petty, but it is hard enough reading the change to
>> async without also removing this at the same time.
>
> Ok, no problem.
Done, the result is in
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok

I've added your review to the last 24 patches (of chunk 2),
the first 39 don't have review tags yet.

metze


signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
On Thu, 2017-05-18 at 16:31 +0200, Stefan Metzmacher wrote:

> Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:
> > Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
> > > On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
> > > technical wrote:
> > > > Hi,
> > > >
> > > > I'm currently working on the removal of gensec_update_ev(),
> > > > which relies on nested event loops to be activated.
> > > >
> > > > If we want to have proper support for trusted domains in the
> > > > as AD DC, we need to use real async authentication because
> > > > we still use a single process model for the rpc server.
> > > >
> > > > So the first step is to make all users of gensec_update_ev()
> > > > use gensec_update_send/recv instead.
> > > >
> > > > Once we have that we need to make the low level auth stack async
> > > > for NTLMSSP (as a server) and Kerberos (as a client).
> > > >
> > > > Here's the first chunk of patches, they passed a private autobuild.
> > > >
> > > > Please review and push:-)
> > >
> > > I'm looking at these now.  I'm correcting a couple of minor issues in
> > > commit messages (patch of patches attached), but I also noticed:
> > >
> > > Subject: [PATCH 25/35] auth/ntlmssp: add implement
> > >  gensec_ntlmssp_update_send/recv()
> > >
> > > - if (!out_mem_ctx) {
> > > - /* if the caller doesn't want to manage/own the
> > > memory,
> > > -   we can put it on our context */
> > > - out_mem_ctx = ntlmssp_state;
> > >
> > > I don't think it is used, but can we have this as a distinct commit?
> > > I'm sorry to be petty, but it is hard enough reading the change to
> > > async without also removing this at the same time.
> >
> > Ok, no problem.
>
> Done, the result is in
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
>
> I've added your review to the last 24 patches (of chunk 2),
> the first 39 don't have review tags yet.

I've reviewed it, but it failed autobuild for samba-o3 with:

../auth/ntlmssp/ntlmssp.c: In function gensec_ntlmssp_update_send:
../auth/ntlmssp/ntlmssp.c:179:31: error: i may be used uninitialized in
this function [-Werror=maybe-uninitialized]
  status = ntlmssp_callbacks[i].sync_fn(gensec_security,
                               ^
Sorry,

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
On Sat, 2017-05-20 at 08:20 +1200, Andrew Bartlett via samba-technical
wrote:

> On Thu, 2017-05-18 at 16:31 +0200, Stefan Metzmacher wrote:
> > Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:
> > > Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
> > > > On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
> > > > technical wrote:
> > > > > Hi,
> > > > >
> > > > > I'm currently working on the removal of gensec_update_ev(),
> > > > > which relies on nested event loops to be activated.
> > > > >
> > > > > If we want to have proper support for trusted domains in the
> > > > > as AD DC, we need to use real async authentication because
> > > > > we still use a single process model for the rpc server.
> > > > >
> > > > > So the first step is to make all users of gensec_update_ev()
> > > > > use gensec_update_send/recv instead.
> > > > >
> > > > > Once we have that we need to make the low level auth stack async
> > > > > for NTLMSSP (as a server) and Kerberos (as a client).
> > > > >
> > > > > Here's the first chunk of patches, they passed a private autobuild.
> > > > >
> > > > > Please review and push:-)
> > > >
> > > > I'm looking at these now.  I'm correcting a couple of minor issues in
> > > > commit messages (patch of patches attached), but I also noticed:
> > > >
> > > > Subject: [PATCH 25/35] auth/ntlmssp: add implement
> > > >  gensec_ntlmssp_update_send/recv()
> > > >
> > > > - if (!out_mem_ctx) {
> > > > - /* if the caller doesn't want to manage/own the
> > > > memory,
> > > > -   we can put it on our context */
> > > > - out_mem_ctx = ntlmssp_state;
> > > >
> > > > I don't think it is used, but can we have this as a distinct commit?
> > > > I'm sorry to be petty, but it is hard enough reading the change to
> > > > async without also removing this at the same time.
> > >
> > > Ok, no problem.
> >
> > Done, the result is in
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
> >
> > I've added your review to the last 24 patches (of chunk 2),
> > the first 39 don't have review tags yet.
>
> I've reviewed it, but it failed autobuild for samba-o3 with:

The reviewed branch is at

https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-gensec

> ../auth/ntlmssp/ntlmssp.c: In function gensec_ntlmssp_update_send:
> ../auth/ntlmssp/ntlmssp.c:179:31: error: i may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
>   status = ntlmssp_callbacks[i].sync_fn(gensec_security,
>                                ^
> Sorry,
>
> Andrew Bartlett
>
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
Am 19.05.2017 um 22:54 schrieb Andrew Bartlett:

> On Sat, 2017-05-20 at 08:20 +1200, Andrew Bartlett via samba-technical
> wrote:
>> On Thu, 2017-05-18 at 16:31 +0200, Stefan Metzmacher wrote:
>>> Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:
>>>> Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
>>>>> On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
>>>>> technical wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I'm currently working on the removal of gensec_update_ev(),
>>>>>> which relies on nested event loops to be activated.
>>>>>>
>>>>>> If we want to have proper support for trusted domains in the
>>>>>> as AD DC, we need to use real async authentication because
>>>>>> we still use a single process model for the rpc server.
>>>>>>
>>>>>> So the first step is to make all users of gensec_update_ev()
>>>>>> use gensec_update_send/recv instead.
>>>>>>
>>>>>> Once we have that we need to make the low level auth stack async
>>>>>> for NTLMSSP (as a server) and Kerberos (as a client).
>>>>>>
>>>>>> Here's the first chunk of patches, they passed a private autobuild.
>>>>>>
>>>>>> Please review and push:-)
>>>>>
>>>>> I'm looking at these now.  I'm correcting a couple of minor issues in
>>>>> commit messages (patch of patches attached), but I also noticed:
>>>>>
>>>>> Subject: [PATCH 25/35] auth/ntlmssp: add implement
>>>>>  gensec_ntlmssp_update_send/recv()
>>>>>
>>>>> - if (!out_mem_ctx) {
>>>>> - /* if the caller doesn't want to manage/own the
>>>>> memory,
>>>>> -   we can put it on our context */
>>>>> - out_mem_ctx = ntlmssp_state;
>>>>>
>>>>> I don't think it is used, but can we have this as a distinct commit?
>>>>> I'm sorry to be petty, but it is hard enough reading the change to
>>>>> async without also removing this at the same time.
>>>>
>>>> Ok, no problem.
>>>
>>> Done, the result is in
>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
>>>
>>> I've added your review to the last 24 patches (of chunk 2),
>>> the first 39 don't have review tags yet.
>>
>> I've reviewed it, but it failed autobuild for samba-o3 with:
>
> The reviewed branch is at
>
> https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-gensec
>
>> ../auth/ntlmssp/ntlmssp.c: In function gensec_ntlmssp_update_send:
>> ../auth/ntlmssp/ntlmssp.c:179:31: error: i may be used uninitialized in
>> this function [-Werror=maybe-uninitialized]
>>   status = ntlmssp_callbacks[i].sync_fn(gensec_security,
>>                                ^
>> Sorry,
The compiler doesn't believe tevent_req_nterror() only returns true on
NT_STATUS_IS_OK().

This diff removes the warning

@@ -161,7 +161,7 @@ static struct tevent_req
*gensec_ntlmssp_update_send(TALLOC_CTX *mem_ctx,
        struct tevent_req *req = NULL;
        struct gensec_ntlmssp_update_state *state = NULL;
        NTSTATUS status;
-       uint32_t i;
+       uint32_t i = 0;

Is it ok to squash that to the "auth/ntlmssp: add implement
gensec_ntlmssp_update_send/recv()" commit and push everything?

Thanks!
metze



signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
Am 21.05.2017 um 13:12 schrieb Stefan Metzmacher via samba-technical:

> Am 19.05.2017 um 22:54 schrieb Andrew Bartlett:
>> On Sat, 2017-05-20 at 08:20 +1200, Andrew Bartlett via samba-technical
>> wrote:
>>> On Thu, 2017-05-18 at 16:31 +0200, Stefan Metzmacher wrote:
>>>> Am 17.05.2017 um 20:10 schrieb Stefan Metzmacher via samba-technical:
>>>>> Am 17.05.2017 um 19:56 schrieb Andrew Bartlett:
>>>>>> On Wed, 2017-05-17 at 14:12 +0200, Stefan Metzmacher via samba-
>>>>>> technical wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> I'm currently working on the removal of gensec_update_ev(),
>>>>>>> which relies on nested event loops to be activated.
>>>>>>>
>>>>>>> If we want to have proper support for trusted domains in the
>>>>>>> as AD DC, we need to use real async authentication because
>>>>>>> we still use a single process model for the rpc server.
>>>>>>>
>>>>>>> So the first step is to make all users of gensec_update_ev()
>>>>>>> use gensec_update_send/recv instead.
>>>>>>>
>>>>>>> Once we have that we need to make the low level auth stack async
>>>>>>> for NTLMSSP (as a server) and Kerberos (as a client).
>>>>>>>
>>>>>>> Here's the first chunk of patches, they passed a private autobuild.
>>>>>>>
>>>>>>> Please review and push:-)
>>>>>>
>>>>>> I'm looking at these now.  I'm correcting a couple of minor issues in
>>>>>> commit messages (patch of patches attached), but I also noticed:
>>>>>>
>>>>>> Subject: [PATCH 25/35] auth/ntlmssp: add implement
>>>>>>  gensec_ntlmssp_update_send/recv()
>>>>>>
>>>>>> - if (!out_mem_ctx) {
>>>>>> - /* if the caller doesn't want to manage/own the
>>>>>> memory,
>>>>>> -   we can put it on our context */
>>>>>> - out_mem_ctx = ntlmssp_state;
>>>>>>
>>>>>> I don't think it is used, but can we have this as a distinct commit?
>>>>>> I'm sorry to be petty, but it is hard enough reading the change to
>>>>>> async without also removing this at the same time.
>>>>>
>>>>> Ok, no problem.
>>>>
>>>> Done, the result is in
>>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok
>>>>
>>>> I've added your review to the last 24 patches (of chunk 2),
>>>> the first 39 don't have review tags yet.
>>>
>>> I've reviewed it, but it failed autobuild for samba-o3 with:
>>
>> The reviewed branch is at
>>
>> https://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-gensec
>>
>>> ../auth/ntlmssp/ntlmssp.c: In function gensec_ntlmssp_update_send:
>>> ../auth/ntlmssp/ntlmssp.c:179:31: error: i may be used uninitialized in
>>> this function [-Werror=maybe-uninitialized]
>>>   status = ntlmssp_callbacks[i].sync_fn(gensec_security,
>>>                                ^
>>> Sorry,
>
> The compiler doesn't believe tevent_req_nterror() only returns true on
> NT_STATUS_IS_OK().
>
> This diff removes the warning
>
> @@ -161,7 +161,7 @@ static struct tevent_req
> *gensec_ntlmssp_update_send(TALLOC_CTX *mem_ctx,
>         struct tevent_req *req = NULL;
>         struct gensec_ntlmssp_update_state *state = NULL;
>         NTSTATUS status;
> -       uint32_t i;
> +       uint32_t i = 0;
>
> Is it ok to squash that to the "auth/ntlmssp: add implement
> gensec_ntlmssp_update_send/recv()" commit and push everything?
"everything" is
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-gensec-ok

metze


signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Patches] The way to remove gensec_update_ev()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sun, 2017-05-21 at 13:12 +0200, Stefan Metzmacher wrote:

>
> The compiler doesn't believe tevent_req_nterror() only returns true on
> NT_STATUS_IS_OK().
>
> This diff removes the warning
>
> @@ -161,7 +161,7 @@ static struct tevent_req
> *gensec_ntlmssp_update_send(TALLOC_CTX *mem_ctx,
>         struct tevent_req *req = NULL;
>         struct gensec_ntlmssp_update_state *state = NULL;
>         NTSTATUS status;
> -       uint32_t i;
> +       uint32_t i = 0;
>
> Is it ok to squash that to the "auth/ntlmssp: add implement
> gensec_ntlmssp_update_send/recv()" commit and push everything?

Yes.  (And I've done that)

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Loading...