[Patches] Some misc ones... (ldbsearch and wscript cleanup)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patches] Some misc ones... (ldbsearch and wscript cleanup)

Stefan Metzmacher-2
Hi,

here're two little patches for master.

Similar to
bed19f3 Garming Sam Mon Jan 30 11:08:07 2017 +1300 ldbedit: Prevent the
use of the reveal internals control
we should not use the --show-binary option for ldb tools except ldbsearch,
as it's dangerous when using it in ldbedit.

The other one is trivial...

Please review and push:-)

Thanks!
metze

tmp.diff.txt (5K) Download Attachment
signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Andrew Bartlett
On Wed, 2017-02-22 at 23:20 +0100, Stefan Metzmacher wrote:

> Hi,
>
> here're two little patches for master.
>
> Similar to
> bed19f3 Garming Sam Mon Jan 30 11:08:07 2017 +1300 ldbedit: Prevent
> the
> use of the reveal internals control
> we should not use the --show-binary option for ldb tools except
> ldbsearch,
> as it's dangerous when using it in ldbedit.
>
> The other one is trivial...
>
> Please review and push:-)

Reviewed-by: Andrew Bartlett <[hidden email]>

I'll push later today when I collect up some other changes.

Andrew Bartlett

Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Stefan Metzmacher-2
Hi Andrew,

one more...

We need to do a new ldb release before we can use that outside of ldb,
do you have any pending ldb changes?

Please review and push:-)

metze
Am 22.02.2017 um 23:34 schrieb Andrew Bartlett:

> On Wed, 2017-02-22 at 23:20 +0100, Stefan Metzmacher wrote:
>> Hi,
>>
>> here're two little patches for master.
>>
>> Similar to
>> bed19f3 Garming Sam Mon Jan 30 11:08:07 2017 +1300 ldbedit: Prevent
>> the
>> use of the reveal internals control
>> we should not use the --show-binary option for ldb tools except
>> ldbsearch,
>> as it's dangerous when using it in ldbedit.
>>
>> The other one is trivial...
>>
>> Please review and push:-)
>
> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> I'll push later today when I collect up some other changes.
>
> Andrew Bartlett
>

tmp.diff.txt (2K) Download Attachment
signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Andrew Bartlett
On Fri, 2017-02-24 at 17:18 +0100, Stefan Metzmacher wrote:
> Hi Andrew,
>
> one more...

Thanks.  This one has been annoying for a very long time.

I've corrected the comment on the flag in the attached.

> We need to do a new ldb release before we can use that outside of
> ldb,
> do you have any pending ldb changes?

No, I and my team at Catalyst don't have any outstanding ldb patches
currently.  

Reviewed-by: Andrew Bartlett <[hidden email]>

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

0001-ldb-add-LDB_FLG_DONT_CREATE_DB.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Andrew Bartlett
On Sat, 2017-02-25 at 08:57 +1300, Andrew Bartlett wrote:

> On Fri, 2017-02-24 at 17:18 +0100, Stefan Metzmacher wrote:
> > Hi Andrew,
> >
> > one more...
>
> Thanks.  This one has been annoying for a very long time.
>
> I've corrected the comment on the flag in the attached.
>
> > We need to do a new ldb release before we can use that outside of
> > ldb,
> > do you have any pending ldb changes?
>
> No, I and my team at Catalyst don't have any outstanding ldb patches
> currently.  
>
> Reviewed-by: Andrew Bartlett <[hidden email]

BTW, I'm presuming you want to bump a release and push it with that, so
I've not pushed it.

Thanks!

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Stefan Metzmacher-2
Am 24.02.2017 um 21:26 schrieb Andrew Bartlett:

> On Sat, 2017-02-25 at 08:57 +1300, Andrew Bartlett wrote:
>> On Fri, 2017-02-24 at 17:18 +0100, Stefan Metzmacher wrote:
>>> Hi Andrew,
>>>
>>> one more...
>>
>> Thanks.  This one has been annoying for a very long time.
>>
>> I've corrected the comment on the flag in the attached.
>>
>>> We need to do a new ldb release before we can use that outside of
>>> ldb,
>>> do you have any pending ldb changes?
>>
>> No, I and my team at Catalyst don't have any outstanding ldb patches
>> currently.  
>>
>> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> BTW, I'm presuming you want to bump a release and push it with that, so
> I've not pushed it.
I pushed it now, as your index improvements seem to land soon.

metze


signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patches] Some misc ones... (ldbsearch and wscript cleanup)

Samba - samba-technical mailing list
On Thu, 2017-03-09 at 08:53 +0100, Stefan Metzmacher wrote:

> Am 24.02.2017 um 21:26 schrieb Andrew Bartlett:
> > On Sat, 2017-02-25 at 08:57 +1300, Andrew Bartlett wrote:
> > > On Fri, 2017-02-24 at 17:18 +0100, Stefan Metzmacher wrote:
> > > > Hi Andrew,
> > > >
> > > > one more...
> > >
> > > Thanks.  This one has been annoying for a very long time.
> > >
> > > I've corrected the comment on the flag in the attached.
> > >
> > > > We need to do a new ldb release before we can use that outside
> > > > of
> > > > ldb,
> > > > do you have any pending ldb changes?
> > >
> > > No, I and my team at Catalyst don't have any outstanding ldb
> > > patches
> > > currently.  
> > >
> > > Reviewed-by: Andrew Bartlett <[hidden email]
> >
> > BTW, I'm presuming you want to bump a release and push it with
> > that, so
> > I've not pushed it.
>
> I pushed it now, as your index improvements seem to land soon.

Sorry I've not yet had a chance to land those, but auth logging should
finish up soon, and I'll get these in soon thereafter.

Thanks,

Andrew Bartlett