[PR PATCH] Fix typo and add missing vfs_zfsacl manpage

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
There is a new pull request by b-a-t against master on the Samba Samba Github repository

https://github.com/b-a-t/samba fix-docs
https://github.com/samba-team/samba/pull/111

Fix typo and add missing vfs_zfsacl manpage
Fix typo in the description of the "getwd cache" option. Add missing
vfs_zfsacl.8 man page to the list of the manpages. Replaced tabs with
spaces where applicable.

Signed-off-by: Timur I. Bakeyev <[hidden email]>


A patch file from https://github.com/samba-team/samba/pull/111.patch is attached

github-pr-fix-docs-111.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
New comment by b-a-t on Samba Github repository

https://github.com/samba-team/samba/pull/111#issuecomment-347073078
Comment:
Filenames were also reshuffled in the `sort` order for easier maintaining.
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
Can one of the developers review this fixes, please?

On Mon, Nov 27, 2017 at 4:57 AM, Github bot account via samba-technical <
[hidden email]> wrote:

> New comment by b-a-t on Samba Github repository
>
> https://github.com/samba-team/samba/pull/111#issuecomment-347073078
> Comment:
> Filenames were also reshuffled in the `sort` order for easier maintaining.
>
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
> Can one of the developers review this fixes, please?

How can I download the raw patch in git-format-patch format from
github? Do I have to clone your repo, or is there a cheaper way? Is
that even possible without logging in to github?

Thanks,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On 11/27/2017 10:18 PM, Volker Lendecke via samba-technical wrote:
> On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
>> Can one of the developers review this fixes, please?
>
> How can I download the raw patch in git-format-patch format from
> github? Do I have to clone your repo, or is there a cheaper way? Is
> that even possible without logging in to github?
>
Add a ".patch" to the pull request URL -

https://github.com/samba-team/samba/pull/111.patch
No need to logon.

Thanks,
Uri

Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On ma, 27 marras 2017, Volker Lendecke via samba-technical wrote:
> On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
> > Can one of the developers review this fixes, please?
>
> How can I download the raw patch in git-format-patch format from
> github? Do I have to clone your repo, or is there a cheaper way? Is
> that even possible without logging in to github?
There are two ways:
 1) the gateway script has actually attached the patch to the original
 email that started this thread

 2) It also linked pull request as a set of commits (in this case, there
 is one commit) as
 ------------------------------------------------------------------------
   A patch file from https://github.com/samba-team/samba/pull/111.patch is attached
 ------------------------------------------------------------------------

 This is not a direct link, github issues a redirect to the current
 location but it can be handled with `curl -L`, for example:

 curl -L https://github.com/samba-team/samba/pull/111.patch
 redirects to  https://patch-diff.githubusercontent.com/raw/samba-team/samba/pull/111.patch
 and fetches it.

There is no need to get logged in to retrieve these details for a public
repository.

--
/ Alexander Bokovoy

Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
> Can one of the developers review this fixes, please?

I would have avoided reordering docs-xml/wscript, but you for sure
have your good reasons for this, and it does not destroy anything.

RB+.

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On Tue, Nov 28, 2017 at 10:00 AM, Volker Lendecke <[hidden email]
> wrote:

> On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via
> samba-technical wrote:
> > Can one of the developers review this fixes, please?
>
> I would have avoided reordering docs-xml/wscript, but you for sure
> have your good reasons for this, and it does not destroy anything.
>
> RB+.
>

My reasoning was to have all the manpages in the sorted order, so it's
easier to maintain additions
and deletions - I guess that's how zfsacl was missed in the first place.

Thanks!

Timur.
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On 11/28/2017 11:00 AM, Volker Lendecke via samba-technical wrote:

> On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
>> Can one of the developers review this fixes, please?
>
> I would have avoided reordering docs-xml/wscript, but you for sure
> have your good reasons for this, and it does not destroy anything.
>
> RB+.
>
> Volker
>

RB+

If you want this back-ported (because both the build omission and the
phrasing can be considered as bugs), please:
1. open a bug in bugzilla
2. split the patch into 3 commits:
a. Fixing the manpage
b. Fixing the build
c. sort (only for master)

I don't insist because it's almost or entirely FreeBSD-specific, and you
folks seem to have your own methods of delivering backports.

Will push tomorrow either way.

Thanks,
Uri

Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On Tue, Nov 28, 2017 at 9:16 PM, Uri Simchoni <[hidden email]> wrote:

> On 11/28/2017 11:00 AM, Volker Lendecke via samba-technical wrote:
> > On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via
> samba-technical wrote:
> >> Can one of the developers review this fixes, please?
> >
> > I would have avoided reordering docs-xml/wscript, but you for sure
> > have your good reasons for this, and it does not destroy anything.
> >
> > RB+.
> >
> > Volker
> >
>
> RB+
>
> If you want this back-ported (because both the build omission and the
> phrasing can be considered as bugs), please:
> 1. open a bug in bugzilla
> 2. split the patch into 3 commits:
> a. Fixing the manpage
> b. Fixing the build
> c. sort (only for master)
>

Apparently I had a bug opened 4 months ago :) So:

https://bugzilla.samba.org/show_bug.cgi?id=12934

I've reworked patch b, so that vfs_zfacl manpage is added only if
corresponding module is enabled.


> I don't insist because it's almost or entirely FreeBSD-specific, and you
> folks seem to have your own methods of delivering backports.
>

That's part of the effort to offload local patches to upstream, as we are
getting too many of them and the could be useful for others.


> Will push tomorrow either way.
>

Thanks!

With regards,
Timur.
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On 11/29/2017 07:53 AM, Timur I. Bakeyev wrote:

> On Tue, Nov 28, 2017 at 9:16 PM, Uri Simchoni <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     On 11/28/2017 11:00 AM, Volker Lendecke via samba-technical wrote:
>     > On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via samba-technical wrote:
>     >> Can one of the developers review this fixes, please?
>     >
>     > I would have avoided reordering docs-xml/wscript, but you for sure
>     > have your good reasons for this, and it does not destroy anything.
>     >
>     > RB+.
>     >
>     > Volker
>     >
>
>     RB+
>
>     If you want this back-ported (because both the build omission and the
>     phrasing can be considered as bugs), please:
>     1. open a bug in bugzilla
>     2. split the patch into 3 commits:
>     a. Fixing the manpage
>     b. Fixing the build
>     c. sort (only for master)
>
>
> Apparently I had a bug opened 4 months ago :) So:
>
> https://bugzilla.samba.org/show_bug.cgi?id=12934
>
> I've reworked patch b, so that vfs_zfacl manpage is added only if
> corresponding module is enabled.
>  
>
RB+ me on this updated version.

Attaching reworked patch for convenience of the list.
Volker, do I still have your RB+ on this? (I'll add the BUG: to the
first two commit messages)

Thanks,
Uri.

zfsacl-manpage-fixes.patch.txt (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo and add missing vfs_zfsacl manpage

Samba - samba-technical mailing list
On Wed, Nov 29, 2017 at 08:04:08AM +0200, Uri Simchoni wrote:
> RB+ me on this updated version.
>
> Attaching reworked patch for convenience of the list.
> Volker, do I still have your RB+ on this? (I'll add the BUG: to the
> first two commit messages)

Yes, sure, thanks for the refactoring of the patch!

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]