[PR PATCH] Fix crackcheck Makefile to allow building on Ubuntu

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Fix crackcheck Makefile to allow building on Ubuntu

Samba - samba-technical mailing list
There is a new pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck
https://github.com/samba-team/samba/pull/114

Fix crackcheck Makefile to allow building on Ubuntu
This patch fixes the following failure when attempting to build crackcheck under Ubuntu 16.04:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
gcc  -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~

It just needs the `-lcrack` option to be moved to the end of the command line. Also adds `#include <unistd.h>` to silence the getopt warning.

A patch file from https://github.com/samba-team/samba/pull/114.patch is attached

github-pr-candlerb/crackcheck-114.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Fix crackcheck Makefile to allow building on Ubuntu

Samba - samba-technical mailing list
On Thu, Dec 14, 2017 at 10:36:38AM +0000, Github bot account via samba-technical wrote:
> There is a new pull request by candlerb against master on the Samba Samba Github repository
>
> https://github.com/candlerb/samba candlerb/crackcheck
> https://github.com/samba-team/samba/pull/114

Can you make 2 patches out of this, for the two aspects of the fix?

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fix crackcheck Makefile to allow building on Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by cryptomilk on Samba Github repository

https://github.com/samba-team/samba/pull/114#issuecomment-351787540
Comment:
From Volker: Can you make 2 patches out of this, for the two aspects of the fix?
Reply | Threaded
Open this post in threaded view
|

Re: Fix crackcheck Makefile to allow building on Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/114#issuecomment-351830369
Comment:
Split into #115 and #116 on request
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Closed]: Fix crackcheck Makefile to allow building on Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There's a closed pull request on the Samba Samba Github repository

Fix crackcheck Makefile to allow building on Ubuntu
https://github.com/samba-team/samba/pull/114
Description: This patch fixes the following failure when attempting to build crackcheck under Ubuntu 16.04:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
gcc  -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~

It just needs the `-lcrack` option to be moved to the end of the command line. Also adds `#include <unistd.h>` to silence the getopt warning.