[PR PATCH] Correction of comment in winbindd_pam.c

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Correction of comment in winbindd_pam.c

Samba - samba-technical mailing list
There is a new pull request by amitkumar50 against master on the Samba Samba Github repository

https://github.com/amitkumar50/samba branch-samba-comment-fix1
https://github.com/samba-team/samba/pull/117

Correction of comment in winbindd_pam.c
Internal comment corrected for better understanding.

A patch file from https://github.com/samba-team/samba/pull/117.patch is attached

github-pr-branch-samba-comment-fix1-117.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Correction of comment in winbindd_pam.c

Samba - samba-technical mailing list
On Thu, Dec 21, 2017 at 11:45:09AM +0000, Github bot account via samba-technical wrote:
> There is a new pull request by amitkumar50 against master on the Samba Samba Github repository
>
> https://github.com/amitkumar50/samba branch-samba-comment-fix1
> https://github.com/samba-team/samba/pull/117
>
> Correction of comment in winbindd_pam.c
> Internal comment corrected for better understanding.
>
> A patch file from https://github.com/samba-team/samba/pull/117.patch is attached

RB+. Another one?

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Correction of comment in winbindd_pam.c

Samba - samba-technical mailing list
On to, 21 joulu 2017, Volker Lendecke via samba-technical wrote:

> On Thu, Dec 21, 2017 at 11:45:09AM +0000, Github bot account via samba-technical wrote:
> > There is a new pull request by amitkumar50 against master on the Samba Samba Github repository
> >
> > https://github.com/amitkumar50/samba branch-samba-comment-fix1
> > https://github.com/samba-team/samba/pull/117
> >
> > Correction of comment in winbindd_pam.c
> > Internal comment corrected for better understanding.
> >
> > A patch file from https://github.com/samba-team/samba/pull/117.patch is attached
>
> RB+. Another one?
RB+ too. Please commit with the rest of commits since this is a comment
message fix only.
--
/ Alexander Bokovoy

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Correction of comment in winbindd_pam.c

Samba - samba-technical mailing list
On Thu, Dec 21, 2017 at 02:08:33PM +0200, Alexander Bokovoy via samba-technical wrote:

> On to, 21 joulu 2017, Volker Lendecke via samba-technical wrote:
> > On Thu, Dec 21, 2017 at 11:45:09AM +0000, Github bot account via samba-technical wrote:
> > > There is a new pull request by amitkumar50 against master on the Samba Samba Github repository
> > >
> > > https://github.com/amitkumar50/samba branch-samba-comment-fix1
> > > https://github.com/samba-team/samba/pull/117
> > >
> > > Correction of comment in winbindd_pam.c
> > > Internal comment corrected for better understanding.
> > >
> > > A patch file from https://github.com/samba-team/samba/pull/117.patch is attached
> >
> > RB+. Another one?
> RB+ too. Please commit with the rest of commits since this is a comment
> message fix only.

Please do the push when you have more important stuff to push. I don't
have anything in the queue right now.

Thanks,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Correction of comment in winbindd_pam.c

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Thu, Dec 21, 2017 at 02:08:33PM +0200, Alexander Bokovoy via samba-technical wrote:

> On to, 21 joulu 2017, Volker Lendecke via samba-technical wrote:
> > On Thu, Dec 21, 2017 at 11:45:09AM +0000, Github bot account via samba-technical wrote:
> > > There is a new pull request by amitkumar50 against master on the Samba Samba Github repository
> > >
> > > https://github.com/amitkumar50/samba branch-samba-comment-fix1
> > > https://github.com/samba-team/samba/pull/117
> > >
> > > Correction of comment in winbindd_pam.c
> > > Internal comment corrected for better understanding.
> > >
> > > A patch file from https://github.com/samba-team/samba/pull/117.patch is attached
> >
> > RB+. Another one?
> RB+ too. Please commit with the rest of commits since this is a comment
> message fix only.

Sorry, needs a Signed-off-by: amitkuma <[hidden email]>
line before we can merge, just to make sure it's allowed as
a Red Hat patch.

Sorry to be the language lawyer here :-(, but these things end up
mattering in the long run.

amitkuma <[hidden email]> - you can submit directly
on [hidden email] in the future, as that's
the way we usually receive patches.

Cheers,

        Jeremy.