[PR PATCH] Change order of flags in Makefile so that crackcheck builds under Ubuntu

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Change order of flags in Makefile so that crackcheck builds under Ubuntu

Samba - samba-technical mailing list
There is a new pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-makefile
https://github.com/samba-team/samba/pull/115

Change order of flags in Makefile so that crackcheck builds under Ubuntu
Fixes build problem under Ubuntu

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
...
gcc  -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~


A patch file from https://github.com/samba-team/samba/pull/115.patch is attached

github-pr-candlerb/crackcheck-makefile-115.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Change order of flags in Makefile so that crackcheck builds under Ubuntu

Samba - samba-technical mailing list
There is an updated pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-makefile
https://github.com/samba-team/samba/pull/115

Change order of flags in Makefile so that crackcheck builds under Ubuntu
Fixes build problem under Ubuntu

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
...
gcc  -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~


A patch file from https://github.com/samba-team/samba/pull/115.patch is attached

github-pr-candlerb/crackcheck-makefile-115.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Change order of flags in Makefile so that crackcheck builds under Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/115#issuecomment-354964752
Comment:
Added Signed-Off-By: line to commit message
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Change order of flags in Makefile so that crackcheck builds under Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There is an updated pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-makefile
https://github.com/samba-team/samba/pull/115

Change order of flags in Makefile so that crackcheck builds under Ubuntu
Fixes build problem under Ubuntu

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
...
gcc  -O2 -lcrack -o crackcheck crackcheck.o
crackcheck.o: In function `main':
crackcheck.c:(.text.startup+0xee): undefined reference to `FascistCheck'
collect2: error: ld returned 1 exit status
Makefile:18: recipe for target 'crackcheck' failed
make: *** [crackcheck] Error 1
~~~


A patch file from https://github.com/samba-team/samba/pull/115.patch is attached

github-pr-candlerb/crackcheck-makefile-115.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Change order of flags in Makefile so that crackcheck builds under Ubuntu

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/115#issuecomment-354968736
Comment:
No idea why travis failed, but I have now rebased commit onto current master