[PR PATCH] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
There is an updated pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba set_log_callback_libsmbclient
https://github.com/samba-team/samba/pull/112

Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs


A patch file from https://github.com/samba-team/samba/pull/112.patch is attached

github-pr-set_log_callback_libsmbclient-112.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
Hi Andrew,

Added the torture test and also fixed styling as suggested.

- Puran

On Wed, Dec 6, 2017 at 9:07 AM, Github bot account via samba-technical <
[hidden email]> wrote:

> There is an updated pull request by puran157 against master on the Samba
> Samba Github repository
>
> https://github.com/puran157/samba set_log_callback_libsmbclient
> https://github.com/samba-team/samba/pull/112
>
> Added smbc_SetLogCallback which lets third party code to capture
> libsmbclient logs
>
>
> A patch file from https://github.com/samba-team/samba/pull/112.patch is
> attached
>
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
Hi all,

Can I get a second reviewer please on this patch?

- Puran

On Wed, Dec 6, 2017 at 10:13 AM, Puran Chand <[hidden email]> wrote:

> Hi Andrew,
>
> Added the torture test and also fixed styling as suggested.
>
> - Puran
>
> On Wed, Dec 6, 2017 at 9:07 AM, Github bot account via samba-technical <
> [hidden email]> wrote:
>
>> There is an updated pull request by puran157 against master on the Samba
>> Samba Github repository
>>
>> https://github.com/puran157/samba set_log_callback_libsmbclient
>> https://github.com/samba-team/samba/pull/112
>>
>> Added smbc_SetLogCallback which lets third party code to capture
>> libsmbclient logs
>>
>>
>> A patch file from https://github.com/samba-team/samba/pull/112.patch is
>> attached
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via samba-technical wrote:
> Hi all,
>
> Can I get a second reviewer please on this patch?

Can you send the patch to the samba-technical mailing list
as a separate message so I can review it please. I generally just delete the
github-pull-request messages as I'm not intending to use
a proprietary site to develop Samba.

Thanks,

Jeremy.

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via samba-technical wrote:
> > Hi all,
> >
> > Can I get a second reviewer please on this patch?
>
> Can you send the patch to the samba-technical mailing list
> as a separate message so I can review it please. I generally just delete the
> github-pull-request messages as I'm not intending to use
> a proprietary site to develop Samba.

Jeremy,

All patches sent via githbub are (again, it was broken for a long
while) sent to samba-technical by a bot (that is what you are replying
to).

I've reviewed the patch (fixing a couple of small style issues) and it
is waiting on autobuild.

Please don't discourage our contributors.  This method is what we
currently document on our wiki as being suitable.  

In the meantime I'm working to get a better arrangement working for
gitlab.com which I hope will better address your legitimate software
freedom concerns.

Thanks,

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
On Sat, Dec 09, 2017 at 07:48:47AM +1300, Andrew Bartlett wrote:

> On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> > On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via samba-technical wrote:
> > > Hi all,
> > >
> > > Can I get a second reviewer please on this patch?
> >
> > Can you send the patch to the samba-technical mailing list
> > as a separate message so I can review it please. I generally just delete the
> > github-pull-request messages as I'm not intending to use
> > a proprietary site to develop Samba.
>
> Jeremy,
>
> All patches sent via githbub are (again, it was broken for a long
> while) sent to samba-technical by a bot (that is what you are replying
> to).
>
> I've reviewed the patch (fixing a couple of small style issues) and it
> is waiting on autobuild.
>
> Please don't discourage our contributors.  This method is what we
> currently document on our wiki as being suitable.  

Sorry, I'm not trying to discourage people. I didn't know this was documented as
the 'suitable' way. I don't think it is :-).

> In the meantime I'm working to get a better arrangement working for
> gitlab.com which I hope will better address your legitimate software
> freedom concerns.

My issues with the github method at the moment is the flood
of emails it generates, which makes it almost impossible to
pick out the actual patch someone wants me to look at.

If it only sent *one* message including the patch I'd probably
stop moaning about software freedom and be more inclined to
just look at it (sorry, human nature there :-).

Cheers,

        Jeremy.

Reply | Threaded
Open this post in threaded view
|

The github mailing list bot

Samba - samba-technical mailing list
On Fri, 2017-12-08 at 10:57 -0800, Jeremy Allison wrote:

> On Sat, Dec 09, 2017 at 07:48:47AM +1300, Andrew Bartlett wrote:
> > On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> > > On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via samba-technical wrote:
> > > > Hi all,
> > > >
> > > > Can I get a second reviewer please on this patch?
> > >
> > > Can you send the patch to the samba-technical mailing list
> > > as a separate message so I can review it please. I generally just delete the
> > > github-pull-request messages as I'm not intending to use
> > > a proprietary site to develop Samba.
> >
> > Jeremy,
> >
> > All patches sent via githbub are (again, it was broken for a long
> > while) sent to samba-technical by a bot (that is what you are replying
> > to).
> >
> > I've reviewed the patch (fixing a couple of small style issues) and it
> > is waiting on autobuild.
> >
> > Please don't discourage our contributors.  This method is what we
> > currently document on our wiki as being suitable.  
>
> Sorry, I'm not trying to discourage people. I didn't know this was documented as
> the 'suitable' way. I don't think it is :-).

I'm sorry you feel that way, this is the first I've heard about it.  

The previous position of the team was that we wanted external
contributors and we wanted to make it easy for them.  

In particular this is currently the most practical way for external
contributors to run our testsuite, as it is trigged into travis-ci
automatically.  

> > In the meantime I'm working to get a better arrangement working for
> > gitlab.com which I hope will better address your legitimate software
> > freedom concerns.
>
> My issues with the github method at the moment is the flood
> of emails it generates, which makes it almost impossible to
> pick out the actual patch someone wants me to look at.

The script is maintained at:

https://github.com/abartlet/gh-mailinglist-notifications

(on github, naturally ;-)

The root folks can get you access to the account the bot runs in.

> If it only sent *one* message including the patch I'd probably
> stop moaning about software freedom and be more inclined to
> just look at it (sorry, human nature there :-).

Patches are welcome, and you can certainly talk to me about it.  Please
don't complain to our contributors, they don't control the bot.

Thanks,

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: The github mailing list bot

Samba - samba-technical mailing list
On Sat, Dec 09, 2017 at 08:06:06AM +1300, Andrew Bartlett wrote:
> On Fri, 2017-12-08 at 10:57 -0800, Jeremy Allison wrote:
> >
> > Sorry, I'm not trying to discourage people. I didn't know this was documented as
> > the 'suitable' way. I don't think it is :-).
>
> I'm sorry you feel that way, this is the first I've heard about it.  
>
> The previous position of the team was that we wanted external
> contributors and we wanted to make it easy for them.  

Still the position :-).

> In particular this is currently the most practical way for external
> contributors to run our testsuite, as it is trigged into travis-ci
> automatically.  
>
> > > In the meantime I'm working to get a better arrangement working for
> > > gitlab.com which I hope will better address your legitimate software
> > > freedom concerns.
> >
> > My issues with the github method at the moment is the flood
> > of emails it generates, which makes it almost impossible to
> > pick out the actual patch someone wants me to look at.
>
> The script is maintained at:
>
> https://github.com/abartlet/gh-mailinglist-notifications
>
> (on github, naturally ;-)
>
> The root folks can get you access to the account the bot runs in.
>
> > If it only sent *one* message including the patch I'd probably
> > stop moaning about software freedom and be more inclined to
> > just look at it (sorry, human nature there :-).
>
> Patches are welcome, and you can certainly talk to me about it.  Please
> don't complain to our contributors, they don't control the bot.

Fair enough. I'll save off this info in case I ever get
irritated enough to try and fix it.

But in the meantime I hope we transition contributors off github and
onto samba-technical for contributing patches as quickly as possible :-).

Jeremy.

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
In the mean-time,

PFA the latest patch file from github. :)

On Sat, Dec 9, 2017 at 12:27 AM, Jeremy Allison <[hidden email]> wrote:

> On Sat, Dec 09, 2017 at 07:48:47AM +1300, Andrew Bartlett wrote:
> > On Fri, 2017-12-08 at 10:32 -0800, Jeremy Allison wrote:
> > > On Thu, Dec 07, 2017 at 03:58:42PM +0530, Puran Chand via
> samba-technical wrote:
> > > > Hi all,
> > > >
> > > > Can I get a second reviewer please on this patch?
> > >
> > > Can you send the patch to the samba-technical mailing list
> > > as a separate message so I can review it please. I generally just
> delete the
> > > github-pull-request messages as I'm not intending to use
> > > a proprietary site to develop Samba.
> >
> > Jeremy,
> >
> > All patches sent via githbub are (again, it was broken for a long
> > while) sent to samba-technical by a bot (that is what you are replying
> > to).
> >
> > I've reviewed the patch (fixing a couple of small style issues) and it
> > is waiting on autobuild.
> >
> > Please don't discourage our contributors.  This method is what we
> > currently document on our wiki as being suitable.
>
> Sorry, I'm not trying to discourage people. I didn't know this was
> documented as
> the 'suitable' way. I don't think it is :-).
>
> > In the meantime I'm working to get a better arrangement working for
> > gitlab.com which I hope will better address your legitimate software
> > freedom concerns.
>
> My issues with the github method at the moment is the flood
> of emails it generates, which makes it almost impossible to
> pick out the actual patch someone wants me to look at.
>
> If it only sent *one* message including the patch I'd probably
> stop moaning about software freedom and be more inclined to
> just look at it (sorry, human nature there :-).
>
> Cheers,
>
>         Jeremy.
>

github-pr-set_log_callback_libsmbclient-112.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Closed]: Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There's a closed pull request on the Samba Samba Github repository

Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs
https://github.com/samba-team/samba/pull/112
Description:
Reply | Threaded
Open this post in threaded view
|

Re: Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by puran157 on Samba Github repository

https://github.com/samba-team/samba/pull/112#issuecomment-350615000
Comment:
This is merged in master hence closing this.
https://github.com/samba-team/samba/commit/2ab9847f54da80352e6ce1f4281649a86558a822

12