[PR PATCH] Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

Samba - samba-technical mailing list
There is a new pull request by puran157 against master on the Samba Samba Github repository

https://github.com/puran157/samba set_configuration_libsmbclient
https://github.com/samba-team/samba/pull/113

Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code


A patch file from https://github.com/samba-team/samba/pull/113.patch is attached

github-pr-set_configuration_libsmbclient-113.patch (16K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

Samba - samba-technical mailing list
This introduces an API in libsmbclient to set smb.conf configruation file
and applies the settings globally.

Review is highly appreciated.

- Puran

On Wed, Nov 29, 2017 at 2:46 PM, Github bot account via samba-technical <
[hidden email]> wrote:

> There is a new pull request by puran157 against master on the Samba Samba
> Github repository
>
> https://github.com/puran157/samba set_configuration_libsmbclient
> https://github.com/samba-team/samba/pull/113
>
> Added smbc_SetConfiguration which lets the user set the smb.conf for
> libsmbclient code
>
>
> A patch file from https://github.com/samba-team/samba/pull/113.patch is
> attached
Reply | Threaded
Open this post in threaded view
|

Re: Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by puran157 on Samba Github repository

https://github.com/samba-team/samba/pull/113#issuecomment-349645214
Comment:
About torture tests, I was thinking to have a temporary smb.conf with modified configuration and use that to update configuration, verify if configuration is reflected or not, undo that with that of default smb.conf and verify if configuration is undone or not.

I just don't know where to put that smb.conf and which smb.conf should be used to restore configuration. (Restoring configuration is important because we don't want other torture tests to get impacted)

Any suggestion in this regard would be great.
Reply | Threaded
Open this post in threaded view
|

Re: Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by ddiss on Samba Github repository

https://github.com/samba-team/samba/pull/113#issuecomment-349649173
Comment:
your test plan sounds reasonable - selftest provisions a client config via write_clientconf (in selftest/selftest.pl), so you might be able to pass that path down to your test for restoration. I'd suggest raising this question directly on the [hidden email] , as you'll reach a much wider audience.