[PR PATCH] Add #include <unistd.h> to provide prototype for getopt()

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
There is a new pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-unistd
https://github.com/samba-team/samba/pull/116

Add #include <unistd.h> to provide prototype for getopt()
Fixes warning when building crackcheck:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
~~~


A patch file from https://github.com/samba-team/samba/pull/116.patch is attached

github-pr-candlerb/crackcheck-unistd-116.patch (920 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
New comment by cryptomilk on Samba Github repository

https://github.com/samba-team/samba/pull/116#issuecomment-354951299
Comment:
You 'Sign-Off' is missing in the patch.
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There is an updated pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-unistd
https://github.com/samba-team/samba/pull/116

Add #include <unistd.h> to provide prototype for getopt()
Fixes warning when building crackcheck:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
~~~


A patch file from https://github.com/samba-team/samba/pull/116.patch is attached

github-pr-candlerb/crackcheck-unistd-116.patch (990 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/116#issuecomment-354964690
Comment:
Added Signed-Off-By: line to commit message
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Updated] Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
There is an updated pull request by candlerb against master on the Samba Samba Github repository

https://github.com/candlerb/samba candlerb/crackcheck-unistd
https://github.com/samba-team/samba/pull/116

Add #include <unistd.h> to provide prototype for getopt()
Fixes warning when building crackcheck:

~~~
# make
gcc  -O2   -c -o crackcheck.o crackcheck.c
crackcheck.c: In function ‘main’:
crackcheck.c:91:15: warning: implicit declaration of function ‘getopt’ [-Wimplicit-function-declaratio
  while ( (c = getopt(argc, argv, "d:cs")) != EOF){
               ^
~~~


A patch file from https://github.com/samba-team/samba/pull/116.patch is attached

github-pr-candlerb/crackcheck-unistd-116.patch (990 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/116#issuecomment-354969017
Comment:
No idea why travis failed, but I have now rebased commit onto current master
Reply | Threaded
Open this post in threaded view
|

Re: Add #include <unistd.h> to provide prototype for getopt()

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
New comment by candlerb on Samba Github repository

https://github.com/samba-team/samba/pull/116#issuecomment-355042888
Comment:
Travis 225.1 to 225.7 inclusive are failing with

~~~
Checking for macro gnutls_aead_cipher_init                                        : not found
No gnutls support for AEAD encryption
/tmp/b9051/samba-xc/source4/dsdb/samdb/ldb_modules/wscript:43: error: No AES GCM AEAD supportTry installing gnutls if that does not support AEAD try installing nettle-dev or nettle-devel
samba-xc: [configure-native] failed './configure.developer --with-selftest-prefix=./bin/ab --picky-developer --prefix=/tmp/b9051/prefix/samba-xc --extra-python=/usr/bin/python3 --with-profiling-data' with status 1
~~~

This doesn't seem to have anything to do with the patch included here or in #115.