[PR PATCH] Add build option for default smbpasswd location

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PR PATCH] Add build option for default smbpasswd location

github
There is a new pull request by sathieu against master on the Samba Samba Github repository

https://github.com/sathieu/samba waf_smbpasswd_location
https://github.com/samba-team/samba/pull/60

Add build option for default smbpasswd location
This part of the FHS patch was never submitted from https://bugs.debian.org/705449

Signed-off-by: Ivo De Decker <[hidden email]>

A patch file from https://github.com/samba-team/samba/pull/60.patch is attached

github-pr-waf_smbpasswd_location-60.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Add build option for default smbpasswd location

Jeremy Allison
On Tue, Apr 26, 2016 at 07:41:21PM +0000, [hidden email] wrote:

> There is a new pull request by sathieu against master on the Samba Samba Github repository
>
> https://github.com/sathieu/samba waf_smbpasswd_location
> https://github.com/samba-team/samba/pull/60
>
> Add build option for default smbpasswd location
> This part of the FHS patch was never submitted from https://bugs.debian.org/705449
>
> Signed-off-by: Ivo De Decker <[hidden email]>
>
> A patch file from https://github.com/samba-team/samba/pull/60.patch is attached

I'm ok with this (Reviewed-by: Jeremy Allison <[hidden email]>
if it's required by Debian.

Can I get a second Team reviewer ?

Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] Add build option for default smbpasswd location

Andrew Bartlett
On Fri, 2016-04-29 at 14:29 -0700, Jeremy Allison wrote:

> On Tue, Apr 26, 2016 at 07:41:21PM +0000, [hidden email] wrote:
> > There is a new pull request by sathieu against master on the Samba
> > Samba Github repository
> >
> > https://github.com/sathieu/samba waf_smbpasswd_location
> > https://github.com/samba-team/samba/pull/60
> >
> > Add build option for default smbpasswd location
> > This part of the FHS patch was never submitted from
> > https://bugs.debian.org/705449
> >
> > Signed-off-by: Ivo De Decker <[hidden email]>
> >
> > A patch file from https://github.com/samba-team/samba/pull/60.patch
> >  is attached
>
> I'm ok with this (Reviewed-by: Jeremy Allison <[hidden email]>
> if it's required by Debian.
>
> Can I get a second Team reviewer ?

I agree, it is good to have less patches on the Debian side.

I wish we didn't need extra options like this for our deprecated passdb
backend, but Debian's needs a good enough reason for me:

Reviewed-by: Andrew Bartlett <[hidden email]>

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




Reply | Threaded
Open this post in threaded view
|

Re: [PR PATCH] [Closed]: Add build option for default smbpasswd location

Samba - samba-technical mailing list
In reply to this post by github
There's a closed pull request on the Samba Samba Github repository

Add build option for default smbpasswd location
https://github.com/samba-team/samba/pull/60
Description: This part of the FHS patch was never submitted from https://bugs.debian.org/705449

Signed-off-by: Ivo De Decker [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Add build option for default smbpasswd location

Samba - samba-technical mailing list
In reply to this post by github
New comment by sathieu on Samba Github repository

https://github.com/samba-team/samba/pull/60#issuecomment-356867603
Comment:
Done in 685e813c45436046a18eb3b8895da5846bd2a0dc (samba-4.5.0rc1).