[PATCHES] de-couple vfs_streams_xattr from "ea support"

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCHES] de-couple vfs_streams_xattr from "ea support"

Uri Simchoni-4
"ea support" conf parameter determines whether smbd will handle SMB
requests related to extended attributes. vfs_streams_xattr currently
requires "ea support = yes", or it won't list streams, but doesn't seem
aligned with the desired meaning of "ea support" which is the
client-facing behavior, not the storage backend behavior. This is mostly
relevant to vfs_fruit and Mac support.

This patch set removes this coupling - it allows EA's to be disabled and
EA-based streams to be enabled.

First two patches are small unrelated cleanups, then the actual change,
then changes to documentation, selftest, and testparm.

Review appreciated,
Uri.


fruit-ea-support.patch.txt (12K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCHES] de-couple vfs_streams_xattr from "ea support"

Ralph Böhme-2
On Thu, Mar 02, 2017 at 09:37:35PM +0200, Uri Simchoni wrote:

> "ea support" conf parameter determines whether smbd will handle SMB
> requests related to extended attributes. vfs_streams_xattr currently
> requires "ea support = yes", or it won't list streams, but doesn't seem
> aligned with the desired meaning of "ea support" which is the
> client-facing behavior, not the storage backend behavior. This is mostly
> relevant to vfs_fruit and Mac support.
>
> This patch set removes this coupling - it allows EA's to be disabled and
> EA-based streams to be enabled.
>
> First two patches are small unrelated cleanups, then the actual change,
> then changes to documentation, selftest, and testparm.
>
> Review appreciated,

this has been on my todo list far too long, thanks!

Lgtm&pushed.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCHES] de-couple vfs_streams_xattr from "ea support"

Andreas Schneider-15
In reply to this post by Uri Simchoni-4
On Thursday, 2 March 2017 20:37:35 CET Uri Simchoni wrote:

> "ea support" conf parameter determines whether smbd will handle SMB
> requests related to extended attributes. vfs_streams_xattr currently
> requires "ea support = yes", or it won't list streams, but doesn't seem
> aligned with the desired meaning of "ea support" which is the
> client-facing behavior, not the storage backend behavior. This is mostly
> relevant to vfs_fruit and Mac support.
>
> This patch set removes this coupling - it allows EA's to be disabled and
> EA-based streams to be enabled.
>
> First two patches are small unrelated cleanups, then the actual change,
> then changes to documentation, selftest, and testparm.
>
> Review appreciated,
> Uri.

While you guys are working on this. Could you please update

docs-xml/smbdotconf/protocol/easupport.xml

It more or less states that this option is only for OS/2 support ...



Thanks,


        Andreas


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCHES] de-couple vfs_streams_xattr from "ea support"

Uri Simchoni-4
On 03/03/2017 09:26 AM, Andreas Schneider wrote:

> On Thursday, 2 March 2017 20:37:35 CET Uri Simchoni wrote:
>> "ea support" conf parameter determines whether smbd will handle SMB
>> requests related to extended attributes. vfs_streams_xattr currently
>> requires "ea support = yes", or it won't list streams, but doesn't seem
>> aligned with the desired meaning of "ea support" which is the
>> client-facing behavior, not the storage backend behavior. This is mostly
>> relevant to vfs_fruit and Mac support.
>>
>> This patch set removes this coupling - it allows EA's to be disabled and
>> EA-based streams to be enabled.
>>
>> First two patches are small unrelated cleanups, then the actual change,
>> then changes to documentation, selftest, and testparm.
>>
>> Review appreciated,
>> Uri.
>
> While you guys are working on this. Could you please update
>
> docs-xml/smbdotconf/protocol/easupport.xml
>
> It more or less states that this option is only for OS/2 support ...
>
>
>
> Thanks,
>
>
> Andreas
>
>
How about this edit?

Thanks,
Uri.


easupport.patch.txt (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCHES] de-couple vfs_streams_xattr from "ea support"

Samba - samba-technical mailing list
On Fri, Mar 03, 2017 at 10:56:40PM +0200, Uri Simchoni wrote:

> On 03/03/2017 09:26 AM, Andreas Schneider wrote:
> > On Thursday, 2 March 2017 20:37:35 CET Uri Simchoni wrote:
> >> "ea support" conf parameter determines whether smbd will handle SMB
> >> requests related to extended attributes. vfs_streams_xattr currently
> >> requires "ea support = yes", or it won't list streams, but doesn't seem
> >> aligned with the desired meaning of "ea support" which is the
> >> client-facing behavior, not the storage backend behavior. This is mostly
> >> relevant to vfs_fruit and Mac support.
> >>
> >> This patch set removes this coupling - it allows EA's to be disabled and
> >> EA-based streams to be enabled.
> >>
> >> First two patches are small unrelated cleanups, then the actual change,
> >> then changes to documentation, selftest, and testparm.
> >>
> >> Review appreciated,
> >> Uri.
> >
> > While you guys are working on this. Could you please update
> >
> > docs-xml/smbdotconf/protocol/easupport.xml
> >
> > It more or less states that this option is only for OS/2 support ...
> >
> >
> >
> > Thanks,
> >
> >
> > Andreas
> >
> >
> How about this edit?

lgtm. Pushed.

Cheerio!
-slow

Loading...