[PATCH] winbindd: lookup-domain for well-known SIDs on a DC

classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
Hi!

Attached is a fix for bug:
<https://bugzilla.samba.org/show_bug.cgi?id=12727>

---8<---
On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by the
local domain, otherwise something simple like this fails with
WBC_ERR_DOMAIN_NOT_FOUND:

$ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1

localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
Could not lookup sid S-1-1-0

On a member server asking our DC works and is what we're currently
doing, but changing it to ask passdb avoids the overhead.
---8<---

Ran across this when working on another bug in the sids2xids code.

Please review & push if ok. Thanks!

Cheerio!
-slow

bug12727-master.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Fri, 31 Mar 2017 22:43:34 +0200
Ralph Böhme via samba-technical <[hidden email]> wrote:

> Hi!
>
> Attached is a fix for bug:
> <https://bugzilla.samba.org/show_bug.cgi?id=12727>
>
> ---8<---
> On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by
> the local domain, otherwise something simple like this fails with
> WBC_ERR_DOMAIN_NOT_FOUND:
>
> $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
>
> localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> Could not lookup sid S-1-1-0
>
> On a member server asking our DC works and is what we're currently
> doing, but changing it to ask passdb avoids the overhead.
> ---8<---
>
> Ran across this when working on another bug in the sids2xids code.
>
> Please review & push if ok. Thanks!
>
> Cheerio!
> -slow

Hi, I think you may have fixed bug 12164 as well ;-)

Rowland

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Fri, Mar 31, 2017 at 10:43:34PM +0200, Ralph Böhme via samba-technical wrote:

> Hi!
>
> Attached is a fix for bug:
> <https://bugzilla.samba.org/show_bug.cgi?id=12727>
>
> ---8<---
> On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by the
> local domain, otherwise something simple like this fails with
> WBC_ERR_DOMAIN_NOT_FOUND:
>
> $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
>
> localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> Could not lookup sid S-1-1-0
>
> On a member server asking our DC works and is what we're currently
> doing, but changing it to ask passdb avoids the overhead.
> ---8<---
>
> Ran across this when working on another bug in the sids2xids code.
>
> Please review & push if ok. Thanks!

Oh, nice fix ! RB+. Pushed.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Fri, 31 Mar 2017 22:43:34 +0200
Ralph Böhme via samba-technical <[hidden email]> wrote:

> Hi!
>
> Attached is a fix for bug:
> <https://bugzilla.samba.org/show_bug.cgi?id=12727>
>
> ---8<---
> On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by
> the local domain, otherwise something simple like this fails with
> WBC_ERR_DOMAIN_NOT_FOUND:
>
> $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
>
> localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> Could not lookup sid S-1-1-0
>
> On a member server asking our DC works and is what we're currently
> doing, but changing it to ask passdb avoids the overhead.
> ---8<---
>
> Ran across this when working on another bug in the sids2xids code.
>
> Please review & push if ok. Thanks!
>
> Cheerio!
> -slow

OK, I have had a good look at the Bash script part of the PATCH and I
have few questions ;-)

Shouldn't 'CREATOR GROUP 5' be 'CREATOR_GROUP 5' ?

The group names in 'WELL_KNOWN_SIDS' start with forward slashes, is
there something in the code somewhere that turns then into the required
backslashes ? or are the 'RESOLVED_NAME' tests supposed to always fail ?

Do you realise that whatever $failed gets set to inside the while loop
will be lost when the loop exits ?

Rowland

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Sat, Apr 01, 2017 at 04:39:52PM +0100, Rowland Penny wrote:

> On Fri, 31 Mar 2017 22:43:34 +0200
> Ralph Böhme via samba-technical <[hidden email]> wrote:
>
> > Hi!
> >
> > Attached is a fix for bug:
> > <https://bugzilla.samba.org/show_bug.cgi?id=12727>
> >
> > ---8<---
> > On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by
> > the local domain, otherwise something simple like this fails with
> > WBC_ERR_DOMAIN_NOT_FOUND:
> >
> > $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
> >
> > localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> > failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> > Could not lookup sid S-1-1-0
> >
> > On a member server asking our DC works and is what we're currently
> > doing, but changing it to ask passdb avoids the overhead.
> > ---8<---
> >
> > Ran across this when working on another bug in the sids2xids code.
> >
> > Please review & push if ok. Thanks!
> >
> > Cheerio!
> > -slow
>
> OK, I have had a good look at the Bash script part of the PATCH and I
> have few questions ;-)
>
> Shouldn't 'CREATOR GROUP 5' be 'CREATOR_GROUP 5' ?

$ ./bin/wbinfo -s S-1-3-1
\Creator Group 5

> The group names in 'WELL_KNOWN_SIDS' start with forward slashes, is
> there something in the code somewhere that turns then into the required
> backslashes ?

$ git grep "winbind separator" selftest/

:)

> or are the 'RESOLVED_NAME' tests supposed to always fail ?

Heavens, no! :)

> Do you realise that whatever $failed gets set to inside the while loop
> will be lost when the loop exits ?

Are you sure?

$ failed=0 ; while [ true ] ; do failed=1 ; break ; done ; echo $failed
1
$

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Sat, 1 Apr 2017 19:05:11 +0200
Ralph Böhme <[hidden email]> wrote:

> On Sat, Apr 01, 2017 at 04:39:52PM +0100, Rowland Penny wrote:
> > On Fri, 31 Mar 2017 22:43:34 +0200
> > Ralph Böhme via samba-technical <[hidden email]>
> > wrote:
> >
> > > Hi!
> > >
> > > Attached is a fix for bug:
> > > <https://bugzilla.samba.org/show_bug.cgi?id=12727>
> > >
> > > ---8<---
> > > On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled
> > > by the local domain, otherwise something simple like this fails
> > > with WBC_ERR_DOMAIN_NOT_FOUND:
> > >
> > > $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
> > >
> > > localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> > > failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> > > Could not lookup sid S-1-1-0
> > >
> > > On a member server asking our DC works and is what we're currently
> > > doing, but changing it to ask passdb avoids the overhead.
> > > ---8<---
> > >
> > > Ran across this when working on another bug in the sids2xids code.
> > >
> > > Please review & push if ok. Thanks!
> > >
> > > Cheerio!
> > > -slow
> >
> > OK, I have had a good look at the Bash script part of the PATCH and
> > I have few questions ;-)
> >
> > Shouldn't 'CREATOR GROUP 5' be 'CREATOR_GROUP 5' ?
>
> $ ./bin/wbinfo -s S-1-3-1
> \Creator Group 5

Hmm, on a Samba 4.6.1 domain member:

root@devstation:~# wbinfo -s S-1-3-1
\CREATOR_GROUP 5

>
> > The group names in 'WELL_KNOWN_SIDS' start with forward slashes, is
> > there something in the code somewhere that turns then into the
> > required backslashes ?
>
> $ git grep "winbind separator" selftest/
>
> :)

Thanks, I will look into that

>
> > or are the 'RESOLVED_NAME' tests supposed to always fail ?
>
> Heavens, no! :)

Thought not :-)

>
> > Do you realise that whatever $failed gets set to inside the while
> > loop will be lost when the loop exits ?
>
> Are you sure?
>
> $ failed=0 ; while [ true ] ; do failed=1 ; break ; done ; echo
> $failed 1
> $
>

Fairly sure:

#!/bin/sh

failed=0
WELL_KNOWN_SIDS="S-1-1-0\n /EVERYONE 5\n S-1-3-1\n /CREATOR GROUP 5\n S-1-5-1\n NT AUTHORITY/DIALUP 5"

echo -e "$WELL_KNOWN_SIDS" | while read SID ; do
    read NAME

    failed=1
done

echo "FAILED: $failed"

exit 0

root@devstation:# bash ./testfrag3.sh
FAILED: 0

Rowland


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sat, 1 Apr 2017 19:05:11 +0200
Ralph Böhme <[hidden email]> wrote:

>
> > The group names in 'WELL_KNOWN_SIDS' start with forward slashes, is
> > there something in the code somewhere that turns then into the
> > required backslashes ?
>
> $ git grep "winbind separator" selftest/
>
> :)

Ah, I get it, set the winbind separator to '/' to get around the
backslash in a script problem, very smart :-)

Rowland

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sat, 2017-04-01 at 18:34 +0100, Rowland Penny via samba-technical
wrote:

> On Sat, 1 Apr 2017 19:05:11 +0200
> Ralph Böhme <[hidden email]> wrote:
>
> > On Sat, Apr 01, 2017 at 04:39:52PM +0100, Rowland Penny wrote:
> > >
> > > OK, I have had a good look at the Bash script part of the PATCH
> > > and
> > > I have few questions ;-)
> > >
> > > Shouldn't 'CREATOR GROUP 5' be 'CREATOR_GROUP 5' ?
> >
> > $ ./bin/wbinfo -s S-1-3-1
> > \Creator Group 5
>
> Hmm, on a Samba 4.6.1 domain member:
>
> root@devstation:~# wbinfo -s S-1-3-1
> \CREATOR_GROUP 5

Perhaps this is due to "winbind normalize names" ?

Thanks,

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sat, Apr 01, 2017 at 06:34:58PM +0100, Rowland Penny wrote:

> Fairly sure:
>
> #!/bin/sh
>
> failed=0
> WELL_KNOWN_SIDS="S-1-1-0\n /EVERYONE 5\n S-1-3-1\n /CREATOR GROUP 5\n S-1-5-1\n NT AUTHORITY/DIALUP 5"
>
> echo -e "$WELL_KNOWN_SIDS" | while read SID ; do
>     read NAME
>
>     failed=1
> done
>
> echo "FAILED: $failed"
>
> exit 0
>
> root@devstation:# bash ./testfrag3.sh
> FAILED: 0
>
> Rowland
d'oh! The pipe starts a subshell, so of course the value of failed is lost.

Attached version works without a pipe so it should be ok. Thanks a lot for
spotting this!

Cheerio!
-slow

bug12727-master.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:

> On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
> >
> > review_cancel_send()
> >
> > Please take a look at the patch I just sent in reply to Rowland's mail. It
> > contains a shellscript level fix for one of the tests.
>
> Oh sorry, I already pushed your first patch. Sorry Rowland,
> didn't catch the error in review.
>
> Ralph, do you want to rebase on top of what's in master
> already and just send a fix for the test ?
attached.

I'm adding an additional patch under the same bug number, spotted this while
continuing to fight with the sids2xids code.

Cheerio!
-slow

bug12727-part2-master.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Fri, Mar 31, 2017 at 11:21:11PM +0100, Rowland Penny wrote:

> On Fri, 31 Mar 2017 22:43:34 +0200
> Ralph Böhme via samba-technical <[hidden email]> wrote:
>
> > Hi!
> >
> > Attached is a fix for bug:
> > <https://bugzilla.samba.org/show_bug.cgi?id=12727>
> >
> > ---8<---
> > On a DC well-known SIDs like S-1-1-0 (everyone) *must* be handled by
> > the local domain, otherwise something simple like this fails with
> > WBC_ERR_DOMAIN_NOT_FOUND:
> >
> > $ make testenv SELFTEST_TESTENV=nt4_dc SCREEN=1
> >
> > localnt4dc2$ ./bin/wbinfo --sid-to-name S-1-1-0
> > failed to call wbcLookupSid: WBC_ERR_DOMAIN_NOT_FOUND
> > Could not lookup sid S-1-1-0
> >
> > On a member server asking our DC works and is what we're currently
> > doing, but changing it to ask passdb avoids the overhead.
> > ---8<---
> >
> > Ran across this when working on another bug in the sids2xids code.
> >
> > Please review & push if ok. Thanks!
> >
> > Cheerio!
> > -slow
>
> Hi, I think you may have fixed bug 12164 as well ;-)

unfortunately not. I'll try to dig into this one as well while I'm at it.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Saturday, 1 April 2017 20:33:04 CEST Rowland Penny via samba-technical
wrote:

> On Sat, 1 Apr 2017 19:05:11 +0200
>
> Ralph Böhme <[hidden email]> wrote:
> > > The group names in 'WELL_KNOWN_SIDS' start with forward slashes, is
> > > there something in the code somewhere that turns then into the
> > > required backslashes ?
> >
> > $ git grep "winbind separator" selftest/
> >
> > :)
>
> Ah, I get it, set the winbind separator to '/' to get around the
> backslash in a script problem, very smart :-)

No, it isn't. / is the path separator. So if you do path substitutions like:

path = /foo/%u or setting 'template dir' you have some fun.


        Andreas


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Mon, 03 Apr 2017 15:23:40 +0200
Andreas Schneider <[hidden email]> wrote:

> On Saturday, 1 April 2017 20:33:04 CEST Rowland Penny via
> samba-technical wrote:
> > On Sat, 1 Apr 2017 19:05:11 +0200
> >
> > Ralph Böhme <[hidden email]> wrote:
> > > > The group names in 'WELL_KNOWN_SIDS' start with forward
> > > > slashes, is there something in the code somewhere that turns
> > > > then into the required backslashes ?
> > >
> > > $ git grep "winbind separator" selftest/
> > >
> > > :)
> >
> > Ah, I get it, set the winbind separator to '/' to get around the
> > backslash in a script problem, very smart :-)
>
> No, it isn't. / is the path separator. So if you do path
> substitutions like:
>
> path = /foo/%u or setting 'template dir' you have some fun.
>
>
> Andreas
>
>

OH, yes it is ;-)

if you do the grep that Ralph supplied, you will get this:

selftest/selftest.pl:597:        winbind separator = /
selftest/target/Samba3.pm:1476: winbind separator = /
selftest/target/Samba4.pm:563: winbind separator = /

So the tests get run with the winbind separator set to '/'. if you
didn't do this, you would have to add something like this to Ralph's
script:

NAME=$(echo "$NAME" | sed 's|/|\\|g')

You cannot use something like '\EVERYONE 5' in the WELL_KNOWN_SIDS, you
would just end up with 'VERYONE 5'

Rowland

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:

> On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
> > On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
> > >
> > > review_cancel_send()
> > >
> > > Please take a look at the patch I just sent in reply to Rowland's mail. It
> > > contains a shellscript level fix for one of the tests.
> >
> > Oh sorry, I already pushed your first patch. Sorry Rowland,
> > didn't catch the error in review.
> >
> > Ralph, do you want to rebase on top of what's in master
> > already and just send a fix for the test ?
>
> attached.
>
> I'm adding an additional patch under the same bug number, spotted this while
> continuing to fight with the sids2xids code.

just in case this one got lost... *ping*

Thanks!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On 04/04/2017 01:50 PM, Ralph Böhme via samba-technical wrote:

> On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:
>> On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
>>> On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
>>>>
>>>> review_cancel_send()
>>>>
>>>> Please take a look at the patch I just sent in reply to Rowland's mail. It
>>>> contains a shellscript level fix for one of the tests.
>>>
>>> Oh sorry, I already pushed your first patch. Sorry Rowland,
>>> didn't catch the error in review.
>>>
>>> Ralph, do you want to rebase on top of what's in master
>>> already and just send a fix for the test ?
>>
>> attached.
>>
>> I'm adding an additional patch under the same bug number, spotted this while
>> continuing to fight with the sids2xids code.
>
> just in case this one got lost... *ping*
>
> Thanks!
> -slow
>
I think we had a mid-air collision with patch 1/2 - see 4/6 in my v2
patch for the SID history and tell me what you think...

RB+ on the test

(BTW, if I understand correctly, the exist status has no impact on the
outcome of "make test" - it's the subunit output that matters, but we
generate a return status for out-of-make-test execution).

Thanks,
Uri.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Tue, Apr 04, 2017 at 09:23:25PM +0300, Uri Simchoni wrote:

> On 04/04/2017 01:50 PM, Ralph Böhme via samba-technical wrote:
> > On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:
> >> On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
> >>> On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
> >>>>
> >>>> review_cancel_send()
> >>>>
> >>>> Please take a look at the patch I just sent in reply to Rowland's mail. It
> >>>> contains a shellscript level fix for one of the tests.
> >>>
> >>> Oh sorry, I already pushed your first patch. Sorry Rowland,
> >>> didn't catch the error in review.
> >>>
> >>> Ralph, do you want to rebase on top of what's in master
> >>> already and just send a fix for the test ?
> >>
> >> attached.
> >>
> >> I'm adding an additional patch under the same bug number, spotted this while
> >> continuing to fight with the sids2xids code.
> >
> > just in case this one got lost... *ping*
> >
> > Thanks!
> > -slow
> >
> I think we had a mid-air collision with patch 1/2 - see 4/6 in my v2
> patch for the SID history and tell me what you think...

yup, I *think* your 4/6 is correct, but I need to study more closely when I'm
done with my sids2xids bugfix and cleanup.

I'd say whichever patchset goes in first, the other just has to cope and rebase,
no prob from my side.

> RB+ on the test

Thanks.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Tue, Apr 04, 2017 at 12:50:54PM +0200, Ralph Böhme wrote:

> On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:
> > On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
> > > On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
> > > >
> > > > review_cancel_send()
> > > >
> > > > Please take a look at the patch I just sent in reply to Rowland's mail. It
> > > > contains a shellscript level fix for one of the tests.
> > >
> > > Oh sorry, I already pushed your first patch. Sorry Rowland,
> > > didn't catch the error in review.
> > >
> > > Ralph, do you want to rebase on top of what's in master
> > > already and just send a fix for the test ?
> >
> > attached.
> >
> > I'm adding an additional patch under the same bug number, spotted this while
> > continuing to fight with the sids2xids code.
>
> just in case this one got lost... *ping*

just wanted to let you know that this one is now already in master.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] winbindd: lookup-domain for well-known SIDs on a DC

Samba - samba-technical mailing list
On Fri, Apr 07, 2017 at 07:34:13PM +0200, Ralph Böhme wrote:

> On Tue, Apr 04, 2017 at 12:50:54PM +0200, Ralph Böhme wrote:
> > On Sun, Apr 02, 2017 at 05:10:02PM +0200, Ralph Böhme wrote:
> > > On Sat, Apr 01, 2017 at 11:26:09PM +0000, Jeremy Allison wrote:
> > > > On Sat, Apr 01, 2017 at 11:40:23PM +0200, Ralph Böhme wrote:
> > > > >
> > > > > review_cancel_send()
> > > > >
> > > > > Please take a look at the patch I just sent in reply to Rowland's mail. It
> > > > > contains a shellscript level fix for one of the tests.
> > > >
> > > > Oh sorry, I already pushed your first patch. Sorry Rowland,
> > > > didn't catch the error in review.
> > > >
> > > > Ralph, do you want to rebase on top of what's in master
> > > > already and just send a fix for the test ?
> > >
> > > attached.
> > >
> > > I'm adding an additional patch under the same bug number, spotted this while
> > > continuing to fight with the sids2xids code.
> >
> > just in case this one got lost... *ping*
>
> just wanted to let you know that this one is now already in master.

Yep, getting caught up on my pending-patches-to-push and
already noticed this one was in :-).

Loading...