[PATCH] vfs_solarisacl: fix build for samba 4.7 and up

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] vfs_solarisacl: fix build for samba 4.7 and up

Samba - samba-technical mailing list
Filed as bug 13049 on bugzilla

Signed-off-by: Jorge Schrauwen <[hidden email]>
---
 source3/modules/vfs_solarisacl.c | 2 +-
 source3/modules/vfs_solarisacl.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/source3/modules/vfs_solarisacl.c b/source3/modules/vfs_solarisacl.c
index 74086bd9fa7..5c011396ed4 100644
--- a/source3/modules/vfs_solarisacl.c
+++ b/source3/modules/vfs_solarisacl.c
@@ -306,7 +306,7 @@ int solarisacl_sys_acl_set_fd(vfs_handle_struct *handle,
  * check is considered unnecessary. --- Agreed? XXX
  */
 int solarisacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
- struct smb_filename *smb_fname)
+ const struct smb_filename *smb_fname)
 {
  SMB_ACL_T smb_acl;
  int ret = -1;
diff --git a/source3/modules/vfs_solarisacl.h b/source3/modules/vfs_solarisacl.h
index 02bd3711da8..ce2206cbe5b 100644
--- a/source3/modules/vfs_solarisacl.h
+++ b/source3/modules/vfs_solarisacl.h
@@ -41,7 +41,7 @@ int solarisacl_sys_acl_set_fd(vfs_handle_struct *handle,
 int solarisacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
  const struct smb_filename *smb_fname);
 
-NTSTATUS vfs_solarisacl_init(void);
+NTSTATUS vfs_solarisacl_init(TALLOC_CTX *);
 
 #endif
 
--
2.14.1


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] vfs_solarisacl: fix build for samba 4.7 and up

Samba - samba-technical mailing list
On Tue, Oct 03, 2017 at 07:55:28PM +0200, Jorge Schrauwen via samba-technical wrote:

> Filed as bug 13049 on bugzilla
>
> Signed-off-by: Jorge Schrauwen <[hidden email]>
> ---
>  source3/modules/vfs_solarisacl.c | 2 +-
>  source3/modules/vfs_solarisacl.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/source3/modules/vfs_solarisacl.c b/source3/modules/vfs_solarisacl.c
> index 74086bd9fa7..5c011396ed4 100644
> --- a/source3/modules/vfs_solarisacl.c
> +++ b/source3/modules/vfs_solarisacl.c
> @@ -306,7 +306,7 @@ int solarisacl_sys_acl_set_fd(vfs_handle_struct *handle,
>   * check is considered unnecessary. --- Agreed? XXX
>   */
>  int solarisacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
> - struct smb_filename *smb_fname)
> + const struct smb_filename *smb_fname)
>  {
>   SMB_ACL_T smb_acl;
>   int ret = -1;
> diff --git a/source3/modules/vfs_solarisacl.h b/source3/modules/vfs_solarisacl.h
> index 02bd3711da8..ce2206cbe5b 100644
> --- a/source3/modules/vfs_solarisacl.h
> +++ b/source3/modules/vfs_solarisacl.h
> @@ -41,7 +41,7 @@ int solarisacl_sys_acl_set_fd(vfs_handle_struct *handle,
>  int solarisacl_sys_acl_delete_def_file(vfs_handle_struct *handle,
>   const struct smb_filename *smb_fname);
>  
> -NTSTATUS vfs_solarisacl_init(void);
> +NTSTATUS vfs_solarisacl_init(TALLOC_CTX *);
>  
>  #endif
>  
> --
> 2.14.1

LGTM (with commit message tidyup). Can I get a second
Team reviewer ?

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] vfs_solarisacl: fix build for samba 4.7 and up

Samba - samba-technical mailing list
On Tue, Oct 03, 2017 at 06:15:27PM +0000, Jeremy Allison via samba-technical wrote:
> LGTM (with commit message tidyup). Can I get a second
> Team reviewer ?

pushed.

-slow