[PATCH] update the man pages for the prefork process model

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
Update the samba man page and document the process models for the -M
option. including the new prefork option.

Review appreciated.

Gary

man_pages.patch.txt (4K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
On 09/20/2017 03:23 AM, Gary Lockyer wrote:
> Update the samba man page and document the process models for the -M
> option. including the new prefork option.
>
> Review appreciated.
>
> Gary
>
That addresses my concern, although I wouldn't count that as RB because
I don't know enough about the subject matter. I also think this should
be squashed with the other prefork stuff (at least the smb.conf changes).

Thanks,
Uri.


signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, Sep 20, 2017 at 12:23:17PM +1200, Gary Lockyer via samba-technical wrote:
> Update the samba man page and document the process models for the -M
> option. including the new prefork option.
>
> Review appreciated.

LGTM. Can I get a second Team reviewer ?

> From 482ea06e9dcd6efc757a180e7d4e67eff3f07550 Mon Sep 17 00:00:00 2001
> From: Gary Lockyer <[hidden email]>
> Date: Wed, 20 Sep 2017 09:14:10 +1200
> Subject: [PATCH] man pages: document prefrok proces model
>
> Document the process model options -M
>
> Signed-off-by: Gary Lockyer <[hidden email]>
> ---
>  docs-xml/manpages/samba.8.xml                | 31 ++++++++++++++++++++++++----
>  docs-xml/smbdotconf/base/preforkchildren.xml |  4 +++-
>  2 files changed, 30 insertions(+), 5 deletions(-)
>
> diff --git a/docs-xml/manpages/samba.8.xml b/docs-xml/manpages/samba.8.xml
> index d4c5568..c7b1449 100644
> --- a/docs-xml/manpages/samba.8.xml
> +++ b/docs-xml/manpages/samba.8.xml
> @@ -105,10 +105,33 @@
>   <listitem><para>This parameter can be used to specify the
>   &quot;process model&quot; samba should use. This determines
>   how concurrent clients are handled. Available process
> - models include <emphasis>single</emphasis> (everything in
> - a single process), <emphasis>standard</emphasis> (similar
> - behaviour to that of Samba 3), <emphasis>thread</emphasis>
> - (single process, different threads.
> + models include
> + <itemizedlist>
> + <listitem><para><emphasis>single</emphasis></para>
> + <para>All services run in a single process, not
> + recommended for production configurations.
> + </para></listitem>
> +
> + <listitem><para><emphasis>standard</emphasis></para>
> + <para>A process is created for each service,
> + and for those services that support it (currently only
> + ldap and netlogon) a new processes is started
> + for each new connection.</para></listitem>
> +
> + <listitem><para><emphasis>prefork</emphasis></para>
> + <para>A process is started for each service, and extra
> + worker processes are started for those services that
> + support it (currently only ldap).
> + Requests for services not supporting prefork are handled
> + by a single process for that service.</para>
> + <para>The number of worker processes started is
> + controlled by the
> + <citerefentry><refentrytitle>smb.conf</refentrytitle>
> + <manvolnum>5</manvolnum></citerefentry> parameter
> +        <smbconfoption name="prefork children"/>
> + , which defaults to 1.
> + </para></listitem>
> + </itemizedlist>
>   </para></listitem>
>   </varlistentry>
>  
> diff --git a/docs-xml/smbdotconf/base/preforkchildren.xml b/docs-xml/smbdotconf/base/preforkchildren.xml
> index 720e439..c4bf1ab 100644
> --- a/docs-xml/smbdotconf/base/preforkchildren.xml
> +++ b/docs-xml/smbdotconf/base/preforkchildren.xml
> @@ -4,7 +4,9 @@
>                   xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">
>  <description>
>   <para>This option controls the number of worker processes that are
> - started for each service when prefork process model is enabled.
> + started for each service when prefork process model is enabled
> + (see <citerefentry><refentrytitle>samba</refentrytitle>
> + <manvolnum>8</manvolnum></citerefentry> -M)
>   The prefork children are only started for those services that
>   support prefork (currently only ldap). For processes that don't
>   support preforking all requests are handled by a single process
> --
> 2.7.4
>





Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
Am 04.10.2017 um 02:02 schrieb Jeremy Allison via samba-technical:
> On Wed, Sep 20, 2017 at 12:23:17PM +1200, Gary Lockyer via samba-technical wrote:
>> Update the samba man page and document the process models for the -M
>> option. including the new prefork option.
>>
>> Review appreciated.
>
> LGTM. Can I get a second Team reviewer ?

Looks good except that we should document the special behavior with
smbd and winbindd.

metze


signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wed, Oct 04, 2017 at 12:02:17AM +0000, Jeremy Allison via samba-technical wrote:
> On Wed, Sep 20, 2017 at 12:23:17PM +1200, Gary Lockyer via samba-technical wrote:
> > Update the samba man page and document the process models for the -M
> > option. including the new prefork option.
> >
> > Review appreciated.
>
> LGTM. Can I get a second Team reviewer ?

Is there a prefork process model available in master for the samba process to
use with the -M option? I was under the impression that the patchset that added
this was still under review. Am I missing something?

-slow

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
On Wed, Oct 04, 2017 at 09:52:56AM +0200, Ralph Böhme wrote:

> On Wed, Oct 04, 2017 at 12:02:17AM +0000, Jeremy Allison via samba-technical wrote:
> > On Wed, Sep 20, 2017 at 12:23:17PM +1200, Gary Lockyer via samba-technical wrote:
> > > Update the samba man page and document the process models for the -M
> > > option. including the new prefork option.
> > >
> > > Review appreciated.
> >
> > LGTM. Can I get a second Team reviewer ?
>
> Is there a prefork process model available in master for the samba process to
> use with the -M option? I was under the impression that the patchset that added
> this was still under review. Am I missing something?

Oh, for some reason I thought this was in. Ignore the RB+ if not, sorry.

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] update the man pages for the prefork process model

Samba - samba-technical mailing list
On Wed, 2017-10-04 at 16:12 -0700, Jeremy Allison via samba-technical
wrote:
>
> Oh, for some reason I thought this was in. Ignore the RB+ if not, sorry.

Correct, this still needs review.  It would be great if someone could
look over Gary's work here.  I think it is pretty good, but Gary still
needs another team member review, and another set of eyes would be
incredibly valuable in any case.

Thanks,

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba