[PATCH] turn packaging files into template, preprocess and install them

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] turn packaging files into template, preprocess and install them

Samba - samba-technical mailing list
Hi,

This patch adds a bunch of systemd options to the configure script to
allow installing the systemd files in packaging/.

The service files are turned into configure-style templates with @VAR@
substitution and now always use proper values as a result.

The --systemd-{nmb,smb,winbind,samba}-extra options can be used to add
vendor specific directives to the respective service file. These options
can be used multiple times to add multiple directives.

The service files are always preprocessed but only installed if
--systemd-install-services is given. The location where the service
files are installed can be changed with the new option
--with-systemddir.

Cheers,

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

0001-packaging-add-configure-option-to-preprocess-and-ins.patch (9K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] turn packaging files into template, preprocess and install them

Samba - samba-technical mailing list
On Thu, 2017-12-14 at 17:17 +0100, Aurélien Aptel via samba-technical
wrote:

> Hi,
>
> This patch adds a bunch of systemd options to the configure script to
> allow installing the systemd files in packaging/.
>
> The service files are turned into configure-style templates with @VAR@
> substitution and now always use proper values as a result.
>
> The --systemd-{nmb,smb,winbind,samba}-extra options can be used to add
> vendor specific directives to the respective service file. These options
> can be used multiple times to add multiple directives.
>
> The service files are always preprocessed but only installed if
> --systemd-install-services is given. The
> location where the service
> files are installed can be changed with the new option
> --with-systemddir.

Can we have this three parts, the --with-systemdir change, the generic
subs and the -extra stuff?  

Also, is it really work having an --systemd-install-services option?  

It is just an extra file on systems that don't use systemd, and these
option combinations just end up untested.  Software packages not using
systemd will just not package the file, which is fine, and manual
installs will just get a file somewhere under /usr/local/samba unless
they set --with-systemddir

I like the normal subs, because we already have that info, but the
'extra' stuff feels odd to me, isn't that why distributions have
patches they apply?  

Thanks,

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] turn packaging files into template, preprocess and install them

Samba - samba-technical mailing list
On Monday, 18 December 2017 09:05:31 CET Andrew Bartlett via samba-technical
wrote:

> On Thu, 2017-12-14 at 17:17 +0100, Aurélien Aptel via samba-technical
>
> wrote:
> > Hi,
> >
> > This patch adds a bunch of systemd options to the configure script to
> > allow installing the systemd files in packaging/.
> >
> > The service files are turned into configure-style templates with @VAR@
> > substitution and now always use proper values as a result.
> >
> > The --systemd-{nmb,smb,winbind,samba}-extra options can be used to add
> > vendor specific directives to the respective service file. These options
> > can be used multiple times to add multiple directives.
> >
> > The service files are always preprocessed but only installed if
> > --systemd-install-services is given. The
> > location where the service
> > files are installed can be changed with the new option
> > --with-systemddir.
>
> Can we have this three parts, the --with-systemdir change, the generic
> subs and the -extra stuff?  
>
> Also, is it really work having an --systemd-install-services option?  
>
> It is just an extra file on systems that don't use systemd, and these
> option combinations just end up untested.  Software packages not using
> systemd will just not package the file, which is fine, and manual
> installs will just get a file somewhere under /usr/local/samba unless
> they set --with-systemddir
>
> I like the normal subs, because we already have that info, but the
> 'extra' stuff feels odd to me, isn't that why distributions have
> patches they apply?

Currently we "install" the files using sed adding extra stuff to them. For
example exporting KRB5CCNAME to use a file instead of the kernel keyring. This
is probably why he added it.


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org