[PATCH]

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH]

Samba - samba-technical mailing list
Hi Ralph,

On an Ubuntu 16.04 cloud machine, GCC made the complaint in the attached
patch message. I couldn't find a path that justified the warning, but
the initialisation is harmless and there are going to be people using that
compiler.

(Looking through led me to wonder what would happen after this when size-t
is 32 bit:

        ok = conv_str_u64(&line[matches[1].rm_so], &band_size);
        if (!ok) {
                return false;
        }
        *_band_size = (size_t)band_size;

though I suspect the answer is not much of interest).


cheers,
Douglas


0001-vfs_fruit-initialise-bandsize-to-please-a-compiler.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH]

Samba - samba-technical mailing list
Hi Douglas,

On Wed, Jan 10, 2018 at 12:43:11AM +1300, Douglas Bagnall wrote:
> On an Ubuntu 16.04 cloud machine, GCC made the complaint in the attached
> patch message. I couldn't find a path that justified the warning, but
> the initialisation is harmless and there are going to be people using that
> compiler.

thanks!

Going to push later.

-slow

--
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/