[PATCH] smbd: add missing newline to debug message in daemon_status()

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] smbd: add missing newline to debug message in daemon_status()

Samba - samba-technical mailing list
Signed-off-by: Justin Maggard <[hidden email]>
---
 lib/util/become_daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/util/become_daemon.c b/lib/util/become_daemon.c
index 22c1778d4a4..232eda69b64 100644
--- a/lib/util/become_daemon.c
+++ b/lib/util/become_daemon.c
@@ -146,5 +146,5 @@ void daemon_status(const char *daemon, const char *msg)
 #if defined(HAVE_LIBSYSTEMD_DAEMON) || defined(HAVE_LIBSYSTEMD)
  sd_notifyf(0, "\nSTATUS=%s: %s", daemon, msg);
 #endif
- DBG_ERR("STATUS=daemon '%s' : %s", daemon, msg);
+ DBG_ERR("STATUS=daemon '%s' : %s\n", daemon, msg);
 }
--
2.14.1


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] smbd: add missing newline to debug message in daemon_status()

Samba - samba-technical mailing list
If it really needs to see that string, perhaps a printf to stderror
might be better, but in the meantime:

Reviewed-by: Andrew Bartlett <[hidden email]>

Thanks!

On Thu, 2017-09-07 at 11:05 -0700, Justin Maggard via samba-technical
wrote:

> Signed-off-by: Justin Maggard <[hidden email]>
> ---
>  lib/util/become_daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/util/become_daemon.c b/lib/util/become_daemon.c
> index 22c1778d4a4..232eda69b64 100644
> --- a/lib/util/become_daemon.c
> +++ b/lib/util/become_daemon.c
> @@ -146,5 +146,5 @@ void daemon_status(const char *daemon, const char *msg)
>  #if defined(HAVE_LIBSYSTEMD_DAEMON) || defined(HAVE_LIBSYSTEMD)
>   sd_notifyf(0, "\nSTATUS=%s: %s", daemon, msg);
>  #endif
> - DBG_ERR("STATUS=daemon '%s' : %s", daemon, msg);
> + DBG_ERR("STATUS=daemon '%s' : %s\n", daemon, msg);
>  }
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba