[PATCH] smb.conf: Update multi-channel warning text

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] smb.conf: Update multi-channel warning text

Samba - samba-technical mailing list
Since Samba 4.4.x is going EOL soon, update the server multi channel
support warning text to reflect the fact that it's still experimental in
4.7, and it won't be getting fixed in a future 4.4.x version.

Signed-off-by: Justin Maggard <[hidden email]>
---
 docs-xml/smbdotconf/protocol/servermultichannelsupport.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml b/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
index 14db171e3f4..82b9134bc94 100644
--- a/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
+++ b/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
@@ -8,12 +8,12 @@
     <manvolnum>8</manvolnum></citerefentry> will support
     SMB3 multi-channel.
     </para>
-    <para>This parameter has been added with version 4.4.</para>
+    <para>This parameter was added with version 4.4.</para>
     <para>
-    Warning: Note that this feature is considered experimental in Samba 4.4.
+    Warning: Note that this feature is considered experimental as of Samba 4.7.
     Use it at your own risk: Even though it may seem to work well in testing,
     it may result in data corruption under some race conditions.
-    Future 4.4.x release may improve this situation.
+    Future 4.7.x release may improve this situation.
     </para>
 </description>
 
--
2.14.1


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] smb.conf: Update multi-channel warning text

Samba - samba-technical mailing list
On Thu, 2017-09-07 at 11:04 -0700, Justin Maggard via samba-technical
wrote:
> Since Samba 4.4.x is going EOL soon, update the server multi channel
> support warning text to reflect the fact that it's still experimental in
> 4.7, and it won't be getting fixed in a future 4.4.x version.

G'Day Justin!

This Looks good.  Perhaps I'm missing something, but I think suggesting
it might get fixed during the life of 4.7 is a false hope.  Perhaps
just say 'in a future version of Samba'?

Other than that:  Reviewed-by: Andrew Bartlett <[hidden email]>

> Signed-off-by: Justin Maggard <[hidden email]>
> ---
>  docs-xml/smbdotconf/protocol/servermultichannelsupport.xml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml b/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
> index 14db171e3f4..82b9134bc94 100644
> --- a/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
> +++ b/docs-xml/smbdotconf/protocol/servermultichannelsupport.xml
> @@ -8,12 +8,12 @@
>      <manvolnum>8</manvolnum></citerefentry> will support
>      SMB3 multi-channel.
>      </para>
> -    <para>This parameter has been added with version 4.4.</para>
> +    <para>This parameter was added with version 4.4.</para>
>      <para>
> -    Warning: Note that this feature is considered experimental in Samba 4.4.
> +    Warning: Note that this feature is considered experimental as of Samba 4.7.
>      Use it at your own risk: Even though it may seem to work well in testing,
>      it may result in data corruption under some race conditions.
> -    Future 4.4.x release may improve this situation.
> +    Future 4.7.x release may improve this situation.
>      </para>
>  </description>
>  
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba