[PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Samba - samba-technical mailing list
Hi all,

Partway through an autobuild on the catalyst cloud.

Thanks,
- Jamie

samba-selftest-env-vars.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Samba - samba-technical mailing list
Sorry, forgot to commit an indentation fix (to at least make it
consistent with the surrounding code, by having mixed tabs and spaces...
- perhaps I should clean up the perl indentation in a future patch: is
there an agreed indentation style for samba's perl? README.coding talks
about C and Python only).

"Fixed" in the attached :)

Thanks

On 19/12/17 16:13, Jamie McClymont wrote:
> Hi all,
>
> Partway through an autobuild on the catalyst cloud.
>
> Thanks,
> - Jamie
>

samba-selftest-env-vars-indentation-fix.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Samba - samba-technical mailing list
On Tuesday, 19 December 2017 04:27:49 CET Jamie McClymont via samba-technical
wrote:
> Sorry, forgot to commit an indentation fix (to at least make it
> consistent with the surrounding code, by having mixed tabs and spaces...
> - perhaps I should clean up the perl indentation in a future patch: is
> there an agreed indentation style for samba's perl? README.coding talks
> about C and Python only).
>
> "Fixed" in the attached :)

Hi Jamie,

the description of the first commit message confuses me. What do you mean with
'running after an nt4_member'? Is the word 'test' missing?

Do you mean that a test against a nt4_member is running and thus setting
NSS_WRAPPER_HOSTNAME to a value which shouldn't be used when running the
samba3.rpc.samba3.netlogon test?

In the last hunk, could you use a cmd helper variable like we do in other
places?


Thanks,


        Andreas


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Tue, 2017-12-19 at 16:13 +1300, Jamie McClymont via samba-technical
wrote:
> Hi all,
>
> Partway through an autobuild on the catalyst cloud.
>
> Thanks,
> - Jamie

BTW, as context for those on the list, we think this also helps the
whoami flapping test.  It isn't the whole story, but it certainly
improves the behaviour in some situations.  We continue to investigate.

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] selftest: fix ordering dependencies caused by NSS_WRAPPER_ (and potentially RESOLV_WRAPPER_) variables

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
Hi Andreas

> Do you mean that a test against a nt4_member is running and thus setting
> NSS_WRAPPER_HOSTNAME to a value which shouldn't be used when running the
> samba3.rpc.samba3.netlogon test?

That's right, I've clarified in the attached patch (emacs was warning
about the length of the commit summary, hence the ambiguity ;)

> In the last hunk, could you use a cmd helper variable like we do in other
> places?

Done.

Thanks,
- Jamie


samba-selftest-env-vars-with-fixes.patch (8K) Download Attachment