[PATCH] samba-tool: treat "samba-tool help X" like "samba-tool X --help"

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] samba-tool: treat "samba-tool help X" like "samba-tool X --help"

Samba - samba-technical mailing list
There are two reasons for this:

1) it makes browsing the help tree slightly easier. With the help of
the up-arrow, it is simpler to go:

$ samba-tool help
$ samba-tool help drs
$ samba-tool help drs showrepl

than

$ samba-tool --help
$ samba-tool drs --help
$ samba-tool drs showrepl --help

This smallish difference adds up if you are (like me) lazy and ignorant
about samba-tool commands. (yes, *I* know I could use "-h", but my
fingers don't).

2) It helps us to fit in. This is the latest rage. Everyone does it. You
can go "git help log", "perf help record", "openstack help floating ip
create". We should try to look like a part of the modern unix ecosystem.

The downside is the samba-tool help test now calls samba-tool 218 times,
which takes 28 seconds on my machine.

cheers,
Douglas

samba-tool-help.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] samba-tool: treat "samba-tool help X" like "samba-tool X --help"

Samba - samba-technical mailing list
On Thu, 2017-12-21 at 16:21 +1300, Douglas Bagnall via samba-technical
wrote:

> There are two reasons for this:
>
> 1) it makes browsing the help tree slightly easier. With the help of
> the up-arrow, it is simpler to go:
>
> $ samba-tool help
> $ samba-tool help drs
> $ samba-tool help drs showrepl
>
> than
>
> $ samba-tool --help
> $ samba-tool drs --help
> $ samba-tool drs showrepl --help
>
> This smallish difference adds up if you are (like me) lazy and ignorant
> about samba-tool commands. (yes, *I* know I could use "-h", but my
> fingers don't).

Reviewed-by: Andrew Bartlett <[hidden email]>

Please push.

Andrew Bartlett

--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba