[PATCH] samba.ntstatus and samba.werror Python 3 compatible

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] samba.ntstatus and samba.werror Python 3 compatible

Samba - samba-technical mailing list
Hello.

I've prepared patches to make samba.ntstatus and samba.werror modules
Python 3 compatible. First patch ports generators itself and the second
one ports generated Python files.

NTSTATUS_ and WERROR_ constants are widely used among various tests so I
think that it's not necessary to write separated testsuite for modules
containing only constants. If you think that they should be tested more,
I can write some additional testsuite.

Thank you and have a nice day.

Lumír


0002-python-Make-generated-modules-samba.ntstatus-and-sam.patch (5K) Download Attachment
0001-python-scripting-Port-ntstatus-and-werror-generators.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] samba.ntstatus and samba.werror Python 3 compatible

Samba - samba-technical mailing list
On Tuesday, 8 August 2017 12:00:10 CEST Lumir Balhar via samba-technical
wrote:

> Hello.
>
> I've prepared patches to make samba.ntstatus and samba.werror modules
> Python 3 compatible. First patch ports generators itself and the second
> one ports generated Python files.
>
> NTSTATUS_ and WERROR_ constants are widely used among various tests so I
> think that it's not necessary to write separated testsuite for modules
> containing only constants. If you think that they should be tested more,
> I can write some additional testsuite.
>
> Thank you and have a nice day.

RB+ from my side ...

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] samba.ntstatus and samba.werror Python 3 compatible

Samba - samba-technical mailing list
On 08/10/2017 02:47 PM, Andreas Schneider via samba-technical wrote:

> On Tuesday, 8 August 2017 12:00:10 CEST Lumir Balhar via samba-technical
> wrote:
>> Hello.
>>
>> I've prepared patches to make samba.ntstatus and samba.werror modules
>> Python 3 compatible. First patch ports generators itself and the second
>> one ports generated Python files.
>>
>> NTSTATUS_ and WERROR_ constants are widely used among various tests so I
>> think that it's not necessary to write separated testsuite for modules
>> containing only constants. If you think that they should be tested more,
>> I can write some additional testsuite.
>>
>> Thank you and have a nice day.
> RB+ from my side ...
>
Hello.

Is there any problem with merge of this patch? My another patch is
waiting for this.

Thank you and have a nice day.
Lumír

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] samba.ntstatus and samba.werror Python 3 compatible

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Thu, 2017-08-10 at 14:47 +0200, Andreas Schneider via samba-
technical wrote:

> On Tuesday, 8 August 2017 12:00:10 CEST Lumir Balhar via samba-technical
> wrote:
> > Hello.
> >
> > I've prepared patches to make samba.ntstatus and samba.werror modules
> > Python 3 compatible. First patch ports generators itself and the second
> > one ports generated Python files.
> >
> > NTSTATUS_ and WERROR_ constants are widely used among various tests so I
> > think that it's not necessary to write separated testsuite for modules
> > containing only constants. If you think that they should be tested more,
> > I can write some additional testsuite.
> >
> > Thank you and have a nice day.
>
> RB+ from my side ...

Reviewed-by: Andrew Bartlett <[hidden email]>

Please push!  (otherwise I'll do it in the morning)

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] samba.ntstatus and samba.werror Python 3 compatible

Samba - samba-technical mailing list
On Tuesday, 22 August 2017 13:07:28 CEST Andrew Bartlett via samba-technical
wrote:

> On Thu, 2017-08-10 at 14:47 +0200, Andreas Schneider via samba-
>
> technical wrote:
> > On Tuesday, 8 August 2017 12:00:10 CEST Lumir Balhar via samba-technical
> >
> > wrote:
> > > Hello.
> > >
> > > I've prepared patches to make samba.ntstatus and samba.werror modules
> > > Python 3 compatible. First patch ports generators itself and the second
> > > one ports generated Python files.
> > >
> > > NTSTATUS_ and WERROR_ constants are widely used among various tests so I
> > > think that it's not necessary to write separated testsuite for modules
> > > containing only constants. If you think that they should be tested more,
> > > I can write some additional testsuite.
> > >
> > > Thank you and have a nice day.
> >
> > RB+ from my side ...
>
> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> Please push!  (otherwise I'll do it in the morning)

Pushed to autobuild.


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org