[PATCH] properly type VFS_ADD_FSP_EXTENSION

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] properly type VFS_ADD_FSP_EXTENSION

Samba - samba-technical mailing list
Hi,

This is a minor cleanup of VFS_ADD_FSP_EXTENSION to have it make better
use of the provided type parameter.

Feedback/push appreciated.

Cheers, David

fsp_ext_type.patchset (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] properly type VFS_ADD_FSP_EXTENSION

Samba - samba-technical mailing list
On Tue, Dec 05, 2017 at 01:43:21PM +0100, David Disseldorp via samba-technical wrote:
> Hi,
>
> This is a minor cleanup of VFS_ADD_FSP_EXTENSION to have it make better
> use of the provided type parameter.
>
> Feedback/push appreciated.

afaict this misses vfs_glusterfs.c and vfs_cacheprime.c.

-slow

--
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2] properly type VFS_ADD_FSP_EXTENSION

Samba - samba-technical mailing list
On Tue, 5 Dec 2017 13:50:35 +0100, Ralph Böhme wrote:

> afaict this misses vfs_glusterfs.c and vfs_cacheprime.c

s/cacheprime/commit/? Anyhow, fixed. Please see attached.

Cheers, David

fsp_ext_type_v2.patchset (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2] properly type VFS_ADD_FSP_EXTENSION

Samba - samba-technical mailing list
On Tue, 5 Dec 2017 14:00:14 +0100, David Disseldorp via samba-technical wrote:

> -        if ((c = (struct commit_info *)VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
> +        if ((c = VFS_FETCH_FSP_EXTENSION(handle, fsp))) {

Hmm, this doesn't do anything, but was unintentional. New version
attached.

Cheers, David

fsp_ext_type_v3.patchset (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH v2] properly type VFS_ADD_FSP_EXTENSION

Samba - samba-technical mailing list
On Tue, Dec 05, 2017 at 02:13:14PM +0100, David Disseldorp wrote:
> On Tue, 5 Dec 2017 14:00:14 +0100, David Disseldorp via samba-technical wrote:
>
> > -        if ((c = (struct commit_info *)VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
> > +        if ((c = VFS_FETCH_FSP_EXTENSION(handle, fsp))) {
>
> Hmm, this doesn't do anything, but was unintentional. New version
> attached.

thanks, pushed.

-slow

--
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/