[PATCH] pam_winbind avoid non-literal-format by clang/FreeBSD

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] pam_winbind avoid non-literal-format by clang/FreeBSD

Samba - samba-technical mailing list
Hi,

This patch causes pam_winbind.c to pass FreeBSD picky-developer build,
avoiding the "non-literal format" warning without any #pragmas.

Please review and maybe push,
Uri.

pam_winbind-literal-format.patch.txt (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] pam_winbind avoid non-literal-format by clang/FreeBSD

Samba - samba-technical mailing list
On Tue, 2017-11-28 at 21:59 +0200, Uri Simchoni via samba-technical
wrote:
> Hi,
>
> This patch causes pam_winbind.c to pass FreeBSD picky-developer build,
> avoiding the "non-literal format" warning without any #pragmas.
>
> Please review and maybe push,
> Uri.

This looks reasonable to me.  

Reviewed-by: Andrew Bartlett <[hidden email]>

In autobuild.

Andrew Bartlett

--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba