[PATCH] notifyd: Broadcast to all connected nodes

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] notifyd: Broadcast to all connected nodes

Samba - samba-technical mailing list
Hi,

Replace CTDB_BROADCAST_VNNMAP with CTDB_BROADCAST_CONNECTED.

Please review and push.

Amitay.

0001-notifyd-Broadcast-to-all-connected-nodes.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] notifyd: Broadcast to all connected nodes

Samba - samba-technical mailing list
On Thu, Sep 28, 2017 at 03:10:22PM +1000, Amitay Isaacs via samba-technical wrote:
> Hi,
>
> Replace CTDB_BROADCAST_VNNMAP with CTDB_BROADCAST_CONNECTED.
>
> Please review and push.

Pushed, thanks!

Volker

>
> Amitay.

> From 246adc573bb1aad4e03891b1fa77c4a833339eea Mon Sep 17 00:00:00 2001
> From: Amitay Isaacs <[hidden email]>
> Date: Thu, 28 Sep 2017 11:44:50 +1000
> Subject: [PATCH] notifyd: Broadcast to all connected nodes
>
> CTDB_BROADCAST_VNNMAP includes only the nodes with lmaster roles.
> CTDB_BROADCAST_CONNECTED includes all the running nodes.
>
> Signed-off-by: Amitay Isaacs <[hidden email]>
> ---
>  source3/smbd/notifyd/notifyd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/source3/smbd/notifyd/notifyd.c b/source3/smbd/notifyd/notifyd.c
> index f645781afea..e4e5c785472 100644
> --- a/source3/smbd/notifyd/notifyd.c
> +++ b/source3/smbd/notifyd/notifyd.c
> @@ -81,7 +81,7 @@ struct notifyd_state {
>   * broadcasts its messaging_reclog to every other notifyd in
>   * the cluster. This is done by making ctdb send a message to
>   * srvid CTDB_SRVID_SAMBA_NOTIFY_PROXY with destination node
> - * number CTDB_BROADCAST_VNNMAP. Everybody in the cluster who
> + * number CTDB_BROADCAST_CONNECTED. Everybody in the cluster who
>   * had called register_with_ctdbd this srvid will receive the
>   * broadcasts.
>   *
> @@ -999,7 +999,7 @@ static void notifyd_broadcast_reclog(struct ctdbd_connection *ctdbd_conn,
>    .iov_len = blob.length };
>  
>   ret = ctdbd_messaging_send_iov(
> - ctdbd_conn, CTDB_BROADCAST_VNNMAP,
> + ctdbd_conn, CTDB_BROADCAST_CONNECTED,
>   CTDB_SRVID_SAMBA_NOTIFY_PROXY, iov, ARRAY_SIZE(iov));
>   TALLOC_FREE(blob.data);
>   if (ret != 0) {
> --
> 2.13.5
>


--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] notifyd: Broadcast to all connected nodes

Samba - samba-technical mailing list
On Thu, Sep 28, 2017 at 01:16:50PM +0200, Volker Lendecke wrote:
> On Thu, Sep 28, 2017 at 03:10:22PM +1000, Amitay Isaacs via samba-technical wrote:
> > Hi,
> >
> > Replace CTDB_BROADCAST_VNNMAP with CTDB_BROADCAST_CONNECTED.
> >
> > Please review and push.
>
> Pushed, thanks!

This now failed the ctdb part of autobuild 3 times in a row with

 PASSED  tests/shellcheck/event_scripts.sh
 PASSED  tests/shellcheck/functions.sh
 PASSED  tests/shellcheck/init_script.sh
 PASSED  tests/shellcheck/tools.sh
*FAILED* tests/simple/00_ctdb_init.sh

470/471 tests passed

Removing TEST_VAR_DIR=/memdisk/vlendec/a/b41255/ctdb/ctdb/tests/var
autotest exited with exit status 1

What am I doing wrong, or what are you doing differently such that
your private autobuilds succeed? I have Ralph Würthner's and the Samba
patch also in that same autobuild, but I would be surprised if this
made any difference to the pure ctdb make test.

Thanks,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] notifyd: Broadcast to all connected nodes

Samba - samba-technical mailing list
On Fri, Sep 29, 2017 at 12:40 AM, Volker Lendecke <[hidden email]
> wrote:

> On Thu, Sep 28, 2017 at 01:16:50PM +0200, Volker Lendecke wrote:
> > On Thu, Sep 28, 2017 at 03:10:22PM +1000, Amitay Isaacs via
> samba-technical wrote:
> > > Hi,
> > >
> > > Replace CTDB_BROADCAST_VNNMAP with CTDB_BROADCAST_CONNECTED.
> > >
> > > Please review and push.
> >
> > Pushed, thanks!
>
> This now failed the ctdb part of autobuild 3 times in a row with
>
>  PASSED  tests/shellcheck/event_scripts.sh
>  PASSED  tests/shellcheck/functions.sh
>  PASSED  tests/shellcheck/init_script.sh
>  PASSED  tests/shellcheck/tools.sh
> *FAILED* tests/simple/00_ctdb_init.sh
>
> 470/471 tests passed
>
> Removing TEST_VAR_DIR=/memdisk/vlendec/a/b41255/ctdb/ctdb/tests/var
> autotest exited with exit status 1
>
> What am I doing wrong, or what are you doing differently such that
> your private autobuilds succeed? I have Ralph Würthner's and the Samba
> patch also in that same autobuild, but I would be surprised if this
> made any difference to the pure ctdb make test.
>
> Thanks,
>
> Volker
>
>
This patch is fine.  The problem is with the other patches.

I have pushed this patch by itself.

Amitay.