[PATCH] mount.cifs: fix parsing of "cred=" option

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] mount.cifs: fix parsing of "cred=" option

Jeff Layton-4
When the mount option parsing was cleaned up recently, the detection of
the "cred=" option was dropped.

Signed-off-by: Jeff Layton <[hidden email]>
---
 mount.cifs.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mount.cifs.c b/mount.cifs.c
index 326b94e..65754c0 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -800,6 +800,8 @@ static int parse_opt_token(const char *token)
  return OPT_UNC;
  if (strncmp(token, "dom", 3) == 0 || strncmp(token, "workg", 5) == 0)
  return OPT_DOM;
+ if (strncmp(token, "cred", 4) == 0)
+ return OPT_CRED;
  if (strncmp(token, "uid", 3) == 0)
  return OPT_UID;
  if (strncmp(token, "gid", 3) == 0)
--
1.6.6.1

_______________________________________________
linux-cifs-client mailing list
[hidden email]
https://lists.samba.org/mailman/listinfo/linux-cifs-client
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] mount.cifs: fix parsing of "cred=" option

Scott Lovenberg
On 05/30/2010 07:58 AM, Jeff Layton wrote:

> When the mount option parsing was cleaned up recently, the detection of
> the "cred=" option was dropped.
>
> Signed-off-by: Jeff Layton<[hidden email]>
> ---
>   mount.cifs.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 326b94e..65754c0 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -800,6 +800,8 @@ static int parse_opt_token(const char *token)
>   return OPT_UNC;
>   if (strncmp(token, "dom", 3) == 0 || strncmp(token, "workg", 5) == 0)
>   return OPT_DOM;
> + if (strncmp(token, "cred", 4) == 0)
> + return OPT_CRED;
>   if (strncmp(token, "uid", 3) == 0)
>   return OPT_UID;
>   if (strncmp(token, "gid", 3) == 0)
>    
Crap, no idea how I missed that.  Thanks, Jeff.
I found another yesterday (maybe two, I need to get some clarification
on something).  I've got a patch I'll be sending off later today that
fixes another parsing error.

--
"... Of course, that's just my opinion; I could be wrong." --Dennis Miller

_______________________________________________
linux-cifs-client mailing list
[hidden email]
https://lists.samba.org/mailman/listinfo/linux-cifs-client