[PATCH] idmap: remove unused function idmap_is_online()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] idmap: remove unused function idmap_is_online()

Samba - samba-technical mailing list
Hello,

please see attached patch to remove unused function idmap_is_online().

Commit fa8f097 winbind: Remove unused idmap_[ug]id_to_sid
removed all callers of idmap_is_online().

--
Regards

    Ralph Wuerthner

0001-idmap-remove-unused-function-idmap_is_online.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] idmap: remove unused function idmap_is_online()

Samba - samba-technical mailing list
On Thu, Aug 03, 2017 at 04:21:16PM +0200, Ralph Wuerthner via samba-technical wrote:

> Hello,
>
> please see attached patch to remove unused function idmap_is_online().
>
> Commit fa8f097 winbind: Remove unused idmap_[ug]id_to_sid
> removed all callers of idmap_is_online().
>
> --
> Regards
>
>    Ralph Wuerthner

Reviewed-by: Christof Schmitt <[hidden email]>

> From b66418d3e87f4f907a2e186f35d7459189bb1abf Mon Sep 17 00:00:00 2001
> From: Ralph Wuerthner <[hidden email]>
> Date: Tue, 1 Aug 2017 16:40:30 +0200
> Subject: [PATCH] idmap: remove unused function idmap_is_online()
>
> Signed-off-by: Ralph Wuerthner <[hidden email]>
> ---
>  source3/torture/test_idmap_tdb_common.c | 5 -----
>  source3/winbindd/idmap.c                | 5 -----
>  source3/winbindd/idmap_proto.h          | 1 -
>  3 files changed, 11 deletions(-)
>
> diff --git a/source3/torture/test_idmap_tdb_common.c b/source3/torture/test_idmap_tdb_common.c
> index 897d2173..5ecb978 100644
> --- a/source3/torture/test_idmap_tdb_common.c
> +++ b/source3/torture/test_idmap_tdb_common.c
> @@ -57,11 +57,6 @@ bool winbindd_use_idmap_cache(void) {
>   return false;
>  }
>  
> -bool idmap_is_online(void)
> -{
> - return true;
> -}
> -
>  static bool open_db(struct idmap_tdb_common_context *ctx)
>  {
>   NTSTATUS status;
> diff --git a/source3/winbindd/idmap.c b/source3/winbindd/idmap.c
> index 70f35ae..6e70b44 100644
> --- a/source3/winbindd/idmap.c
> +++ b/source3/winbindd/idmap.c
> @@ -304,11 +304,6 @@ bool idmap_is_offline(void)
>       get_global_winbindd_state_offline() );
>  }
>  
> -bool idmap_is_online(void)
> -{
> - return !idmap_is_offline();
> -}
> -
>  /**********************************************************************
>   Allow a module to register itself as a method.
>  **********************************************************************/
> diff --git a/source3/winbindd/idmap_proto.h b/source3/winbindd/idmap_proto.h
> index 596c22f..f4fc2c2 100644
> --- a/source3/winbindd/idmap_proto.h
> +++ b/source3/winbindd/idmap_proto.h
> @@ -28,7 +28,6 @@
>  /* The following definitions come from winbindd/idmap.c  */
>  
>  bool idmap_is_offline(void);
> -bool idmap_is_online(void);
>  NTSTATUS smb_register_idmap(int version, const char *name,
>      struct idmap_methods *methods);
>  void idmap_close(void);
> --
> 2.7.4
>


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] idmap: remove unused function idmap_is_online()

Samba - samba-technical mailing list
On Thu, Aug 03, 2017 at 11:54:52AM -0700, Christof Schmitt via samba-technical wrote:

> On Thu, Aug 03, 2017 at 04:21:16PM +0200, Ralph Wuerthner via samba-technical wrote:
> > Hello,
> >
> > please see attached patch to remove unused function idmap_is_online().
> >
> > Commit fa8f097 winbind: Remove unused idmap_[ug]id_to_sid
> > removed all callers of idmap_is_online().
> >
> > --
> > Regards
> >
> >    Ralph Wuerthner
>
> Reviewed-by: Christof Schmitt <[hidden email]>

Pushed, thanks!

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Loading...