[PATCH] doc: man page updates

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] doc: man page updates

Samba - samba-technical mailing list


doc-changes.patch (36K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On Tue, 2017-12-12 at 22:41 +0100, Björn Jacke via samba-technical
wrote:
>


I've reviewed these and will autobuild them shortly.  The only change I
made was one samba4wins -> Samba fix.

Thanks for all the work on the docs, and for the 'If you have a WWW
viewer' gem!

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On Wed, 2017-12-13 at 22:03 +1300, Andrew Bartlett via samba-technical
wrote:

> On Tue, 2017-12-12 at 22:41 +0100, Björn Jacke via samba-technical
> wrote:
> >
>
>
> I've reviewed these and will autobuild them shortly.  The only change I
> made was one samba4wins -> Samba fix.
>
> Thanks for all the work on the docs, and for the 'If you have a WWW
> viewer' gem!

The WINS changes fail the docs test.

'make test TESTS=docs' should show you the issue.

Andrew Bartlett

> Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On 2017-12-14 at 07:02 +1300 Andrew Bartlett via samba-technical sent off:
> The WINS changes fail the docs test.
>
> 'make test TESTS=docs' should show you the issue.

the attached patch set makes the WINS changes succeed also.

Björn

docs.patch (53K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On Wed, 2017-12-20 at 21:57 +0100, Björn JACKE via samba-technical
wrote:
> On 2017-12-14 at 07:02 +1300 Andrew Bartlett via samba-technical sent off:
> > The WINS changes fail the docs test.
> >
> > 'make test TESTS=docs' should show you the issue.
>
> the attached patch set makes the WINS changes succeed also.
Thanks.

I'll take another look, but do note that it still mentions samba4wins.

Andrew Bartlett

--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba





Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On 20.12.2017 21:59, Andrew Bartlett wrote:
> .
>
> I'll take another look, but do note that it still mentions samba4wins.

ah, feel free to remove the sentence commit message if you don't like that.

I find the reference in the commit message useful because a number of
people used samba4wins and they have a chance to find a reference here
again and realize that all this is part of samba 4 actually now. Anyway,
I don't care too much about the mentioning.

Björn

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On Wed, 2017-12-20 at 22:06 +0100, Björn Jacke wrote:

> On 20.12.2017 21:59, Andrew Bartlett wrote:
> > .
> >
> > I'll take another look, but do note that it still mentions samba4wins.
>
> ah, feel free to remove the sentence commit message if you don't like that.
>
> I find the reference in the commit message useful because a number of
> people used samba4wins and they have a chance to find a reference here
> again and realize that all this is part of samba 4 actually now. Anyway,
> I don't care too much about the mentioning.

G'Day Björn,

I don't mind the commit messages, I agree with you!

I'm meaning the change in docs-xml/smbdotconf/wins/nbtd-
wins_randomize1clist.xml

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba





Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] doc: man page updates

Samba - samba-technical mailing list
On 2017-12-21 at 11:04 +1300 Andrew Bartlett via samba-technical sent off:
> I don't mind the commit messages, I agree with you!
>
> I'm meaning the change in docs-xml/smbdotconf/wins/nbtd-
> wins_randomize1clist.xml

ah, I see - updated patch attached!

Björn
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

docs.patch (53K) Download Attachment