[PATCH] ctdb-client: Initialize ctdb_ltdb_header completely for empty record

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] ctdb-client: Initialize ctdb_ltdb_header completely for empty record

Samba - samba-technical mailing list
Hi,

ctdb_ltdb_fetch() only fills in relevant portion of ctdb_ltdb_header
if the record does not exist.  This can result in uninitialized writes
to ctdb_rec_buffer.

Please review and push.

Amitay.

0001-ctdb-client-Initialize-ctdb_ltdb_header-completely-f.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] ctdb-client: Initialize ctdb_ltdb_header completely for empty record

Samba - samba-technical mailing list
On Wed, 13 Sep 2017 12:25:37 +1000, Amitay Isaacs via samba-technical
<[hidden email]> wrote:

> ctdb_ltdb_fetch() only fills in relevant portion of ctdb_ltdb_header
> if the record does not exist.  This can result in uninitialized writes
> to ctdb_rec_buffer.
>
> Please review and push.

Reviewed-by: Martin Schwenke <[hidden email]>

peace & happiness,
martin

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] ctdb-client: Initialize ctdb_ltdb_header completely for empty record

Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 12:28 PM, Martin Schwenke <[hidden email]> wrote:

> On Wed, 13 Sep 2017 12:25:37 +1000, Amitay Isaacs via samba-technical
> <[hidden email]> wrote:
>
> > ctdb_ltdb_fetch() only fills in relevant portion of ctdb_ltdb_header
> > if the record does not exist.  This can result in uninitialized writes
> > to ctdb_rec_buffer.
> >
> > Please review and push.
>
> Reviewed-by: Martin Schwenke <[hidden email]>
>
> peace & happiness,
> martin
>

Pushed to autobuild.

Amitay.