[PATCH] cifs: don't ignore cifs_posix_open_inode_helper return value

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] cifs: don't ignore cifs_posix_open_inode_helper return value

Suresh Jayaraman-2
.and ensure that we propagate the error back to avoid any surprises.

Signed-off-by: Suresh Jayaraman <[hidden email]>
---
 fs/cifs/file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index a83541e..ae89625 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -309,8 +309,8 @@ int cifs_open(struct inode *inode, struct file *file)
    on read only files needed here */
 
  pCifsFile = cifs_fill_filedata(file);
- cifs_posix_open_inode_helper(inode, file, pCifsInode,
-     oplock, netfid);
+ rc = cifs_posix_open_inode_helper(inode, file,
+ pCifsInode, oplock, netfid);
  goto out;
  } else if ((rc == -EINVAL) || (rc == -EOPNOTSUPP)) {
  if (tcon->ses->serverNOS)
--
1.6.4.2

_______________________________________________
linux-cifs-client mailing list
[hidden email]
https://lists.samba.org/mailman/listinfo/linux-cifs-client