[PATCH] a whole lot of little patches

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] a whole lot of little patches

Douglas Bagnall
These are mostly due to me running the likes of:

  find -name '*.py' |grep -v 'pep8' |xargs pyflakes |  grep ': undefined name'

I *tried* to ignore ./thirdparty and ./examples, but I accidentally fixed
a couple of things there.

I've also taken the liberty of .gitignoring some dot-files that various tools
like to create, and tuned one of the performance test scripts to be less slow.

One of the patches removes a bit of the non-functional Python selftest that I
missed last time.

An argument you could make against these patches is they clearly reveal parts
of the codebase that are not covered by tests, and we should really be fixing
that at the same time.

Douglas

a-whole-lot-of-little-things.patch (23K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] a whole lot of little patches

Samba - samba-technical mailing list
On Friday, 10 March 2017 01:31:59 CET Douglas Bagnall wrote:

> These are mostly due to me running the likes of:
>
>   find -name '*.py' |grep -v 'pep8' |xargs pyflakes |  grep ': undefined
> name'
>
> I *tried* to ignore ./thirdparty and ./examples, but I accidentally fixed
> a couple of things there.
>
> I've also taken the liberty of .gitignoring some dot-files that various
> tools like to create, and tuned one of the performance test scripts to be
> less slow.
>
> One of the patches removes a bit of the non-functional Python selftest that
> I missed last time.
>
> An argument you could make against these patches is they clearly reveal
> parts of the codebase that are not covered by tests, and we should really
> be fixing that at the same time.
>
> Douglas

RB+

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Loading...