[PATCH] Update VFS mknod to use struct smb_filename.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Update VFS mknod to use struct smb_filename.

Samba - samba-technical mailing list
Hi all,

In order to do the things we need to do in the VFS
moving forward and modernize it, we need to remove
all uses of pathnames passed in as const char *, and
replace them with const struct smb_filename *. This
will allow us to do all the fancy timestamp stuff etc.
I mentioned in my previous patch.

The functions we need to fix are:

disk_free
rename
link
symlink
chdir
readlink
mknod
realpth
getxattr
listxattr
removexattr
setxattr
get_real_filename
chflags

So here is a start, fixing the VFS mknod call
(it was an easy one to start with :-). Most of
these fixups are boilerplate, as most of the
other calls already use const struct smb_filename *.

This is independent of my other patch fixing
up the flags in pathname processing so can
be reviewed and pushed independently of that.

Please review and push if happy !

Cheers,

        Jeremy.

0001-s3-VFS-Change-SMB_VFS_MKNOD-to-use-const-struct-smb_.patch (20K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Update VFS mknod to use struct smb_filename.

Samba - samba-technical mailing list
On Fri, May 19, 2017 at 03:27:25PM -0700, Jeremy Allison wrote:

> Hi all,
>
> In order to do the things we need to do in the VFS
> moving forward and modernize it, we need to remove
> all uses of pathnames passed in as const char *, and
> replace them with const struct smb_filename *. This
> will allow us to do all the fancy timestamp stuff etc.
> I mentioned in my previous patch.
>
> The functions we need to fix are:
>
> disk_free
> rename
> link
> symlink
> chdir
> readlink
> mknod
> realpth
> getxattr
> listxattr
> removexattr
> setxattr
> get_real_filename
> chflags
>
> So here is a start, fixing the VFS mknod call

FYI. There are more that need fixing. I'm
creating a jumbo patch that includes this
one so please don't push this one for now !

Thanks,

        Jeremy.