[PATCH] Untangle CTDB monitoring from inactive node states, recovery, shutdown

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Untangle CTDB monitoring from inactive node states, recovery, shutdown

Samba - samba-technical mailing list
Currently the stop control, database recovery and shutdown sequence all
control the monitoring mode.  The monitoring code already knows about
recovery.

Instead, have the monitoring code check that the node is in a suitable
state for monitoring (i.e. running, active).  This means that the code
that changes the monitoring mode can be removed.  Then monitoring mode
and supporting code can also be removed.

Now we have 500 fewer lines of code to maintain! :-)

Please remove and maybe push...

peace & happiness,
martin

ctdb.patch (40K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Untangle CTDB monitoring from inactive node states, recovery, shutdown

Samba - samba-technical mailing list
On Wed, Sep 13, 2017 at 11:50 AM, Martin Schwenke via samba-technical <
[hidden email]> wrote:

> Currently the stop control, database recovery and shutdown sequence all
> control the monitoring mode.  The monitoring code already knows about
> recovery.
>
> Instead, have the monitoring code check that the node is in a suitable
> state for monitoring (i.e. running, active).  This means that the code
> that changes the monitoring mode can be removed.  Then monitoring mode
> and supporting code can also be removed.
>
> Now we have 500 fewer lines of code to maintain! :-)
>
> Please remove and maybe push...
>
>
Reviewed and pushed along with other ctdb patches.

Amitay.