[PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

Samba - samba-technical mailing list
Hello,

I've opened

https://bugzilla.redhat.com/show_bug.cgi?id=1430755

which our QA found. Attached is the patch to address the issue and I've added
a testcase so this will not happen in future.


Review and push appreciated!


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

net_ads_keytab.patch (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

Samba - samba-technical mailing list
On Mon, 2017-03-13 at 18:13 +0100, Andreas Schneider via samba-
technical wrote:

> Hello,
>
> I've opened
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1430755
>
> which our QA found. Attached is the patch to address the issue and
> I've added 
> a testcase so this will not happen in future.
>
>
> Review and push appreciated!

The only patch I'm cautious on is the subunit.sh patch.  Can you
explain it a bit more?  I'm hesitant because so much other finely
balanced code rests on that macro...

Other than that: Reviewed-by: Andrew Bartlett <[hidden email]>

Thanks for all your hard work here!

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

Samba - samba-technical mailing list
On Tue, Mar 14, 2017 at 06:49:10AM +1300, Andrew Bartlett via samba-technical wrote:

> On Mon, 2017-03-13 at 18:13 +0100, Andreas Schneider via samba-
> technical wrote:
> > Hello,
> >
> > I've opened
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1430755
> >
> > which our QA found. Attached is the patch to address the issue and
> > I've added 
> > a testcase so this will not happen in future.
> >
> >
> > Review and push appreciated!
>
> The only patch I'm cautious on is the subunit.sh patch.  Can you
> explain it a bit more?  I'm hesitant because so much other finely
> balanced code rests on that macro...
>
> Other than that: Reviewed-by: Andrew Bartlett <[hidden email]>

The subunit.sh one is correct. The difference between "$*" and "$@"
is explained here:

https://stackoverflow.com/questions/2761723/what-is-the-difference-between-and-in-shell-scripts

essentially - with "$@" the arguments: 1 2 '3 4'
get correctly expanded as:

1
2
3 4

with "$*", the last argument gets incorrectly split as it
contains spaces.

1
2
3
4

Reviewed-by: Jeremy Allison <[hidden email]>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

Samba - samba-technical mailing list
On Tue, 2017-03-14 at 09:52 -0700, Jeremy Allison wrote:

> On Tue, Mar 14, 2017 at 06:49:10AM +1300, Andrew Bartlett via samba-
> technical wrote:
> > On Mon, 2017-03-13 at 18:13 +0100, Andreas Schneider via samba-
> > technical wrote:
> > > Hello,
> > >
> > > I've opened
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1430755
> > >
> > > which our QA found. Attached is the patch to address the issue
> > > and
> > > I've added 
> > > a testcase so this will not happen in future.
> > >
> > >
> > > Review and push appreciated!
> >
> > The only patch I'm cautious on is the subunit.sh patch.  Can you
> > explain it a bit more?  I'm hesitant because so much other finely
> > balanced code rests on that macro...
> >
> > Other than that: Reviewed-by: Andrew Bartlett <[hidden email]>
>
> The subunit.sh one is correct. The difference between "$*" and "$@"
> is explained here:
>
> https://stackoverflow.com/questions/2761723/what-is-the-difference-be
> tween-and-in-shell-scripts
>
> essentially - with "$@" the arguments: 1 2 '3 4'
> get correctly expanded as:
>
> 1
> 2
> 3 4
>
> with "$*", the last argument gets incorrectly split as it
> contains spaces.
>
> 1
> 2
> 3
> 4
>
> Reviewed-by: Jeremy Allison <[hidden email]>

Thanks!  That was driving me nuts while trying to add some tests for
RODC, as our "allowed to replicate to the RODC" account is called
"testallowed account" with a space in it.

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] This fixes a regression with 'net ads' and kerberos method set to create keytab

Samba - samba-technical mailing list
On Wed, Mar 15, 2017 at 07:00:04AM +1300, Andrew Bartlett wrote:

> On Tue, 2017-03-14 at 09:52 -0700, Jeremy Allison wrote:
> > On Tue, Mar 14, 2017 at 06:49:10AM +1300, Andrew Bartlett via samba-
> > technical wrote:
> > > On Mon, 2017-03-13 at 18:13 +0100, Andreas Schneider via samba-
> > > technical wrote:
> > > > Hello,
> > > >
> > > > I've opened
> > > >
> > > > https://bugzilla.redhat.com/show_bug.cgi?id=1430755
> > > >
> > > > which our QA found. Attached is the patch to address the issue
> > > > and
> > > > I've added 
> > > > a testcase so this will not happen in future.
> > > >
> > > >
> > > > Review and push appreciated!
> > >
> > > The only patch I'm cautious on is the subunit.sh patch.  Can you
> > > explain it a bit more?  I'm hesitant because so much other finely
> > > balanced code rests on that macro...
> > >
> > > Other than that: Reviewed-by: Andrew Bartlett <[hidden email]>
> >
> > The subunit.sh one is correct. The difference between "$*" and "$@"
> > is explained here:
> >
> > https://stackoverflow.com/questions/2761723/what-is-the-difference-be
> > tween-and-in-shell-scripts
> >
> > essentially - with "$@" the arguments: 1 2 '3 4'
> > get correctly expanded as:
> >
> > 1
> > 2
> > 3 4
> >
> > with "$*", the last argument gets incorrectly split as it
> > contains spaces.
> >
> > 1
> > 2
> > 3
> > 4
> >
> > Reviewed-by: Jeremy Allison <[hidden email]>
>
> Thanks!  That was driving me nuts while trying to add some tests for
> RODC, as our "allowed to replicate to the RODC" account is called
> "testallowed account" with a space in it.

Yeah, I had to look it up. Bash is full of surprises :-).

Loading...