[PATCH] Small winbind improvements

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Small winbind improvements

Samba - samba-technical mailing list
Hi!

Review appreciated!

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

patch.txt (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Small winbind improvements

Samba - samba-technical mailing list
On Sun, 6 Aug 2017 11:30:25 +0200, Volker Lendecke via samba-technical
<[hidden email]> wrote:

> Review appreciated!

Reviewed-by: Martin Schwenke <[hidden email]>

Pushed...

peace & happiness,
martin

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Small winbind improvements

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
2017-08-06 2:30 GMT-07:00 Volker Lendecke via samba-technical
<[hidden email]>:
> Hi!
>
> Review appreciated!
>
> Thanks, Volker

Hi Volker,

The first two are no brainers and RB+ but the third one changes the
sense of the if condition. I will look at it more carefully now.

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Small winbind improvements

Samba - samba-technical mailing list
On Sun, Aug 6, 2017 at 7:26 PM, Richard Sharpe
<[hidden email]> wrote:

> 2017-08-06 2:30 GMT-07:00 Volker Lendecke via samba-technical
> <[hidden email]>:
>> Hi!
>>
>> Review appreciated!
>>
>> Thanks, Volker
>
> Hi Volker,
>
> The first two are no brainers and RB+ but the third one changes the
> sense of the if condition. I will look at it more carefully now.

OK. I agree with the third change (changes from !is_offline to
is_online, which is much easier to understand), so RB+ as well, but I
see Martin has already reviewed and pushed them.

--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

Loading...