[PATCH] Set close on exec in socket accept calls.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Set close on exec in socket accept calls.

Samba - samba-technical mailing list
Set SOCK_CLOEXEC on accept calls, this patch assumes that the samba
accepts are all handled by the socket wrapper code.

As always comments and reviews appreciated

Gary.


0001-lib-socket_wrapper-Set-close-on-exec-in-accept.patch.txt (1K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Set close on exec in socket accept calls.

Samba - samba-technical mailing list
On Sunday, 5 November 2017 19:44:50 CET Gary Lockyer via samba-technical
wrote:
> Set SOCK_CLOEXEC on accept calls, this patch assumes that the samba
> accepts are all handled by the socket wrapper code.
>
> As always comments and reviews appreciated

I'm sorry but why do you want to set this flag? It doesn't really make sense
especially for socket wrapper!


        Andreas

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Set close on exec in socket accept calls.

Samba - samba-technical mailing list
It looks like I need to think this one through, so please ignore until I
work out what I'm actually trying to do.

Gary.

On 09/11/17 05:15, Andreas Schneider via samba-technical wrote:

> On Sunday, 5 November 2017 19:44:50 CET Gary Lockyer via samba-technical
> wrote:
>> Set SOCK_CLOEXEC on accept calls, this patch assumes that the samba
>> accepts are all handled by the socket wrapper code.
>>
>> As always comments and reviews appreciated
>
> I'm sorry but why do you want to set this flag? It doesn't really make sense
> especially for socket wrapper!
>
>
> Andreas
>


signature.asc (484 bytes) Download Attachment