[PATCH] Port of samba.messaging to Python 3

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
Hello.

I've made another module - samba.messaging - Python 3 compatible. The
messaging module already has good test suite so I just ported it as well.

Have a nice day.

Lumír


0002-python-Port-tests-of-samba.messaging-to-Python-3-com.patch (2K) Download Attachment
0001-python-Port-samba.messaging-module-to-Python-3-compa.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
wrote:
> Hello.
>
> I've made another module - samba.messaging - Python 3 compatible. The
> messaging module already has good test suite so I just ported it as well.

I agree, it has a good testsuite.  It is lucky for you that you waited,
it was much less complete (or even functional!) just a few months ago.

Reviewed-by: Andrew Bartlett <[hidden email]>

Collect a second team reviewer and I'm sure this can join our autobuild
queue!

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On to, 14 syys 2017, Lumir Balhar via samba-technical wrote:
> Hello.
>
> I've made another module - samba.messaging - Python 3 compatible. The
> messaging module already has good test suite so I just ported it as well.
>
> Have a nice day.
>
RB+ by me. Thanks!

--
/ Alexander Bokovoy

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On to, 14 syys 2017, Andrew Bartlett via samba-technical wrote:

> On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
> wrote:
> > Hello.
> >
> > I've made another module - samba.messaging - Python 3 compatible. The
> > messaging module already has good test suite so I just ported it as well.
>
> I agree, it has a good testsuite.  It is lucky for you that you waited,
> it was much less complete (or even functional!) just a few months ago.
>
> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> Collect a second team reviewer and I'm sure this can join our autobuild
> queue!
I just sent my RB+, please push.
--
/ Alexander Bokovoy

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Thu, 2017-09-14 at 20:02 +1200, Andrew Bartlett wrote:

> On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
> wrote:
> > Hello.
> >
> > I've made another module - samba.messaging - Python 3 compatible. The
> > messaging module already has good test suite so I just ported it as well.
>
> I agree, it has a good testsuite.  It is lucky for you that you waited,
> it was much less complete (or even functional!) just a few months ago.
>
> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> Collect a second team reviewer and I'm sure this can join our autobuild
> queue!

Sadly it failed with:

[2149/4224] Compiling source4/lib/messaging/pymessaging.c
../source4/lib/messaging/pymessaging.c:496:2: error: missing braces
around initializer [-Werror=missing-braces]
  PyObject_HEAD_INIT(NULL) 0,
  ^
../source4/lib/messaging/pymessaging.c:496:2: error: (near
initialization for imessaging_Type.ob_base.ob_base) [-Werror=missing-
braces]
cc1: all warnings being treated as errors
Waf: Leaving directory `/memdisk/abartlet/a/b521293/samba/bin'
Build failed:  -> task failed (err #1): 
        {task: cc pymessaging.c -> pymessaging_9.o}
make: *** [all] Error 1

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
On 09/15/2017 05:58 AM, Andrew Bartlett wrote:

> On Thu, 2017-09-14 at 20:02 +1200, Andrew Bartlett wrote:
>> On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
>> wrote:
>>> Hello.
>>>
>>> I've made another module - samba.messaging - Python 3 compatible. The
>>> messaging module already has good test suite so I just ported it as well.
>> I agree, it has a good testsuite.  It is lucky for you that you waited,
>> it was much less complete (or even functional!) just a few months ago.
>>
>> Reviewed-by: Andrew Bartlett <[hidden email]>
>>
>> Collect a second team reviewer and I'm sure this can join our autobuild
>> queue!
> Sadly it failed with:
>
> [2149/4224] Compiling source4/lib/messaging/pymessaging.c
> ../source4/lib/messaging/pymessaging.c:496:2: error: missing braces
> around initializer [-Werror=missing-braces]
>    PyObject_HEAD_INIT(NULL) 0,
>    ^
> ../source4/lib/messaging/pymessaging.c:496:2: error: (near
> initialization for imessaging_Type.ob_base.ob_base) [-Werror=missing-
> braces]
> cc1: all warnings being treated as errors
> Waf: Leaving directory `/memdisk/abartlet/a/b521293/samba/bin'
> Build failed:  -> task failed (err #1):
>          {task: cc pymessaging.c -> pymessaging_9.o}
> make: *** [all] Error 1
>
> Andrew Bartlett
Hi.

I am sorry about that. I don't know how it is possible that my
build/test went well.

Fix patch attached.

Have a nice day.
Lumír

0003-python-Fix-Python-3-compatibility-in-samba.messaging.patch (919 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
Hello.

Is everything ok with the latest fixup patch?

Have a nice day.

Lumír


On 09/15/2017 09:08 AM, Lumir Balhar via samba-technical wrote:

> On 09/15/2017 05:58 AM, Andrew Bartlett wrote:
>> On Thu, 2017-09-14 at 20:02 +1200, Andrew Bartlett wrote:
>>> On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
>>> wrote:
>>>> Hello.
>>>>
>>>> I've made another module - samba.messaging - Python 3 compatible. The
>>>> messaging module already has good test suite so I just ported it as
>>>> well.
>>> I agree, it has a good testsuite.  It is lucky for you that you waited,
>>> it was much less complete (or even functional!) just a few months ago.
>>>
>>> Reviewed-by: Andrew Bartlett <[hidden email]>
>>>
>>> Collect a second team reviewer and I'm sure this can join our autobuild
>>> queue!
>> Sadly it failed with:
>>
>> [2149/4224] Compiling source4/lib/messaging/pymessaging.c
>> ../source4/lib/messaging/pymessaging.c:496:2: error: missing braces
>> around initializer [-Werror=missing-braces]
>>    PyObject_HEAD_INIT(NULL) 0,
>>    ^
>> ../source4/lib/messaging/pymessaging.c:496:2: error: (near
>> initialization for imessaging_Type.ob_base.ob_base) [-Werror=missing-
>> braces]
>> cc1: all warnings being treated as errors
>> Waf: Leaving directory `/memdisk/abartlet/a/b521293/samba/bin'
>> Build failed:  -> task failed (err #1):
>>          {task: cc pymessaging.c -> pymessaging_9.o}
>> make: *** [all] Error 1
>>
>> Andrew Bartlett
> Hi.
>
> I am sorry about that. I don't know how it is possible that my
> build/test went well.
>
> Fix patch attached.
>
> Have a nice day.
> Lumír


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Port of samba.messaging to Python 3

Samba - samba-technical mailing list
On Wed, 2017-10-04 at 13:12 +0200, Lumir Balhar wrote:
> Hello.
>
> Is everything ok with the latest fixup patch?
>
> Have a nice day.
>
> Lumír

Can you please squash and re-submit?  

In the meantime, can I get a second team reviewer for this change, and
if I get that I can just squash and push it?

Reviewed-by: Andrew Bartlett <[hidden email]> once squashed with
patch 1 from earlier in the thread.

Thanks,

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba