[PATCH] Patch for bug 13076

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Patch for bug 13076

Samba - samba-technical mailing list
Hi!

Attached is a patchset that fixes AppleDouble conversion in vfs_fruit.

https://bugzilla.samba.org/show_bug.cgi?id=13076

Please review & push if happy. Thanks!

-slow

bug13076-master.patch (47K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Patch for bug 13076

Samba - samba-technical mailing list
On Thu, Oct 12, 2017 at 07:54:40AM +0200, Ralph Böhme via samba-technical wrote:
> Attached is a patchset that fixes AppleDouble conversion in vfs_fruit.
>
> https://bugzilla.samba.org/show_bug.cgi?id=13076
>
> Please review & push if happy. Thanks!

Pushed, thanks!

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Patch for bug 13076

Samba - samba-technical mailing list
On Thu, Oct 12, 2017 at 12:51:00PM +0200, Volker Lendecke wrote:
> On Thu, Oct 12, 2017 at 07:54:40AM +0200, Ralph Böhme via samba-technical wrote:
> > Attached is a patchset that fixes AppleDouble conversion in vfs_fruit.
> >
> > https://bugzilla.samba.org/show_bug.cgi?id=13076
> >
> > Please review & push if happy. Thanks!
>
> Pushed, thanks!

I'm afraid this fails the allstatic build with

Checking project rules ...
ERROR: source source3/modules/string_replace.c is in more than one subsystem of target 'smbd_base': ['vfs_catia', 'vfs_fruit']

Do you want me to go in and fix this or do you have the time to give
it another try?

Thanks,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Patch for bug 13076

Samba - samba-technical mailing list
On Thu, Oct 12, 2017 at 11:13:24AM +0000, Volker Lendecke wrote:
> I'm afraid this fails the allstatic build with
>
> Checking project rules ...
>
> ERROR: source source3/modules/string_replace.c is in more than one subsystem
> of target 'smbd_base': ['vfs_catia', 'vfs_fruit']

oh, sorry for that. I got into the lazy habit of running private autobuilds with
just the samba target, so that wasn't caught.

> Do you want me to go in and fix this or do you have the time to give
> it another try?

Attached patchset passed a private autobuild of the samba-static target -- I
know, I know, lazy again, but it should pass now. Fingers crossed! ;)

I've also fixed the following issued you mentioned on IRC:

- removed "struct share_mapping_entry;" in string_replace.h

- s/larget/larger/ in one comment

Was there anything else?

Updated patchset attached.

-slow

bug13076-master.patch (47K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Patch for bug 13076

Samba - samba-technical mailing list
On Thu, Oct 12, 2017 at 01:15:30PM +0000, Ralph Böhme wrote:
> Updated patchset attached.

after irc ack: pushed. :)

-slow