[PATCH] Minor CTDB fixes

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Minor CTDB fixes

Samba - samba-technical mailing list
This includes a supposedly new CID. However, the fix is in test code
and adds a return result check (which can't fail, given context), so
no bug/backport is necessary.

Please review and maybe push...

peace & happiness,
martin

ctdb.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Minor CTDB fixes

Samba - samba-technical mailing list
On Thu, Oct 12, 2017 at 03:10:27PM +1100, Martin Schwenke via samba-technical wrote:
> This includes a supposedly new CID. However, the fix is in test code
> and adds a return result check (which can't fail, given context), so
> no bug/backport is necessary.
>
> Please review and maybe push...

Pushed, thanks.

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Minor CTDB fixes

Samba - samba-technical mailing list
On Thu, 12 Oct 2017 12:50:42 +0200, Volker Lendecke
<[hidden email]> wrote:

> On Thu, Oct 12, 2017 at 03:10:27PM +1100, Martin Schwenke via samba-technical wrote:
> > This includes a supposedly new CID. However, the fix is in test code
> > and adds a return result check (which can't fail, given context), so
> > no bug/backport is necessary.
> >
> > Please review and maybe push...  
>
> Pushed, thanks.

Thanks.  This didn't seem to land so I've pushed again with your
Reviewed-by: ...

peace & happiness,
martin

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Minor CTDB fixes

Samba - samba-technical mailing list
On Mon, Oct 16, 2017 at 02:27:32PM +1100, Martin Schwenke wrote:

> On Thu, 12 Oct 2017 12:50:42 +0200, Volker Lendecke
> <[hidden email]> wrote:
>
> > On Thu, Oct 12, 2017 at 03:10:27PM +1100, Martin Schwenke via samba-technical wrote:
> > > This includes a supposedly new CID. However, the fix is in test code
> > > and adds a return result check (which can't fail, given context), so
> > > no bug/backport is necessary.
> > >
> > > Please review and maybe push...  
> >
> > Pushed, thanks.
>
> Thanks.  This didn't seem to land so I've pushed again with your
> Reviewed-by: ...

Right, I had pushed it a few times, but it failed in completely
unrelated tests. At some point I forgot to re-push.

Sorry, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]