[PATCH] Fix tcp tickle synchronization on ctdb startup (bug 13154)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix tcp tickle synchronization on ctdb startup (bug 13154)

Samba - samba-technical mailing list
Hi,

Here are the patches that ensure that TCP tickles are synchronized on
CTDB startup and uses CTDB_BROADCAST_CONNECTED instead of
CTDB_BROADCAST_ALL.

CTDB_BROADCAST_ALL was used to queue up messages for nodes that are
not yet connected.  However, in case the nodes are deleted but the
nodes files are not updated, then the packets sent using
CTDB_BROADCAST_ALL would never get sent and keep consuming memory.

The problem of TCP tickle synchronization will go away once the new IP
failover daemon is implemented which will use replicated databases for
storing tickles.

Please review and push.

Amitay.

ctdb.patch (9K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix tcp tickle synchronization on ctdb startup (bug 13154)

Samba - samba-technical mailing list
On Thu, 30 Nov 2017 15:34:34 +1100, Amitay Isaacs via samba-technical
<[hidden email]> wrote:

> Here are the patches that ensure that TCP tickles are synchronized on
> CTDB startup and uses CTDB_BROADCAST_CONNECTED instead of
> CTDB_BROADCAST_ALL.
>
> CTDB_BROADCAST_ALL was used to queue up messages for nodes that are
> not yet connected.  However, in case the nodes are deleted but the
> nodes files are not updated, then the packets sent using
> CTDB_BROADCAST_ALL would never get sent and keep consuming memory.
>
> The problem of TCP tickle synchronization will go away once the new IP
> failover daemon is implemented which will use replicated databases for
> storing tickles.
>
> Please review and push.

Reviewed-by: Martin Schwenke <[hidden email]>

Pushed...

peace & happiness,
martin